From patchwork Wed Jan 1 00:00:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 38980 From: david.marchand@redhat.com (David Marchand) Date: Wed, 01 Jan 2020 00:00:00 -0000 Subject: [PATCH] abixml-reader: Support SONAME related properties on file suppression In-Reply-To: <861rqnzzpw.fsf@seketeli.org> References: <861rqnzzpw.fsf@seketeli.org> Message-ID: On Fri, Feb 21, 2020 at 5:19 PM Dodji Seketeli wrote: > > When comparing binary files (using abidiff for instance) libabigail > can interpret the [suppress_file] section of a suppression > specification. If the suppression specification matches either of the > compared files, no comparison is performed. > > At the moment, that doesn't work when comparing abixml files. > > Thus, this patch implements that feature for abixml files. > > With this patch, one can now write a suppression specification like > this: > > [suppress_file] > soname_regexp = > > or > > [suppress_file] > file_name_regexp = Tested this to exclude the experimental libraries we have in dpdk. Used libabigail-1.6-139-g1d6731c4 on dpdk 20.02-rc3 + patch: Thanks Dodji! diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index a59df8f13..edff9be45 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -2,6 +2,9 @@ symbol_version = EXPERIMENTAL [suppress_variable] symbol_version = EXPERIMENTAL +; Ignore experimental libraries +[suppress_file] + soname_regexp = \\.so\\.0\\. ; Explicit ignore for driver-only ABI [suppress_type]