diff mbox series

abixml-reader: Support SONAME related properties on file suppression

Message ID CAJFAV8zO9wcdB3mjONGo9jXL7Qop5YTt0rj2VM6wXj=9874jrg@mail.gmail.com
State Committed
Headers show
Series abixml-reader: Support SONAME related properties on file suppression | expand

Commit Message

David Marchand Jan. 1, 2020, midnight UTC
On Fri, Feb 21, 2020 at 5:19 PM Dodji Seketeli <dodji@seketeli.org> wrote:
>
> When comparing binary files (using abidiff for instance) libabigail
> can interpret the [suppress_file] section of a suppression
> specification.  If the suppression specification matches either of the
> compared files, no comparison is performed.
>
> At the moment, that doesn't work when comparing abixml files.
>
> Thus, this patch implements that feature for abixml files.
>
> With this patch, one can now write a suppression specification like
> this:
>
>   [suppress_file]
>     soname_regexp = <some-regexp>
>
> or
>
>   [suppress_file]
>     file_name_regexp = <some-regexp>

Tested this to exclude the experimental libraries we have in dpdk.
Used libabigail-1.6-139-g1d6731c4 on dpdk 20.02-rc3 + patch:



Thanks Dodji!

Comments

Dodji Seketeli Jan. 1, 2020, midnight UTC | #1
David Marchand <david.marchand@redhat.com> a ?crit:

[...]

>
> Tested this to exclude the experimental libraries we have in dpdk.
> Used libabigail-1.6-139-g1d6731c4 on dpdk 20.02-rc3 + patch:
>
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index a59df8f13..edff9be45 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -2,6 +2,9 @@
>          symbol_version = EXPERIMENTAL
>  [suppress_variable]
>          symbol_version = EXPERIMENTAL
> +; Ignore experimental libraries
> +[suppress_file]
> +       soname_regexp = \\.so\\.0\\.
>
>  ; Explicit ignore for driver-only ABI
>  [suppress_type]
>
>
> Thanks Dodji!

You are welcome!

Glad it helped.

Cheers,
diff mbox series

Patch

diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index a59df8f13..edff9be45 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -2,6 +2,9 @@ 
         symbol_version = EXPERIMENTAL
 [suppress_variable]
         symbol_version = EXPERIMENTAL
+; Ignore experimental libraries
+[suppress_file]
+       soname_regexp = \\.so\\.0\\.

 ; Explicit ignore for driver-only ABI
 [suppress_type]