From patchwork Mon Nov 22 16:21:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 47999 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 16FDD385801F for ; Mon, 22 Nov 2021 16:21:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 16FDD385801F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637598083; bh=JvCWtrib3lfS/Ei1lpELTkqB7M1FMVAbj7LPOXoLAKE=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=GmTzWpP9tMW6L/9zg6CZcOZUhPY5UrmKgFn4JfcfvQCCtt1C2p/Cz01werGxFn4Xo UmyjPjh4zdwGjYrjcsvgVj4HykLNAaJrwZtrzqb0es1uubpntqJUElbLK2Ld6fzXD/ VNrnnASSaPz0N5RhOLZyXT2WJjOro5JLDsWiNrYg= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2F97E3858406 for ; Mon, 22 Nov 2021 16:21:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2F97E3858406 Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452--EbER_EJP0mhmRZaqh5i8w-1; Mon, 22 Nov 2021 11:21:16 -0500 X-MC-Unique: -EbER_EJP0mhmRZaqh5i8w-1 Received: by mail-qt1-f200.google.com with SMTP id w12-20020ac80ecc000000b002a7a4cd22faso11057089qti.4 for ; Mon, 22 Nov 2021 08:21:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:organization:date:message-id :user-agent:mime-version; bh=JvCWtrib3lfS/Ei1lpELTkqB7M1FMVAbj7LPOXoLAKE=; b=fJRq7zs9Us7f0/QQEo/VTURxF4Zk1Vk1zafquTujwtHQq6MMsh3UvLoDMm20Y52Niq 4I6yl4cqf/NH7dcoLF8EpBTSBvLZpUrtFqUk2qgSS12Vmpy5305TTt24F+Y2dFzr54q7 TaoQET9Q7c9Pg0A7prZzKKVCcwu9UKAM/ummVDOwh5rB78Qqn9InAM6hAqb8umvh+M7i jusv852ezXWx2pfK9W+QO/ex4zu1GzwyZhuow4OHT5fcjUoS6+OFvrqH05L9I+0owxuT bqt5rLch33Eh75cx106tcyxLJWMAQSPyPqG3LbMBfcxYFp86EqA2kjedFw9zWK28OXhP zDeg== X-Gm-Message-State: AOAM530828erByRjYs11dkZYPybtpAAtd9rn1r6IiTzQc1LLnLM3L4hH w6+Gd7Pyt7lIzyqttV+/iye6REEQbZL7vJIQx3wBPFZTMvJ1jjLUXyhVi84gLp4LWNmuQrUzZCv vrATbvxIORE6nxrx26IX3psXt7VJvEvU2m8VnjkpfGe0GJbj2WWvTTOgMLfDX4edLigup X-Received: by 2002:a05:6214:3004:: with SMTP id ke4mr101911530qvb.48.1637598075812; Mon, 22 Nov 2021 08:21:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzESxk1+1U72Ps6DGo8wDmennd+wyXBkAo6H40YdosYMmVZ2gu5+63OzXwhHnsLV1Pb4jdNGw== X-Received: by 2002:a05:6214:3004:: with SMTP id ke4mr101911486qvb.48.1637598075488; Mon, 22 Nov 2021 08:21:15 -0800 (PST) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id v1sm4653948qtw.65.2021.11.22.08.21.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Nov 2021 08:21:15 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id BF43A58010A; Mon, 22 Nov 2021 17:21:12 +0100 (CET) To: libabigail@sourceware.org Subject: [PATCH] ctf-reader: Remove useless parameter from fill_ctf_section Organization: Red Hat / France X-Operating-System: Fedora 36 X-URL: http://www.redhat.com Date: Mon, 22 Nov 2021 17:21:12 +0100 Message-ID: <87zgpwtb47.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, While looking at something else, I noticed fill_ctf_section now has a useless parameter that was making compiling with some "tight" options cringe. Fixed thus. * src/abg-ctf-reader.cc (fill_ctf_section): Remove the now useless context parameter. Adjust the comment accordingly. (slurp_elf_info): Adjust the invocation of fill_ctf_section. Signed-off-by: Dodji Seketeli --- src/abg-ctf-reader.cc | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc index 2c2c204d..fd53f8a1 100644 --- a/src/abg-ctf-reader.cc +++ b/src/abg-ctf-reader.cc @@ -992,12 +992,11 @@ close_elf_handler (read_context *ctxt) /// Fill a CTF section description with the information in a given ELF /// section. /// -/// @param ctxt the read context. /// @param elf_section the ELF section from which to get. /// @param ctf_section the CTF section to fill with the raw data. static void -fill_ctf_section(read_context *ctxt, Elf_Scn *elf_section, ctf_sect_t *ctf_section) +fill_ctf_section(Elf_Scn *elf_section, ctf_sect_t *ctf_section) { GElf_Shdr section_header_mem, *section_header; Elf_Data *section_data; @@ -1046,9 +1045,9 @@ slurp_elf_info(read_context *ctxt, corpus_sptr corp) if (ctf_scn == NULL || symtab_scn == NULL || strtab_scn == NULL) return 0; - fill_ctf_section(ctxt, ctf_scn, &ctxt->ctf_sect); - fill_ctf_section(ctxt, symtab_scn, &ctxt->symtab_sect); - fill_ctf_section(ctxt, strtab_scn, &ctxt->strtab_sect); + fill_ctf_section(ctf_scn, &ctxt->ctf_sect); + fill_ctf_section(symtab_scn, &ctxt->symtab_sect); + fill_ctf_section(strtab_scn, &ctxt->strtab_sect); return 1; }