From patchwork Thu Mar 2 18:55:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 65914 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA2A53858CDB for ; Thu, 2 Mar 2023 18:55:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA2A53858CDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677783332; bh=nRj4x8pVg67/DaQCbAqJH0weGjaT7La/xS9VX4WnPIo=; h=To:Cc:Subject:References:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Help:List-Subscribe:From: Reply-To:From; b=m6O8CDVfy4VbjrBJ7klI//xD7ZtY8TwGjTDGSw6s5J0wNp7zCJsfYpzWii+nDnCMd Yy5p8NBaKqkDAZNDi6FMsKTYrD2AfE+lAI8DQrudU43hPVU7hcl3N73Q0SlxVqLziU 8abAn4pY8sz5WKj2iMKapE6wh692WhJLLV0yAO1w= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 651073858D33 for ; Thu, 2 Mar 2023 18:55:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 651073858D33 Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-458-xz2DevExMhSqD0qv0E_nCA-1; Thu, 02 Mar 2023 13:55:26 -0500 X-MC-Unique: xz2DevExMhSqD0qv0E_nCA-1 Received: by mail-qt1-f200.google.com with SMTP id z22-20020ac86b96000000b003bfc3f97097so122983qts.14 for ; Thu, 02 Mar 2023 10:55:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677783325; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nRj4x8pVg67/DaQCbAqJH0weGjaT7La/xS9VX4WnPIo=; b=myecVboxE8NIUf04Y2tdyzTHrc5BUYOhRHVE4G+9Xh5AzRPRqCi+p6Wvs2LaqR6Qfv p/wJ0gYG7H2nOr7eU9bozcXyhdXQbAjfDvaLiGccpl2goYJsaTVPIUiS1DGO+55F+pVJ AQ8R5wNbLKp2ir8q7T/8fXaoZJMIyha15kO91roHrZQipKAckNg3DB4ZUhjeHX2oUzES RjYBt2x4kq8y7P0To1q9QCedjxtKnQh6mWou5LgYp/B298Di5/RA0Lkibd+RWUsSbmmA uXosuEUPMzUO1ixkuimtxsGrCtB5otGV+yVoMzmqTXZvvojdBOVH7FoQCjJdIFhFVOlF qNSw== X-Gm-Message-State: AO0yUKW6RXXoUKMrTYy++Oc2LavvxIdOFCZ2aMympe+xaGxuN6WExM0P MPecyFopdZClQ7fmbv7USmuaGDpDxAroZy8iLQh6eiatGbtG47/OLtIADdpJTuCWKfa8QyBK2E6 /M/ZjHfzxUHz0f9cLSYssngM/oA== X-Received: by 2002:ac8:5f0a:0:b0:3bf:d9a9:25fb with SMTP id x10-20020ac85f0a000000b003bfd9a925fbmr19733559qta.10.1677783325135; Thu, 02 Mar 2023 10:55:25 -0800 (PST) X-Google-Smtp-Source: AK7set/leUETu72ybh1DM57926fw48YWzcI1Ztvpsckav2AnHVF+h+DWG2hcGBv4M//umXXroQfvpg== X-Received: by 2002:ac8:5f0a:0:b0:3bf:d9a9:25fb with SMTP id x10-20020ac85f0a000000b003bfd9a925fbmr19733536qta.10.1677783324898; Thu, 02 Mar 2023 10:55:24 -0800 (PST) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id 191-20020a370cc8000000b007416c11ea03sm206297qkm.26.2023.03.02.10.55.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 10:55:24 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id D4758581C79; Thu, 2 Mar 2023 19:55:22 +0100 (CET) To: libabigail@sourceware.org Cc: dodji@redhat.com, ckalina@redhat.com Subject: [PATCH 01/13] ini: Fix parsing list property values Organization: Red Hat / France References: <877cvzrnws.fsf@redhat.com> <87356nrnmq.fsf@redhat.com> X-Operating-System: Fedora 38 X-URL: http://www.redhat.com Date: Thu, 02 Mar 2023 19:55:22 +0100 In-Reply-To: <87356nrnmq.fsf@redhat.com> (Dodji Seketeli's message of "Thu, 02 Mar 2023 19:53:17 +0100") Message-ID: <87y1ofq8yt.fsf_-_@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, While looking at something else, I came across an issue in read_context::read_list_property_value. This function requires elements of a list property value (separated by a comma) to be on a single line, for instance. This is because the code forgets to parse white spaces after the comma. Fixed thus. * src/abg-ini.cc (read_context::read_list_property_value): Expect white spaces after the comma. Signed-off-by: Dodji Seketeli --- src/abg-ini.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/abg-ini.cc b/src/abg-ini.cc index 227e3c84..db041962 100644 --- a/src/abg-ini.cc +++ b/src/abg-ini.cc @@ -1440,6 +1440,7 @@ public: char c = 0; read_next_char(c); ABG_ASSERT(c == ','); + skip_white_spaces(); } if (!content.empty())