From patchwork Mon Oct 18 08:57:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 46329 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DD8303858433 for ; Mon, 18 Oct 2021 08:58:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DD8303858433 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1634547504; bh=Yhpd6B+xuKR/CN6zcWoEC/U981ePf6tFWbG9gnc81TQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=CMIFrU3bBaxrT4kUcrjWVOSE47v9opIbvWflN6yuWXMSKa0FQcVseJcDxwWXL096w 9eegPMshI/30VmDmE/GVLuMaEwZleZEyjKVyw0/6FSnjHZW6a8mBJi3ftDRlReK84b CtL3MuUKnIb3jkyiQQQ6JaNq72Y0ZIGHfAUPy2fM= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9B1203858015 for ; Mon, 18 Oct 2021 08:57:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B1203858015 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-IKjUbHw2P_2BgZQFWFx3-w-1; Mon, 18 Oct 2021 04:57:32 -0400 X-MC-Unique: IKjUbHw2P_2BgZQFWFx3-w-1 Received: by mail-qv1-f72.google.com with SMTP id q17-20020ad45491000000b003832299965bso14293908qvy.18 for ; Mon, 18 Oct 2021 01:57:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:organization:date:message-id :user-agent:mime-version; bh=Yhpd6B+xuKR/CN6zcWoEC/U981ePf6tFWbG9gnc81TQ=; b=QtHvhhzLqLbIuAPKOxxAhstJ49nyRBy1x1yQMPi2z498Mjz6NXkiJLnzmadPKjwTzq eouDR5+WGO/jgeeu4awg6FKpCZv7VDKPurD9PPEouxJlCM5tZsg6YQ+TqbSTjjq/Zbak yGVNAeOy8YM73q/3beIlmcQZ4jwL+HSmkjNbtsD4oUpnJczyF0E341jIkgEZiVO+t7Ix OXB/DjHQQ4IeZBiAWQg/KpNeLL7Ssi+arL5G4NFHXF02NhlANMXMoF6ciG1iapXqUrPq 7XfcesRAfagtnUXrIszyhS4YQzaDwkIKx1wtf38stJNwjPQM7H5baRSI0cxbKal8aJQf TgGQ== X-Gm-Message-State: AOAM53059yJ3du/WlgMcdNuAa/QJ/KXH/77wZJWMV3EaidvppliAj3Dd KmQWhFGWM0Vi2If7VSKRlT6dIUY/hEMwaGnq5ETN+SPQl9E6X6nbny07bDYmIHrO3bxTJXy1L6B ctM2jS5RSDyA6+oZlHt+6phFTqJAS1Ofv5d5bCllqTDxD4YGtvFDUtpU6D+bNC0sctP9O X-Received: by 2002:a0c:cd86:: with SMTP id v6mr23584149qvm.22.1634547451306; Mon, 18 Oct 2021 01:57:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmmWs7h6T2gKnxse5IB5Bkk5IV5i6Gv4JGLYr99iOZcsAD48JywIQa7sm5ZF6aQjLPn1I+Bw== X-Received: by 2002:a0c:cd86:: with SMTP id v6mr23584140qvm.22.1634547451074; Mon, 18 Oct 2021 01:57:31 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id t3sm6367567qta.90.2021.10.18.01.57.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 01:57:30 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id F01485802BD; Mon, 18 Oct 2021 10:57:28 +0200 (CEST) To: libabigail@sourceware.org Subject: [PATCH, applied] writer: Don't forget when emitting array subrange types Organization: Red Hat / France X-Operating-System: Fedora 36 X-URL: http://www.redhat.com Date: Mon, 18 Oct 2021 10:57:28 +0200 Message-ID: <87wnmabthj.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, When looking into something else, I noticed that we were forgetting when array subranges are emitted. Fixed thus. * src/abg-writer.cc (write_array_subrange_type): Record the type as emitted. Signed-off-by: Dodji Seketeli Applied to master. --- src/abg-writer.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/abg-writer.cc b/src/abg-writer.cc index 3848df77..6f2fee16 100644 --- a/src/abg-writer.cc +++ b/src/abg-writer.cc @@ -2921,6 +2921,8 @@ write_array_subrange_type(const array_type_def::subrange_sptr& decl, o << "/>\n"; + ctxt.record_type_as_emitted(decl); + return true; }