From patchwork Mon Oct 18 08:58:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 46330 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 195AE3858438 for ; Mon, 18 Oct 2021 08:58:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 195AE3858438 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1634547529; bh=df6pvMA1PbzlbBrmos7PQ0CCp1p5It5JxI5OlgDlLbY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=VRdE5OFVb5AJdgWx1d3s0YPTVNEKHHqvhVsex8gYaip/m/qqtw9MnbhcU3bWyr7H/ dhkoNsLSRwiJiTAyXDth32z2meMsIdiF/Sh2uSxm9Nd7y7uK3uNRP+8B88Njbx/nBb hPaKjEtI2bTmCDDtlfECndj2nqOdMSv1Yd3IvrRo= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 567F8385842E for ; Mon, 18 Oct 2021 08:58:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 567F8385842E Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-HwAatb3NNBKO1G3HcjOrvw-1; Mon, 18 Oct 2021 04:58:23 -0400 X-MC-Unique: HwAatb3NNBKO1G3HcjOrvw-1 Received: by mail-qv1-f72.google.com with SMTP id p9-20020a05621421e900b003830bb235fbso14314944qvj.14 for ; Mon, 18 Oct 2021 01:58:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:organization:date:message-id :user-agent:mime-version; bh=df6pvMA1PbzlbBrmos7PQ0CCp1p5It5JxI5OlgDlLbY=; b=GC8O4v/N5CkuX2bhbbKLuXOOsWHUXgn4+XLyZ18SYxKH7lj9zZO2hV9vaNl2x7H8oP 54NiI0854Ne4nQr9SENh5d1AxMiy1cLLk33ULCO/uxU7RaMMQQisEIsT8kHQ140oF17z Ko8KUvwiAHfDEomQarIKKLyNYjWGPrFjaHJZiawhdHJjaEi3nWQ/g6aGsXazyB5xkt1l UO7JIpRoK8Be8l4Hz9fJxkpPfZwodPemYVTXm5Hh6paMrU0d3sS5Bsuqxq7NtuPJHCQG xIMiuWQpCBDgOQXvCYMYAzVlRe2LiBSRIonRI10viHjNXKTLuCyaTt8tA3SNxu+RBfHs TmeQ== X-Gm-Message-State: AOAM532BPiIRG10OKejudTsa3RjILiKKNIM/1X+1c+9aXLpaE3Gy0dko 7QA9k4zRGZX8tQVYUqP3h+AIaxe4/dwfqZLPUiCebqtOci/Vzi2rbOMMNyhPopRmGxXSLhUTflU qCuCTGN6BtqklZDHjckESOJlWwjBja8PLHCPfeZMiYq472eMhn9DmaW2GyUkvo9exyhWt X-Received: by 2002:ac8:5a41:: with SMTP id o1mr27683686qta.21.1634547503138; Mon, 18 Oct 2021 01:58:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz414Pavap7YYWnDuJxzEQpoGV3Q4lMF/tJ8ct/LJQ8VyEW4weRkw2/J6id7zNL/6uYNiqbag== X-Received: by 2002:ac8:5a41:: with SMTP id o1mr27683671qta.21.1634547502912; Mon, 18 Oct 2021 01:58:22 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id i85sm6380699qke.61.2021.10.18.01.58.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 01:58:22 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id E17C45802BD; Mon, 18 Oct 2021 10:58:20 +0200 (CEST) To: libabigail@sourceware.org Subject: [PATCH, applied] writer: Don't forget that a naming typedef is referenced Organization: Red Hat / France X-Operating-System: Fedora 36 X-URL: http://www.redhat.com Date: Mon, 18 Oct 2021 10:58:20 +0200 Message-ID: <87sfwybtg3.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, While looking into something else, I noticed that when emitting the 'naming-typedef' property of class, the typedef wasn't categorized as a referenced type. So sometimes the writer could forget to emit the naming typedef itself later. Fixed thus. * src/abg-writer.cc (write_naming_typedef): Notice that the naming typedef is referenced. Signed-off-by: Dodji Seketeli Applied to master. --- src/abg-writer.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/abg-writer.cc b/src/abg-writer.cc index 6f2fee16..693f99c6 100644 --- a/src/abg-writer.cc +++ b/src/abg-writer.cc @@ -1887,6 +1887,7 @@ write_naming_typedef(const decl_base_sptr& decl, write_context& ctxt) { string id = ctxt.get_id_for_type(typedef_type); o << " naming-typedef-id='" << id << "'"; + ctxt.record_type_as_referenced(typedef_type); } }