diff mbox series

[6/6] abipkgdiff: make --self-check to fail on any change against own ABIXML

Message ID 87r1oe682s.fsf@redhat.com
State Committed
Headers show
Series Fix subtle ABI artifact representation issues | expand

Commit Message

Dodji Seketeli Nov. 27, 2020, 5:08 p.m. UTC
Hello,

Now that several subtle causes of spurious ABI change report when
comparing a binary against its own ABIXML have been addressed, this
patch makes 'abipkgdiff --self-check' to fail on any ABI change
reported.  That is, harmless changes are not ignored anymore.

	* tools/abipkgdiff.cc (compare_to_self): Report *any* ABI change.
	Not just the "net" changes.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>

Applied to master.
---
 tools/abipkgdiff.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc
index 2968338a..709b687a 100644
--- a/tools/abipkgdiff.cc
+++ b/tools/abipkgdiff.cc
@@ -1649,7 +1649,7 @@  compare_to_self(const elf_file& elf,
       << "... Comparing the ABIs: DONE\n";
 
   abidiff_status s = abigail::tools_utils::ABIDIFF_OK;
-  if (diff->has_net_changes())
+  if (diff->has_changes())
     s |= abigail::tools_utils::ABIDIFF_ABI_CHANGE;
   if (diff->has_incompatible_changes())
     s |= abigail::tools_utils::ABIDIFF_ABI_INCOMPATIBLE_CHANGE;