From patchwork Wed May 17 15:30:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 69525 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8E2DA3864C5F for ; Wed, 17 May 2023 15:31:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E2DA3864C5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1684337466; bh=n3BTEptpYGA+PIOTcEUGhqHg+EsSyxy8TXV69GTSr/E=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=kLTF2GOsLm6xVN/XM3K3Lep0hdI/7+YB5qoHYrcGFnE3ATp5fM5VL3tZLcVj6NI// Bz8OOtJSMI+j/tfhFBq3qYOcXjYhNouPLNq57pNznV1FUe2TSpb+5Eo1DusnSEhx1h SF7PT8xWqy5TS5xfb2qcHV38rLFbnvTZZmvu6AvQ= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4D40E3858C5E for ; Wed, 17 May 2023 15:31:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D40E3858C5E Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-75ln5MMKMgW7Ps7zFYBY_w-1; Wed, 17 May 2023 11:30:57 -0400 X-MC-Unique: 75ln5MMKMgW7Ps7zFYBY_w-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-61abb7cd89cso5071406d6.3 for ; Wed, 17 May 2023 08:30:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684337457; x=1686929457; h=mime-version:user-agent:message-id:date:organization:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n3BTEptpYGA+PIOTcEUGhqHg+EsSyxy8TXV69GTSr/E=; b=gESZEdqsogRgC3jz5FR941YT80w/qbfyIWiZV6vpfNOJiKr9MYzhuoZvgoGJ9aMkM+ YRfIcvTQ/lMSJn4kURvRrQ+dBBSfEFnQXuLoIDr/w8mkI/2KRrZFgwvVq390RjiG7oRM VS+njmgHXDt8W+NUS/RIiYMhh7pCHnW6uK6fytGIMqNyzwpvQBSjHMytObZf8/c3Y0th 6KB2S71WultyqSQuf7fbiiLGOoIPtKm+KzJ3cFf9G7DZo6ZLNbhbepDa2EEn4mqrdOMw PtMw4zju4rjkOmhtt6+WJDYopd7+CfC/oB2UeynHfqA12t4me2TCPrT/qAecwvP0g7Ft 4xLw== X-Gm-Message-State: AC+VfDzdEhDu1TLgEodhQLS4YiK9apF3xsFFYowUfewaCFqj9NeLiLuY GqInD995Q+lNIbrhQ8NULatEce0tbp8zowizEAcX6hQjoSw8O1dQmIhr/1bz/bpy7oHFZFmCsGi gOznWXd+aIoYJCJD6VmpuoNr38yliCkXBVQXEZrvYOe5g6FIS0carE+yJOkOwlG8CkvhPVaFjm3 hY X-Received: by 2002:a05:6214:29ca:b0:623:8387:3d0f with SMTP id gh10-20020a05621429ca00b0062383873d0fmr60245qvb.28.1684337457026; Wed, 17 May 2023 08:30:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4WsTmaNiqFQjl8XqOpAhd27SGJ6LbHuyxpJI/kiQ7lg0CqjlUr27kiNWk5Ptx7UDJNh6xxOg== X-Received: by 2002:a05:6214:29ca:b0:623:8387:3d0f with SMTP id gh10-20020a05621429ca00b0062383873d0fmr60212qvb.28.1684337456638; Wed, 17 May 2023 08:30:56 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id f5-20020ad45585000000b006238b37fb05sm226363qvx.119.2023.05.17.08.30.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 08:30:56 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 290EE34770; Wed, 17 May 2023 17:30:54 +0200 (CEST) To: libabigail@sourceware.org Subject: [PATCH, applied] Bug 29693 - clang-libs from f37 fails self test Organization: Red Hat / France X-Operating-System: CentOS Stream release 9 X-URL: http://www.redhat.com Date: Wed, 17 May 2023 17:30:54 +0200 Message-ID: <87r0rf0yc1.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, To reproduce the issue reported in the bug above, here is the relevant command line: $ tools/fedabipkgdiff --self-compare -a --from fc37 clang-libs When the abixml reader encounters a decl-only class, it wrongly avoids trying to read its members. This is wrong because a decl-only class can still have member types. By doing so, the abixml might "forget" some member types, leading to self comparison errors as the original class from DWARF (for instance) might have those member types. Fixed thus. * src/abg-reader.cc (build_class_decl): Read member types even when we are looking at a decl-only class. Signed-off-by: Dodji Seketeli --- src/abg-reader.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/abg-reader.cc b/src/abg-reader.cc index f318dbb9..f54e22aa 100644 --- a/src/abg-reader.cc +++ b/src/abg-reader.cc @@ -4825,7 +4825,7 @@ build_class_decl(reader& rdr, maybe_set_naming_typedef(rdr, node, decl); for (xmlNodePtr n = xmlFirstElementChild(node); - !is_decl_only && n; + n; n = xmlNextElementSibling(n)) { if (xmlStrEqual(n->name, BAD_CAST("base-class")))