[applied] Bug 29693 - clang-libs from f37 fails self test

Message ID 87r0rf0yc1.fsf@redhat.com
State New
Series [applied] Bug 29693 - clang-libs from f37 fails self test |

Commit Message

Dodji Seketeli May 17, 2023, 3:30 p.m. UTC

To reproduce the issue reported in the bug above, here is the relevant
command line:

    $ tools/fedabipkgdiff --self-compare -a --from fc37 clang-libs

When the abixml reader encounters a decl-only class, it wrongly avoids
trying to read its members.  This is wrong because a decl-only class
can still have member types.  By doing so, the abixml might "forget"
some member types, leading to self comparison errors as the original
class from DWARF (for instance) might have those member types.

Fixed thus.

	* src/abg-reader.cc (build_class_decl): Read member types even
	when we are looking at a decl-only class.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
 src/abg-reader.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/src/abg-reader.cc b/src/abg-reader.cc
index f318dbb9..f54e22aa 100644
--- a/src/abg-reader.cc
+++ b/src/abg-reader.cc
@@ -4825,7 +4825,7 @@  build_class_decl(reader&		rdr,
   maybe_set_naming_typedef(rdr, node, decl);
   for (xmlNodePtr n = xmlFirstElementChild(node);
-       !is_decl_only && n;
+       n;
        n = xmlNextElementSibling(n))
       if (xmlStrEqual(n->name, BAD_CAST("base-class")))