Message ID | 87r0e9c1hn.fsf@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <libabigail-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7757D3844770 for <patchwork@sourceware.org>; Fri, 10 May 2024 12:09:44 +0000 (GMT) X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E4E923844752 for <libabigail@sourceware.org>; Fri, 10 May 2024 12:09:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4E923844752 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E4E923844752 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715342972; cv=none; b=EVXC50lwJCGemM3tQhDDznsqseXHlLHG/RtzvBaZFDGKPjKb/02+GHpMZ4GvoII6oYVBh7pSMMb01OYB63zshZl6r8x6HeP/uy9tiY4pHP5ceX3VWHI3b6zGNyvMdyGDSuTn5GTay5kvqp9vU7+80Wg2A4Kh/jlJr/gCixTLfCc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715342972; c=relaxed/simple; bh=X04LRZs33usTveNWI2YpxjtlUZKiVipHhYul4uJ67m4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LaAME0sEG7Q3bLcer+MXyE7mNZkVRFalsv5owlaoMgwqETKqF6ReOzrSkpvuUXaVpEkF2likocl+7XgGumbwrYj+HFTG+M5GBaVo1IaFb03+ZUutFruVvAAmQ4Ry6E765Xu4I8TRrysUFjBiNG21nxUKx1eY6NQNQU5+zKbdje0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715342970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=N3xC62u9ieVwg48XeMGGj45/RPlt8V9PE2HZI9fUGO4=; b=FKFy098/5S23NqPS1DZZDHkWKacDVQ/lYc5sUw9oeDzNwckZVBkCkjcYjaTwnYCx//1RQ7 yATjkq69R8/zCx+/YO7JcZ+EMjaeN7hOwOIXYpRzxTdj63BdBusatfMHt7tpbfsKUs2Beb i6CieiI9xrN37FgvEorkqZc2AVrdW5U= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-ApU5Ke7oPbuvf5E-gXvg5g-1; Fri, 10 May 2024 08:09:29 -0400 X-MC-Unique: ApU5Ke7oPbuvf5E-gXvg5g-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-78ed2a710efso217395985a.1 for <libabigail@sourceware.org>; Fri, 10 May 2024 05:09:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715342968; x=1715947768; h=mime-version:user-agent:message-id:date:organization:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N3xC62u9ieVwg48XeMGGj45/RPlt8V9PE2HZI9fUGO4=; b=p+uzHZjHeo44mXKhYshQ8VVugD8L6WwuHU1q8M/+BqZGGy2sHhv3aPivsgL739LKSS 71hCFdvx/VS5ccni5BwTEIvVTJ+UQrzsEAuAf7LU/i3w4pRKliP6DHeal24pjVQNCyZH 4Nl2LLEGCr+LCZ/yjMm98osUOJyanpqi7s8nax8pnvmuKR8qeYP0D0wQRhz2f9voJRf6 wzok+xZDbQPkChbHIw70sBiEcRMMp5gliiW11tMmY+GhXfvgi/FV/wHJOqIZbUC2BEON dl5jue0oBqltlfGQCJyOPzwyWo0yzcU0+bz5FvzO+SMRJ2VygzZhxcgJi8vID9BeKRe1 /ShQ== X-Gm-Message-State: AOJu0Yy79v/+fVi+W77E6qQgDwS+zrzww2nqCe6zIbXcyE1kpR/2wxOm efgnknesV7spi0+ovIkkVCGjhDiLO5PBxNgqVwdpkja/lx4CDIU8TZSDqq/lwT9TYvyxgaYWDOL A8u21PY2clXdLdwC/JitF+PlffFa31so+lu2oeRBslt+h+P0DzmiJsvR52ZYqPcey4Q== X-Received: by 2002:a05:620a:5e0b:b0:790:9b17:823e with SMTP id af79cd13be357-792c7576105mr265515185a.12.1715342967917; Fri, 10 May 2024 05:09:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNkzouLCRCL//vC4mxmvTOuPfHROilxtpzNYpGFeJMDwuIS/ggNBPJXVWJn/jD1lwgmhUsWA== X-Received: by 2002:a05:620a:5e0b:b0:790:9b17:823e with SMTP id af79cd13be357-792c7576105mr265513585a.12.1715342967562; Fri, 10 May 2024 05:09:27 -0700 (PDT) Received: from localhost (88-120-130-27.subs.proxad.net. [88.120.130.27]) by smtp.gmail.com with ESMTPSA id af79cd13be357-792bf27f870sm173579285a.28.2024.05.10.05.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 05:09:27 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id CA344507A61B; Fri, 10 May 2024 14:09:24 +0200 (CEST) From: Dodji Seketeli <dodji@redhat.com> To: libabigail@sourceware.org Cc: ckalina@redhat.com Subject: [PATCH, applied] btf-reader: Ignore BTF nodes that ought to be ignored Organization: Red Hat / France X-Operating-System: AlmaLinux 9.3 X-URL: http://www.redhat.com Date: Fri, 10 May 2024 14:09:24 +0200 Message-ID: <87r0e9c1hn.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_WEB, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>, <mailto:libabigail-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libabigail/> List-Post: <mailto:libabigail@sourceware.org> List-Help: <mailto:libabigail-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>, <mailto:libabigail-request@sourceware.org?subject=subscribe> Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org |
Series |
[applied] btf-reader: Ignore BTF nodes that ought to be ignored
|
|
Commit Message
Dodji Seketeli
May 10, 2024, 12:09 p.m. UTC
Hello,
For now, the BTF nodes BTF_KIND_DECL_TAG, BTF_KIND_DATASEC, and
BTF_KIND_UNKN are ignored by libabigail, in practice. We should thus
not abort when we encounter them. Fixed thus. Many thanks to Cestmir
Kalina for reporting this.
* src/abg-btf-reader.cc (build_ir_node_from_btf_type): Ignore and
return nil for node of kind BTF_KIND_DECL_TAG, BTF_KIND_DATASEC,
and BTF_KIND_UNKN. For all other nodes, abort.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
src/abg-btf-reader.cc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/abg-btf-reader.cc b/src/abg-btf-reader.cc index f22e92bf..67206bb4 100644 --- a/src/abg-btf-reader.cc +++ b/src/abg-btf-reader.cc @@ -486,12 +486,16 @@ public: #ifdef WITH_BTF_KIND_TYPE_TAG case BTF_KIND_TYPE_TAG/* Type Tag */: + break; #endif #ifdef WITH_BTF_KIND_DECL_TAG case BTF_KIND_DECL_TAG/* Decl Tag */: + break; #endif case BTF_KIND_DATASEC/* Section */: + break; case BTF_KIND_UNKN/* Unknown */: + break; default: ABG_ASSERT_NOT_REACHED; break;