| Message ID | 87pkyl2moq.fsf@seketeli.org |
|---|---|
| State | New |
| Headers |
Return-Path: <libabigail-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EC1184BA901D for <patchwork@sourceware.org>; Thu, 10 Sep 2026 14:42:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC1184BA901D X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by sourceware.org (Postfix) with ESMTPS id 5315F4BA900A for <libabigail@sourceware.org>; Thu, 10 Sep 2026 14:41:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5315F4BA900A Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5315F4BA900A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789051319; cv=none; b=GaXDZVKh2aZ/q1QWSiD4pZy20muHucHChVG7l07J1havxtXmkCqO40q1qp8niK+sfSNHOlHG6oWHEkJsgov2T3SeqA5tzdXNtPW0sijAOnhPHFTX9DkxJGtHeM8gixf+a9bK3bM8utZSHOXEpw2/CCK4t9aCc49nv5LaTchPD0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789051319; c=relaxed/simple; bh=howL9YN+MvF1FzbodW56ZXJLgOcgc+SrVOAWUYseFs8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=BErceWiU4GT7xKVrms8fAxWo3PRbsfjOu6kxz5iJNHoT6cXWgjSGT6FJQhhW4XgUrNmfAr5qQOaNErk9ok5/JLtm03jBuYfQBZpIZQkbTj73ZrdaOoYnFciHN+fMxVIG/1CZ49yjgJ3K5piD2VZKFEwglH1rkltcwVHP3cP5AtY= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5315F4BA900A Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-49b965570d7so79209375e9.0 for <libabigail@sourceware.org>; Thu, 10 Sep 2026 07:41:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789051304; x=1789656104; h=content-type:mime-version:user-agent:message-id:date:organization :subject:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XX3rnRItwLvrSS0ShduUsx6QoEys3uCQotjk0QAs3TU=; b=mJmX+bNdKQsjs/dFSaGKaVLvFSo6BfBXslRXunXbuQXuadsIEdkiK4+szurlpjtgbH KPq8TsYDHrUYzs9zu6BhVAPbXcYGujyCR/qNwruky+fsXzJVqUEYApTkVhIbU3nf1BTt xzLYh8uQACsi/IuMN24CiS3fa3Dntc7htt6SO17FjODPLmZzvZ1OLQdeLqDdq/K54DFr 2tPTSBJxGZ0PwL/JkNzuvPzEQ9c1NmM2QppOEssaiD4QkAMEA63AchwvAQ9yJ/nvG1F2 H7m5PqyGY1d+rF8xNKEBaxU/52FhLFea1zuZcNYBTpfVf4FTbGvufqJDjawwHoWQq0Rk zUCA== X-Gm-Message-State: AFuF++lA756QrMBZpX2Myiva116JSjTTtd2DlPSRbvoGZzfV0qM9CG7S nvVB5VoAzG5OFNIGSqzvDo0GRld5IOJq46jUTSB2wWyxQ1d/JvDSIWmREPBazU8P X-Gm-Gg: AYBFou0pOURTbOj7dWZW1A2Q8a71AW9kPiy03DNc7uzVdLxcwbKSZHW/u3lySjqOYid tBRE0MlgU4fykBGZwaaoXovejgNRZCOHz9XqOnLDKhc7c3QzmRbWafpBSU1wRrOtJ0e5tksHK0s SPa5OLEmYH1Uh+fgdvomZtCTbzv7cPORc2uOlDKefgpaEss/i79Xz2lBKpvMHZnmLXD7KXFr3cm UPE3IEaPdyR/uxyun9Mbgw9LbZ5O6CZZxVUdiiUUHdvgM5Gl7xujrgh4MW8IcwaOu136AJXHdfM +P5hecR1NovgN1UH8YEPNPwU8W2lns30gLHz2scQJxFLdDCBcNGKExhm+9ThwF8J2wqvM8K4lJE sniLRtLuJaJ8B/m5Cixiz/xlS3LR5R8AlxNDyzCzi0kyiW7p9N6gBwrkJ5utsfZFSsJ7mdiGRAm kKq8jfMYjRf+s4HUQrRnZIWOy7G58qVqIXo7t7h0fTgk+Wz7YQ+4LzhfqMI9fDJYJ7OtMhf6RZB P+W9wZbYfYVBXymCqY2/CijiS3TXTcZ333M0u/G+dMz59hLXR7h3RQ3jWYjpKW15DJEnNqMvVsU aCAzRSMx X-Received: by 2002:a05:600c:1da8:b0:49c:cf18:494e with SMTP id 5b1f17b1804b1-49cf825a530mr507232205e9.12.1789051304304; Thu, 10 Sep 2026 07:41:44 -0700 (PDT) Received: from localhost (82-67-74-110.subs.proxad.net. [82.67.74.110]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d26be3e0asm80996665e9.1.2026.09.10.07.41.41 for <libabigail@sourceware.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 07:41:42 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 34B32603844A; Thu, 10 Sep 2026 16:41:41 +0200 (CEST) From: Dodji Seketeli <dodji@seketeli.org> To: libabigail@sourceware.org Subject: [PATCH 1/2, applied] ir: Remove over zealous assert from elf_symbol::update_main_symbol Organization: Me, myself and I X-Operating-System: Fedora 46 X-URL: http://www.seketeli.net/~dodji Date: Thu, 10 Sep 2026 16:41:41 +0200 Message-ID: <87pkyl2moq.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, LOCAL_AUTHENTICATION_FAIL_DMARC, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>, <mailto:libabigail-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libabigail/> List-Post: <mailto:libabigail@sourceware.org> List-Help: <mailto:libabigail-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>, <mailto:libabigail-request@sourceware.org?subject=subscribe> Errors-To: libabigail-bounces~patchwork=sourceware.org@sourceware.org |
| Series |
[1/2,applied] ir: Remove over zealous assert from elf_symbol::update_main_symbol
|
|
Commit Message
Dodji Seketeli
Sept. 10, 2026, 2:41 p.m. UTC
Hello,
While testing the build on Debian systems, I noticed that the assert
in elf_symbol::update_main_symbol was probably too eager. The symbol
that this method is invoked on might not necessarily be the main
symbol, and yet, the function should succeed.
I am thus removing the assert for now.
* src/abg-ir.cc (elf_symbol::update_main_symbol): Remove the
assert.
Signed-off-by: Dodji Seketeli <dodji@seketeli.org>
---
src/abg-ir.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/abg-ir.cc b/src/abg-ir.cc index b3bc2ab1..8f43db58 100644 --- a/src/abg-ir.cc +++ b/src/abg-ir.cc @@ -3099,7 +3099,6 @@ elf_symbol::add_alias(const elf_symbol_sptr& alias) elf_symbol_sptr elf_symbol::update_main_symbol(const std::string& name) { - ABG_ASSERT(is_main_symbol()); if (!has_aliases() || get_name() == name) return get_main_symbol();