From patchwork Wed Jun 1 16:12:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 54684 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3011D382FC28 for ; Wed, 1 Jun 2022 16:12:22 +0000 (GMT) X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by sourceware.org (Postfix) with ESMTPS id 1006E3856274 for ; Wed, 1 Jun 2022 16:12:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1006E3856274 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 96CCA240002; Wed, 1 Jun 2022 16:12:15 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id C4B5D5800FB; Wed, 1 Jun 2022 18:12:14 +0200 (CEST) From: Dodji Seketeli To: gprocida@google.com Subject: [PATCH] comparison: Fix leaf report summary Organization: Me, myself and I X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Wed, 01 Jun 2022 18:12:14 +0200 Message-ID: <87o7zcs6qp.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , Cc: libabigail@sourceware.org Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello Giuliano, This patch is to address the problem reported at https://sourceware.org/bugzilla/show_bug.cgi?id=29047 where the leaf changes summary omits the number of (added/removed) ELF symbols that have no debug info. Fixed thus. I'd be glad if you could tell me if this addresses the issue you are seeing. Thanks! * src/abg-comparison.cc (corpus_diff::priv::emit_diff_stats): In the "leaf change summary" section, add the number of removed/added symbols not described by debug info. Signed-off-by: Dodji Seketeli --- src/abg-comparison.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/abg-comparison.cc b/src/abg-comparison.cc index 525605cb..2ce3f5d4 100644 --- a/src/abg-comparison.cc +++ b/src/abg-comparison.cc @@ -9858,7 +9858,11 @@ corpus_diff::priv::emit_diff_stats(const diff_stats& s, s.net_num_vars_removed() + s.net_num_vars_added() + s.net_num_leaf_var_changes() + - s.net_num_leaf_type_changes(); + s.net_num_leaf_type_changes() + + s.net_num_removed_func_syms() + + s.net_num_added_func_syms() + + s.net_num_removed_var_syms() + + s.net_num_added_var_syms(); if (!sonames_equal_) out << indent << "ELF SONAME changed\n";