comparison: Fix leaf report summary

Message ID 87o7zcs6qp.fsf@seketeli.org
State New
Headers
Series comparison: Fix leaf report summary |

Commit Message

Dodji Seketeli June 1, 2022, 4:12 p.m. UTC
  Hello Giuliano,

This patch is to address the problem reported at
https://sourceware.org/bugzilla/show_bug.cgi?id=29047 where the leaf
changes summary omits the number of (added/removed) ELF symbols that
have no debug info.

Fixed thus.

I'd be glad if you could tell me if this addresses the issue you are
seeing.

Thanks!

	* src/abg-comparison.cc (corpus_diff::priv::emit_diff_stats): In
	the "leaf change summary" section, add the number of removed/added
	symbols not described by debug info.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
 src/abg-comparison.cc | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
  

Patch

diff --git a/src/abg-comparison.cc b/src/abg-comparison.cc
index 525605cb..2ce3f5d4 100644
--- a/src/abg-comparison.cc
+++ b/src/abg-comparison.cc
@@ -9858,7 +9858,11 @@  corpus_diff::priv::emit_diff_stats(const diff_stats&	s,
     s.net_num_vars_removed() +
     s.net_num_vars_added() +
     s.net_num_leaf_var_changes() +
-    s.net_num_leaf_type_changes();
+    s.net_num_leaf_type_changes() +
+    s.net_num_removed_func_syms() +
+    s.net_num_added_func_syms() +
+    s.net_num_removed_var_syms() +
+    s.net_num_added_var_syms();
 
   if (!sonames_equal_)
     out << indent << "ELF SONAME changed\n";