[applied] reader: Canonicalizing a type once is enough

Message ID 87mtry2i1c.fsf@redhat.com
State New
Series [applied] reader: Canonicalizing a type once is enough |

Commit Message

Dodji Seketeli June 10, 2021, 9:19 a.m. UTC

While looking at something else, I noticed that the abixml reader was
trying to canonicalize each type twice.  Once should be enough.

	* src/abg-reader.cc (build_type): Don't try to canonicalize the
	type here because all the sub-routines of this function (which
	actually build the type) already try to canonicalize it.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.
 src/abg-reader.cc | 1 -
 1 file changed, 1 deletion(-)


diff --git a/src/abg-reader.cc b/src/abg-reader.cc
index 6d25b690..c0385298 100644
--- a/src/abg-reader.cc
+++ b/src/abg-reader.cc
@@ -5698,7 +5698,6 @@  build_type(read_context&	ctxt,
-  ctxt.maybe_canonicalize_type(t);
   return t;