[applied] default.abignore: Improve default suppression for krb5 libraries

Message ID 87fripzabd.fsf@redhat.com
State New
Headers
Series [applied] default.abignore: Improve default suppression for krb5 libraries |

Commit Message

Dodji Seketeli April 3, 2025, 12:41 p.m. UTC
  Hello,

It's been reported that we need to suppress ABI changes that touch
functions starting with krb5int_ and k5_, including deletion of these
functions.

This patch improves the default suppression specifications for the
krb5-libs package to include the above.

	* default.abignore: Recognize more SONAMEs for the different krb5
	shared libraries, namely libk5crypto.so, libgssrpc.so, libkdb5.so,
	libkrb5support.so and libgssapi_krb5.so. Suppress all function
	changes to libraries with these sonames.  Suppress functions (and
	their symbols) starting with names k5_, in addition to krb5int_.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to the mainline.
---
 default.abignore | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
  

Patch

diff --git a/default.abignore b/default.abignore
index a963d5b3..9ccfd64f 100644
--- a/default.abignore
+++ b/default.abignore
@@ -174,9 +174,14 @@ 
 #########################################
 [suppress_function]
   # Suppress ABI change reports about functions starting with the name
-  # krb5int_* in libraries named libkrb5<something>.so
-  soname_regexp = libkrb5.*\\.so.*
-  name_regexp = ^krb5int_.*
+  # krb5int_*, or k5_ in various libraries of the krb5-libs package
+  # because they are private functions.  Note that deleted functions
+  # are also suppressed.
+  soname_regexp = lib(krb5|k5crypto|gssrpc|kdb5|krb5support|gssapi_krb5).*\\.so.*
+  change_kind = all
+  name_regexp = (^krb5int|^k5)_.*
+  symbol_name_regexp = (^krb5int|^k5)_.*
+
 ##########################################
 # End of krb5 suppression specifications
 #########################################