[2/3] ir: remove unused enum_has_non_name_change

Message ID 87fr10nxbu.fsf@seketeli.org
State New
Headers
Series [1/3] configure: Consider prefixed headers dir when checking decls |

Commit Message

Dodji Seketeli July 30, 2026, 6:31 p.m. UTC
  Hello,

It feels good to remove unused code.

	* include/abg-ir.h (class enum_type_decl): Remove friend
	declaration of enum_has_non_name_change.
	(enum_has_non_name_change): Remove declaration.
	* src/abg-ir.cc (enum_has_non_name_change): Remove definition.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>

Applied to the master branch.
---
 include/abg-ir.h | 10 ------
 src/abg-ir.cc    | 79 ------------------------------------------------
 2 files changed, 89 deletions(-)
  

Patch

diff --git a/include/abg-ir.h b/include/abg-ir.h
index 84dd2939..c5840d04 100644
--- a/include/abg-ir.h
+++ b/include/abg-ir.h
@@ -2858,11 +2858,6 @@  public:
   traverse(ir_node_visitor& v);
 
   virtual ~enum_type_decl();
-
-  friend bool
-  enum_has_non_name_change(const enum_type_decl& l,
-			   const enum_type_decl& r,
-			   change_kind* k);
 }; // end class enum_type_decl
 
 bool
@@ -2871,11 +2866,6 @@  operator==(const enum_type_decl_sptr& l, const enum_type_decl_sptr& r);
 bool
 operator!=(const enum_type_decl_sptr& l, const enum_type_decl_sptr& r);
 
-bool
-enum_has_non_name_change(const enum_type_decl& l,
-			 const enum_type_decl& r,
-			 change_kind* k);
-
 /// The abstraction of an enumerator
 class enum_type_decl::enumerator
 {
diff --git a/src/abg-ir.cc b/src/abg-ir.cc
index 2e9d2084..d9230404 100644
--- a/src/abg-ir.cc
+++ b/src/abg-ir.cc
@@ -20470,85 +20470,6 @@  enum_type_decl::traverse(ir_node_visitor &v)
 enum_type_decl::~enum_type_decl()
 {}
 
-/// Test if two enums differ, but not by a name change.
-///
-/// @param l the first enum to consider.
-///
-/// @param r the second enum to consider.
-///
-/// @return true iff @p l differs from @p r by anything but a name
-/// change.
-bool
-enum_has_non_name_change(const enum_type_decl& l,
-			 const enum_type_decl& r,
-			 change_kind* k)
-{
-  bool result = false;
-  if (*l.get_underlying_type() != *r.get_underlying_type())
-    {
-      result = true;
-      if (k)
-	*k |= SUBTYPE_CHANGE_KIND;
-      else
-	return true;
-    }
-
-  enum_type_decl::enumerators::const_iterator i, j;
-  for (i = l.get_enumerators().begin(), j = r.get_enumerators().begin();
-       i != l.get_enumerators().end() && j != r.get_enumerators().end();
-       ++i, ++j)
-    if (*i != *j)
-      {
-	result = true;
-	if (k)
-	  {
-	    *k |= LOCAL_TYPE_CHANGE_KIND;
-	    break;
-	  }
-	else
-	  return true;
-      }
-
-  if (i != l.get_enumerators().end() || j != r.get_enumerators().end())
-    {
-      result = true;
-      if (k)
-	*k |= LOCAL_TYPE_CHANGE_KIND;
-      else
-	return true;
-    }
-
-  enum_type_decl &local_r = const_cast<enum_type_decl&>(r);
-  interned_string qn_r = l.get_environment().intern(r.get_qualified_name());
-  interned_string qn_l = l.get_environment().intern(l.get_qualified_name());
-  string n_l = l.get_name();
-  string n_r = r.get_name();
-  local_r.set_qualified_name(qn_l);
-  local_r.set_name(n_l);
-
-  if (!(l.decl_base::operator==(r) && l.type_base::operator==(r)))
-    {
-      result = true;
-      if (k)
-	{
-	  if (!l.decl_base::operator==(r))
-	    *k |= LOCAL_NON_TYPE_CHANGE_KIND;
-	  if (!l.type_base::operator==(r))
-	    *k |= LOCAL_TYPE_CHANGE_KIND;
-	}
-      else
-	{
-	  local_r.set_name(n_r);
-	  local_r.set_qualified_name(qn_r);
-	  return true;
-	}
-    }
-  local_r.set_qualified_name(qn_r);
-  local_r.set_name(n_r);
-
-  return result;
-}
-
 /// Test if a given enumerator is found present in an enum.
 ///
 /// This is a subroutine of the equals function for enums.