From patchwork Fri Nov 12 17:40:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 47551 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4A7B23857C4C for ; Fri, 12 Nov 2021 17:45:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A7B23857C4C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1636739155; bh=4kw29Sak/jGh/0VhKQSvFECcliJ3zZfjr1dG+UqVppQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=n9B5kxoJmTY3i6bYvzQc6i6w+qix7oPhUD7+E9ITClo4susMyH1tcH2HzEqe9FmWO ePSVsp47ee0R11L4EFHZA5ObEskCv06LtXaUA7pqlsAZPqntncbzKP4nNFlLEJ151J fo8NLPP4QLWJh9ZeLlHKnjGHKT8LS+HJD9Yw6ZdM= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 60F8F3857C51 for ; Fri, 12 Nov 2021 17:41:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 60F8F3857C51 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-XXntiobSP6G_5bbUcdUhWg-1; Fri, 12 Nov 2021 12:40:59 -0500 X-MC-Unique: XXntiobSP6G_5bbUcdUhWg-1 Received: by mail-qv1-f70.google.com with SMTP id ib13-20020a0562141c8d00b003958b43bcf2so9083864qvb.1 for ; Fri, 12 Nov 2021 09:40:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:organization:date:message-id :user-agent:mime-version; bh=4kw29Sak/jGh/0VhKQSvFECcliJ3zZfjr1dG+UqVppQ=; b=ulbmz/pOa1wjjCzIX+BXO8lmKZln1VGcOdBnqj+FSWpmO+8EmLuMrBX+nclrEMKzyH iCfOOUyNHGYxWIIDYWzKm2XtIYOCJ62EG0Fl3Aost5R/rCWr1mEdFlWAo7GZX94LiyzF E38vqQYzX2wVvmnimEfKSZMN7obziNFZYgRaqpZ4HM+9Cs6X/KOb6V/UNVPZZxfseOhw QzMQUcw8H6dM6mwDjCDgN7tMEQr2zsPqJj9abIjKZNQHWBgdDR7EL0F23FnGNXNFajhu G9CptmhkPHCs5emXcvJvgm7L8SAaDCfTrxIy3DkoKaYBp2YCvKmRb03BaEaYoxx40eae gkXA== X-Gm-Message-State: AOAM530Qwk76OkHzLELFrf2eMv3zHkLusHDWFE9iX5WSAUz+B1Y1h9eI wkWrpkpO6GKoKF79Alwj9yLxPE2lEGFo/g07rq4E+pIHZT0/ghlM3eZ98q0pvsTPchxaXSEgX4B NWyUtWx9zlVVsjAJp5bmlYVEBzWFAJAKaABbSPQYC4SNowOS6Cv7C0Guk9/JxP3TWMRcX X-Received: by 2002:a05:622a:1649:: with SMTP id y9mr18103690qtj.268.1636738859221; Fri, 12 Nov 2021 09:40:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJynK6NoTJaDRLOfcnfCxYwjm+YERs7QlA1b+mW0cwTKMXD6PucL1j43aDATgQVAux+CJzSj2g== X-Received: by 2002:a05:622a:1649:: with SMTP id y9mr18103658qtj.268.1636738858902; Fri, 12 Nov 2021 09:40:58 -0800 (PST) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id n3sm3180746qkp.112.2021.11.12.09.40.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 09:40:58 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id 5F8A2581C23; Fri, 12 Nov 2021 18:40:56 +0100 (CET) To: libabigail@sourceware.org Subject: [PATCH, applied] abg-config.{cc,h}: Misc comment cleanups Organization: Red Hat / France X-Operating-System: Fedora 36 X-URL: http://www.redhat.com Date: Fri, 12 Nov 2021 18:40:56 +0100 Message-ID: <877ddd6zmf.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, A little bit of cleanup was due here. * include/abg-config.h (abigail_get_library_version): Remove the comment from the header file ... * src/abg-config.cc (abigail_get_library_version): ... to put it in the definition. Signed-off-by: Dodji Seketeli Applied to master. --- include/abg-config.h | 9 --------- src/abg-config.cc | 9 +++++++++ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/abg-config.h b/include/abg-config.h index 4d94c71c..9f86d48a 100644 --- a/include/abg-config.h +++ b/include/abg-config.h @@ -58,15 +58,6 @@ public: extern "C" { - /// Return the relevant version numbers of the library. - /// - /// \param maj the major version number of the library. - /// - /// \param min the minor version number of the library. - /// - /// \param rev the revision version number of the library. - /// - /// \param suf the version suffix of the library. void abigail_get_library_version(std::string& maj, std::string& min, diff --git a/src/abg-config.cc b/src/abg-config.cc index d2e15737..7fe2e64a 100644 --- a/src/abg-config.cc +++ b/src/abg-config.cc @@ -68,6 +68,15 @@ config::set_tu_instr_archive_suffix(const std::string& s) extern "C" { +/// Return the relevant version numbers of the library. +/// +/// @param maj the major version number of the library. +/// +/// @param min the minor version number of the library. +/// +/// @param rev the revision version number of the library. +/// +/// @param suf the version suffix of the library. void abigail_get_library_version(std::string& major, std::string& minor,