[2/2] Tag add/remove/change lines unconditionally with [A], [D], [C].

  Hey Giuliano,

Thank you for looking into this.  I have some comments down below.

Giuliano Procida <gprocida@google.com> a ?crit:

> These tags were previously only emitted by the default reporter if the
> there were more than 100 (hard-coded constant) items in a a list. The
> leaf reporter emitted them unconditionally. This change simplifies the
> code, makes output more consistent and makes it easier to interpret
> diffs of diff output.
>
> 	* src/abg-default-reporter.cc (report): Remove calculations of
>         number of changes (total) and arbitrary threshold (large_num)
>         and emit prefixes ([A], [D], [C]) unconditionally.
>         * tests/data/test-*/*report*.txt: Add prefixes to reports.

When I run the testsuite with this patch, I get a regression in
runtestdiffpkg.  Maybe the part of this patch that emits the [A],[D]
prefixes for added/removed ELF symbols not referenced by debug info and
for binaries (by abipkgdiff) is missing?

Here is the error I am getting when running the runtestdiffpkg test:

$ ./build/tests/runtestdiffpkg 
$ 

[...]

Cheers,

Message ID	86ftelwmc7.fsf@seketeli.org
State	Committed
Headers	From: dodji@seketeli.org (Dodji Seketeli) Date: Wed, 01 Jan 2020 00:00:00 -0000 Subject: [PATCH 2/2] Tag add/remove/change lines unconditionally with [A], [D], [C]. In-Reply-To: <20200305160317.101386-2-gprocida@google.com> (Giuliano Procida's message of "Thu, 5 Mar 2020 16:03:17 +0000") References: <20200305160317.101386-1-gprocida@google.com> <20200305160317.101386-2-gprocida@google.com> Message-ID: <86ftelwmc7.fsf@seketeli.org>
Series	None \| [2/2] Tag add/remove/change lines unconditionally with [A], [D], [C].

[2/2] Tag add/remove/change lines unconditionally with [A], [D], [C].

Commit Message

Patch