[2/2] Tag add/remove/change lines unconditionally with [A], [D], [C].
Commit Message
Hey Giuliano,
Thank you for looking into this. I have some comments down below.
Giuliano Procida <gprocida@google.com> a ?crit:
> These tags were previously only emitted by the default reporter if the
> there were more than 100 (hard-coded constant) items in a a list. The
> leaf reporter emitted them unconditionally. This change simplifies the
> code, makes output more consistent and makes it easier to interpret
> diffs of diff output.
>
> * src/abg-default-reporter.cc (report): Remove calculations of
> number of changes (total) and arbitrary threshold (large_num)
> and emit prefixes ([A], [D], [C]) unconditionally.
> * tests/data/test-*/*report*.txt: Add prefixes to reports.
When I run the testsuite with this patch, I get a regression in
runtestdiffpkg. Maybe the part of this patch that emits the [A],[D]
prefixes for added/removed ELF symbols not referenced by debug info and
for binaries (by abipkgdiff) is missing?
Here is the error I am getting when running the runtestdiffpkg test:
$ ./build/tests/runtestdiffpkg
$
[...]
Cheers,
@@ -23,6 +23,6 @@
================ end of changes of 'dbus-binding-tool'===============
Removed binaries:
- [D] /usr/lib64/libdbus-glib-1.so.2.3.2, SONAME: libdbus-glib-1.so.2
+ /usr/lib64/libdbus-glib-1.so.2.3.2, SONAME: libdbus-glib-1.so.2
Added binaries:
- [A] /usr/lib/libdbus-glib-1.so.2.3.2, SONAME: libdbus-glib-1.so.2
+ /usr/lib/libdbus-glib-1.so.2.3.2, SONAME: libdbus-glib-1.so.2
@@ -24,9 +24,9 @@
3 removed types unreachable from any public interface:
- [A] struct _GUnixFDList at gunixfdlist.h:58:1
- [A] typedef GUnixFDList at giotypes.h:549:1
- [A] typedef GUnixFDListPrivate at gunixfdlist.h:41:1
+ struct _GUnixFDList at gunixfdlist.h:58:1
+ typedef GUnixFDList at giotypes.h:549:1
+ typedef GUnixFDListPrivate at gunixfdlist.h:41:1
1 changed type unreachable from any public interface: