From patchwork Fri Sep 25 21:05:59 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 144686 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7ADA24B920F2 for ; Fri, 25 Sep 2026 21:06:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7ADA24B920F2 X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by sourceware.org (Postfix) with ESMTPS id 4EE454BB8F55 for ; Fri, 25 Sep 2026 21:06:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4EE454BB8F55 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4EE454BB8F55 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=217.70.183.194 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790370375; cv=none; b=k9n08Jz26SVF2LGfGML9wJ5WA7xAeIkm0CF1/skblpsYBT6C47RWlYaic+iS3jvpfBIMCuwzfP56jSbCFueOurBNx8yeCPgRT1QAzsePSmIzi3Ihyw+zC2iU3mrtuBIrfFe+xGMn5COVwlOCXdh3NfQyW4jKALumXPgcgT38D+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790370375; c=relaxed/simple; bh=ADJIOufC+tX3D+Bjqau6+1VkfAhn3y+MsBFfdZzsPLA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=QijyMMdkL7qoJ+QlTTfwbc62fsATe3fcUacfqRF/IUgwvqpYUovfS8yCX0GTEPUhQoxLanxnHU4A5wAmRYvCENFlVk5hvcIq8xk62qNGFzAUUjq3m1YcQTxGl9cP1Fopqrs75ZUjgJAkNXTW9g7YzU+ZcxsLYRe7bKs1sSzxd+k= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4EE454BB8F55 Received: by mail.gandi.net (Postfix) with ESMTPSA id 52BFD41BB3 for ; Fri, 25 Sep 2026 21:06:09 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 77F51603B6AB; Fri, 25 Sep 2026 23:06:08 +0200 (CEST) From: Dodji Seketeli To: libabigail@sourceware.org Subject: [PATCH 05/14] abidw: Add better logging when invoked with --noout Date: Fri, 25 Sep 2026 23:05:59 +0200 Message-ID: <20260925210608.3532891-6-dodji@seketeli.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260925210608.3532891-1-dodji@seketeli.org> References: <20260925210608.3532891-1-dodji@seketeli.org> MIME-Version: 1.0 X-GND-Sasl: dodj@seketeli.net X-GND-Score: 0 X-GND-Cause: dmFkZTFgIq5KdZPmHd/pfmMFWFmU34l9ku2tXAjdvEnHjcL09nbS10arlB9iwFyiuqTaonnN2NuRrgPIm0+Pjg/+Cu441fODnsxt6GqpIDTIo8r9tv8fhRtqAB7z07+GTkq5KEM7vUfwZiQULaItvjpJmtyP4oqbuBPtAWmHIKT9U5EzmJ/NBuCO1vlUPvOKLSrtVQYRMl60lejHHka1qLu2RyrQHszVFzusTVBFzVwDfzWhfzeipR8s2kkcaRBjqdtCJn0rGx+A2Y9Q9Nr+yd+s4wveW5GMNEfPK81lLZN1PDGSP5s9qRdoDp7/CirU1z93LG/MrSIFv9G7zpYaLOaCjX7JAmminKRNgIhaMi6YJCiSWcvjQkiOyhoTSmfpK+WyaFQ8nKCX1w5HS3hNGmkd9W5/Iz6xYDI0z34u3Ib0oorANyV/a5jPpkmZaXQMG914FvuaMJIEKfx2UBqrECJ6nRVp8d/T2I/L6wNoUWh6qtu/YDS4LE7mPORhxsiddwTaL0iPD0LrAq+9gsWXt+C5w1opflqnS4rnneKVbFVLxAD51FwngWC2q5ZSyfv0Oy+2sZRwojm7ihi/+tU+9zEjbjwPP2eu1tZRdaHEysydVdonaPmxD+FrryfhyCPJhfyMv5VtpVckC+97SVBBeKEuBWP5uP+opjo5dGEsPoLfZPZTVA X-GND-State: clean X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, LOCAL_AUTHENTICATION_FAIL_DMARC, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libabigail-bounces~patchwork=sourceware.org@sourceware.org When abidw is invoked with --noout, the time spent in abigail::corpus::get_types_not_reachable_from_public_interfaces is not logged. Fixed thus. * tools/abidw.cc (load_corpus_and_write_abixml): When --noout is used, log the time spent in the final call to abigail::corpus::get_types_not_reachable_from_public_interfaces. Signed-off-by: Dodji Seketeli --- tools/abidw.cc | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/tools/abidw.cc b/tools/abidw.cc index d44f1176..fcab5fc5 100644 --- a/tools/abidw.cc +++ b/tools/abidw.cc @@ -749,7 +749,25 @@ load_corpus_and_write_abixml(char* argv[], if (opts.noout) { if (corp) - corp->get_types_not_reachable_from_public_interfaces(); + { + if (opts.do_log) + { + emit_prefix(argv[0], cerr) + << "computing types not reachable from public interfaces ...\n"; + t.start(); + } + + corp->get_types_not_reachable_from_public_interfaces(); + + if (opts.do_log) + { + t.stop(); + emit_prefix(argv[0], cerr) + << "computed types not reachable from public interfaces in: " + << t + << "\n"; + } + } return 0; }