diff mbox series

doc: Update CONTRIBUTING to reference C++14

Message ID 20260224132634.3469617-1-christopher.burr@cern.ch
State New
Headers
Series doc: Update CONTRIBUTING to reference C++14 |

Commit Message

Chris Burr Feb. 24, 2026, 1:26 p.m. UTC 
  The C++ standard was upgraded from C++11 to C++14 in commit
aab9cc69 (libabigail 2.8), but the CONTRIBUTING file still
referenced C++11 and GCC 4.8.

	* CONTRIBUTING: Update C++ standard references from
	C++11 to C++14, and minimum compiler from GCC 4.8.x to
	GCC 5.x.

Signed-off-by: Chris Burr <christopher.burr@cern.ch>
---
 CONTRIBUTING | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Dodji Seketeli Feb. 27, 2026, 1:07 p.m. UTC | #1 
Hello Chris,

Many thanks for looking at the libabigail project.

Chris Burr <christopher.burr@cern.ch> a écrit:

> The C++ standard was upgraded from C++11 to C++14 in commit
> aab9cc69 (libabigail 2.8), but the CONTRIBUTING file still
> referenced C++11 and GCC 4.8.
>
> 	* CONTRIBUTING: Update C++ standard references from
> 	C++11 to C++14, and minimum compiler from GCC 4.8.x to
> 	GCC 5.x.
>
> Signed-off-by: Chris Burr <christopher.burr@cern.ch>

This patch of course looks great to me.

I have applied it to the master branch of the project at
https://sourceware.org/cgit/libabigail/commit/?id=50928525eba32d2f2b9119ae94a5b4e645af9db5.

[...]

Thanks again.
diff mbox series

Patch

diff --git a/CONTRIBUTING b/CONTRIBUTING
index 9f653f94..eb3f236f 100644
--- a/CONTRIBUTING
+++ b/CONTRIBUTING
@@ -248,8 +248,8 @@  please, stick to and mimic what is already in there for the sake of
 consistency at very least.  Just for history, it's derived from the
 style of the C++ standard library from the GNU project.
 
-As of libabigail 2.0, the language we use is C++ 11.  The level
-supported is the one supported by the GCC 4.8.x series of compilers.
+As of libabigail 2.8, the language we use is C++ 14.  The level
+supported is the one supported by the GCC 5.x series of compilers.
 This should be old and well tested enough to be supported by your
 current favorite compiler.
 
@@ -258,13 +258,13 @@  TR1 extensions.  That heritage is well visible in the code base as it
 is today.
 
 Please do not rush and send gazillions of patches that just re-write
-tons of code into your favorite C++ 11 flavour du jour.  We will
+tons of code into your favorite C++ 14 flavour du jour.  We will
 likely reject those patches.  We want to keep the history of the code
 base in such a way that tools like "git blame <sourcefile> are still
 useful.
 
 So we'll accept patches changing parts of the code base to more recent
-C++ 11 constructs only if you happen to add functionality or fix
+C++ 14 constructs only if you happen to add functionality or fix
 things in that area.  If it makes "cultural common" sense to adopt
 those constructs.  What I mean by "cultural" is that must make sense
 in relative to the culture of the project.  And yes, that is