From patchwork Wed Aug 14 12:56:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 95822 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0B7CE3858C52 for ; Wed, 14 Aug 2024 12:57:37 +0000 (GMT) X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by sourceware.org (Postfix) with ESMTPS id CAE883858420 for ; Wed, 14 Aug 2024 12:56:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CAE883858420 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CAE883858420 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4b98:dc4:8::224 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723640216; cv=none; b=qNI/fyUsDlYV7K1O4VRGN7Z8FBIaJvXTrYaZwMqR7XRD4+SOJeUDezj5PM4yZFwTJ/yKCqgfMY6Ou0obfQcN2TMb2CStEVpTrBwLtKJKhywrObMZYhFCJwduSJT1NRAxPglsWiPqyyE3JBDn7rtOo/5p0WEcohMltwJOrF52X6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723640216; c=relaxed/simple; bh=m3TCUhNvFYB8JejP99GCMizCYOdUOu/ydmQWsjHvTuk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=bcbUUR+Iq0twHyGw/jyA/yza8pNsea/HnU9vSqoFKe1eO7y/P+4oUAdVmFrXCmlPin8DWBYC5QRXRxZ8FlONDoeczbvUi2J4TQj1/HIu9t7UKlHPaXYhbhBa0PF07AsO4Tf5EhCY8HLvyknF6+FmVgmhlEsUPWPBsu484Vye93g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail.gandi.net (Postfix) with ESMTPSA id E3089E0004; Wed, 14 Aug 2024 12:56:50 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 3A5B7507A635; Wed, 14 Aug 2024 14:56:49 +0200 (CEST) From: dodji@redhat.com To: libabigail@sourceware.org Cc: dodji@redhat.com Subject: [PATCH 11/11] abidw: Make generic options like --verbose work with the ABIXML front-end Date: Wed, 14 Aug 2024 14:56:49 +0200 Message-ID: <20240814125649.47119-11-dodji@redhat.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20240814125649.47119-1-dodji@redhat.com> References: <20240814125649.47119-1-dodji@redhat.com> MIME-Version: 1.0 X-GND-Sasl: dodj@seketeli.org X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libabigail-bounces~patchwork=sourceware.org@sourceware.org From: Dodji Seketeli * tools/abidw.cc (set_generic_options): Take a fe_iface in parameter, not an elf_based_reader. (perform_self_comparison): Call set_generic_options. Signed-off-by: Dodji Seketeli --- tools/abidw.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/abidw.cc b/tools/abidw.cc index 6bb1ef55..b7642747 100644 --- a/tools/abidw.cc +++ b/tools/abidw.cc @@ -612,7 +612,7 @@ set_suppressions(abigail::elf_based_reader& rdr, options& opts) /// /// @param opts the command line options. static void -set_generic_options(abigail::elf_based_reader& rdr, options& opts) +set_generic_options(abigail::fe_iface& rdr, options& opts) { rdr.options().drop_undefined_syms = opts.drop_undefined_syms; rdr.options().show_stats = opts.show_stats; @@ -675,6 +675,7 @@ perform_self_comparison(const write_context_sptr& write_ctxt, } #endif fe_iface_sptr rdr = abixml::create_reader(tmp_file->get_path(), env); + set_generic_options(*rdr, opts); #ifdef WITH_DEBUG_SELF_COMPARISON if (opts.debug_abidiff