[02/17] elf-based-reader: Clean up logic of elf_based_reader::read_and_add_corpus_to_group
Message ID | 20240716145541.473065-3-dodji@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <libabigail-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7DF15387088C for <patchwork@sourceware.org>; Tue, 16 Jul 2024 14:55:51 +0000 (GMT) X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by sourceware.org (Postfix) with ESMTPS id 8892B384A475 for <libabigail@sourceware.org>; Tue, 16 Jul 2024 14:55:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8892B384A475 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8892B384A475 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.70.183.195 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721141747; cv=none; b=OkzW0Ydb0Q3HA6ubIvA++6jmG0yWCNhUHa07khrQGs6k9MAEHgLGlfjeIvmb3S1JKlApB7ZhVRszp77OM8YYZlEBIYFN6uZsy1nVXrKFqFvoeqwO53QeAgkvNJFuKf+YiY3hj6qBgFZbLDgRCVA609wbAs1w+ALGwV1HkLYb+Sk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721141747; c=relaxed/simple; bh=W+bUVIqhWRUqlJsnAzDVjYY61adXXrFP6XQ/7b/vw+Q=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=CyOq3C4efdu0X5Fq+eSFzmVhqpqxuBaIGxyhvndHw9gJGSdAX2yUlO4PQaGVg8h+DtKxvBjM47PnXs+CTI7xL5oSy8dsK/EspQt5uueuvb9fDb/zO/D0JF3VmItV4SV16Q3gvcOOJZeXHHouX1jejvXsp0irRO2tqMbjzs71BSE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail.gandi.net (Postfix) with ESMTPSA id E4D6760005; Tue, 16 Jul 2024 14:55:41 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 35D63C1B7753; Tue, 16 Jul 2024 16:55:41 +0200 (CEST) From: dodji@redhat.com To: libabigail@sourceware.org Cc: dodji@redhat.com Subject: [PATCH 02/17] elf-based-reader: Clean up logic of elf_based_reader::read_and_add_corpus_to_group Date: Tue, 16 Jul 2024 16:55:13 +0200 Message-ID: <20240716145541.473065-3-dodji@redhat.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20240716145541.473065-1-dodji@redhat.com> References: <20240716145541.473065-1-dodji@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-GND-Sasl: dodj@seketeli.org X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>, <mailto:libabigail-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libabigail/> List-Post: <mailto:libabigail@sourceware.org> List-Help: <mailto:libabigail-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>, <mailto:libabigail-request@sourceware.org?subject=subscribe> Errors-To: libabigail-bounces~patchwork=sourceware.org@sourceware.org |
Series |
Support self comparison of vmlinux & modules using BTF/CTF
|
|
Commit Message
Dodji Seketeli
July 16, 2024, 2:55 p.m. UTC
From: Dodji Seketeli <dodji@redhat.com> While looking at something else, I noticed the logic of elf_based_reader::read_and_add_corpus_to_group wasn't clear. The corpus should be read (thus created) first, then added to the reader. Fixed thus. * src/abg-elf-based-reader.cc (elf_based_reader::read_and_add_corpus_to_group): Fix logic. Signed-off-by: Dodji Seketeli <dodji@redhat.com> --- src/abg-elf-based-reader.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/abg-elf-based-reader.cc b/src/abg-elf-based-reader.cc index 123e5fec..32c0699e 100644 --- a/src/abg-elf-based-reader.cc +++ b/src/abg-elf-based-reader.cc @@ -107,8 +107,8 @@ ir::corpus_sptr elf_based_reader::read_and_add_corpus_to_group(ir::corpus_group& group, fe_iface::status& status) { - group.add_corpus(corpus()); ir::corpus_sptr corp = read_corpus(status); + group.add_corpus(corp); return corp; }