From patchwork Tue Jun 6 08:51:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Matthias_M=C3=A4nnich?= X-Patchwork-Id: 70630 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BC8193857BB3 for ; Tue, 6 Jun 2023 08:52:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC8193857BB3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686041541; bh=TUnXINXg4Lve8z4CwGPPaRKzzGriZFGpQJqI+66ODbs=; h=Date:Subject:To:Cc:List-Id:List-Unsubscribe:List-Archive: List-Help:List-Subscribe:From:Reply-To:From; b=DEuOToSAhc6IlcgKle37tL18FHdk1txM7msRRmAF1MrJgneJpqDrhJtNy++sYpf8o oFqPBcdXNE595QPJ/ekzUHLKTgY0Fp2G7zeQKZX3XArl1Gsz3dEDl10EPdBtofBnC1 mgEd9WZUjZ/h9HCK7Xz98GqGBn4+TnKenBnqghGY= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by sourceware.org (Postfix) with ESMTPS id 5BD153858416 for ; Tue, 6 Jun 2023 08:52:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5BD153858416 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-565ba5667d5so82712167b3.0 for ; Tue, 06 Jun 2023 01:52:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686041536; x=1688633536; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TUnXINXg4Lve8z4CwGPPaRKzzGriZFGpQJqI+66ODbs=; b=T5Nc6NWSFuCTOQALP+nTyTB4yCGfZptlbS0/GeqXXHUjcMkfIr2sef1UtuGQWbFQUt f60d5qfzBaQEPCmWOQQPVKd5dlPwwAs4wNKLjlS1pihxjESuKW7o+xgeH3lib3AP9BW1 5nB7gcFTiiOGIK7wbP1fBb+2tgbBYcX5Y46dYo6TBqHC23q7VRh0G1JNAkwhAgmg/biJ wTWVS89Ttsp7bIOpCKmozHF4iz+HjJMWx5Iqbn3Up7dxoiPSX8LC6oipP9Xj3M+bKnka IwEvsknZgM+lX8j8xqVMhaEc5g8EdaX5oGnn5KBAXoxjFTk2IBXIRYwkMHgvCvnhXCCG 9q7Q== X-Gm-Message-State: AC+VfDzbMVxPqc/J7rKHNEcYcqw+vl/WnGWc7FNboyjQyuvzCFXibbW9 GfwwyDNcgdP/bvisIRljEHWI704frtCCmtCGvs25Ln6iru4x/Dspv0cKJg5Z7adRiESWTPtCRDq SVYrooD2nWHa0cXyTGgY+eeCOJnS/C8EQWJU8u2wm5mV6E4TH5Q9Xs35wIjcgq/FAX1P69Ic= X-Google-Smtp-Source: ACHHUZ4ATe2dhmJ6clM+U4HCeaud7dHIDdwftqYbM2N+0exRYJBX2qQFm8+aHom0o7zqkAdMB/vqh0/IEO5Smg== X-Received: from lux.lon.corp.google.com ([2a00:79e0:d:209:65d7:da0e:bd15:3540]) (user=maennich job=sendgmr) by 2002:a81:b146:0:b0:568:9e88:6aa4 with SMTP id p67-20020a81b146000000b005689e886aa4mr667597ywh.6.1686041535874; Tue, 06 Jun 2023 01:52:15 -0700 (PDT) Date: Tue, 6 Jun 2023 09:51:33 +0100 Message-Id: <20230606085132.1894137-3-maennich@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog Subject: [PATCH 1/2] symtab reader: use C++11 `using` syntax instead of typedefs To: libabigail@sourceware.org Cc: dodji@seketeli.org, gprocida@google.com, kernel-team@android.com, maennich@google.com X-Spam-Status: No, score=-21.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?Matthias_M=C3=A4nnich_via_Libabigail?= From: =?utf-8?q?Matthias_M=C3=A4nnich?= Reply-To: =?utf-8?q?Matthias_M=C3=A4nnich?= Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" From: Matthias Maennich That is to increase readability and to incrementally modernize the code base. * abg-symtab-reader.h: replace typedefs by corresponding using declarations. Signed-off-by: Matthias Maennich Reviewed-by: Giuliano Procida --- src/abg-symtab-reader.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/abg-symtab-reader.h b/src/abg-symtab-reader.h index 2e13e7f9976f..7477cca5a6f0 100644 --- a/src/abg-symtab-reader.h +++ b/src/abg-symtab-reader.h @@ -99,7 +99,7 @@ private: /// Base iterator for our custom iterator based on whatever the const_iterator /// is for a vector of symbols. /// As of writing this, std::vector::const_iterator. -typedef elf_symbols::const_iterator base_iterator; +using base_iterator = elf_symbols::const_iterator; /// An iterator to walk a vector of elf_symbols filtered by symtab_filter. /// @@ -110,11 +110,11 @@ typedef elf_symbols::const_iterator base_iterator; class symtab_iterator : public base_iterator { public: - typedef base_iterator::value_type value_type; - typedef base_iterator::reference reference; - typedef base_iterator::pointer pointer; - typedef base_iterator::difference_type difference_type; - typedef std::forward_iterator_tag iterator_category; + using value_type = base_iterator::value_type; + using reference = base_iterator::reference; + using pointer = base_iterator::pointer; + using difference_type = base_iterator::difference_type; + using iterator_category = std::forward_iterator_tag; /// Construct the iterator based on a pair of underlying iterators and a /// symtab_filter object. Immediately fast forward to the next element that @@ -172,7 +172,7 @@ private: /// Convenience declaration of a unique_ptr class symtab; -typedef std::unique_ptr symtab_ptr; +using symtab_ptr = std::unique_ptr; /// symtab is the actual data container of the symtab_reader implementation. /// @@ -201,7 +201,7 @@ typedef std::unique_ptr symtab_ptr; class symtab { public: - typedef std::function symbol_predicate; + using symbol_predicate = std::function; /// Indicate whether any (kernel) symbols have been seen at construction. /// @@ -215,7 +215,7 @@ public: /// The (only) iterator type we offer is a const_iterator implemented by the /// symtab_iterator. - typedef symtab_iterator const_iterator; + using const_iterator = symtab_iterator; /// Obtain an iterator to the beginning of the symtab according to the filter /// criteria. Whenever this iterator advances, it skips elements that do not @@ -271,12 +271,12 @@ private: bool has_ksymtab_entries_; /// Lookup map name->symbol(s) - typedef std::unordered_map> - name_symbol_map_type; + using name_symbol_map_type = + std::unordered_map>; name_symbol_map_type name_symbol_map_; /// Lookup map addr->symbol - typedef std::unordered_map addr_symbol_map_type; + using addr_symbol_map_type = std::unordered_map; addr_symbol_map_type addr_symbol_map_; /// Lookup map function entry address -> symbol