From patchwork Tue Mar 7 18:57:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Guillermo E. Martinez" X-Patchwork-Id: 66094 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3C44C385800C for ; Tue, 7 Mar 2023 18:57:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C44C385800C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678215463; bh=FffKmW5SRaC4uJrXqiMOhKSUuOB2VfWjD7NgNIoZjBI=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Help:List-Subscribe:From: Reply-To:From; b=pNhoqROw7qV3uOv4z4PLSug9f54OVdonevJEevBVTEPu68MTQpd353rEA61ii/LCs ZxWRpznQoi+ggRQg3PA/tXRTXch68MSJK6fZPlzOrUQK52mCEZswQ8fKGSvU77ufdh OH+xwSW4KjIqJBqg0sqHCcX3Z0MKIOGiMtFpBgsw= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 29DA43858C2C for ; Tue, 7 Mar 2023 18:57:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29DA43858C2C Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 327Hwj9K021850 for ; Tue, 7 Mar 2023 18:57:37 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3p4168pbnw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 07 Mar 2023 18:57:37 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 327IolUs029280 for ; Tue, 7 Mar 2023 18:57:37 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2046.outbound.protection.outlook.com [104.47.57.46]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3p4u1feud3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 07 Mar 2023 18:57:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NUPsPZutkNTJa0ednw+9Vj85Tp73OsSmJPMUmrBgJFtRGbN7XT/rBCh4armvvGOG16Kr+q9NY4dAAhUYxr8t0oivZaMzHbZZwJ7ldUp5D2s+vTIiX6CRzoaWNU2wlAKYYiL8BhiLIQIVzYdnSmieFjEIE0VGvfosJXZZfYG3VIghIQvQRgbUQezegipEHrd5OSbmCDo5u59Pxabe18qKMLuUUhTqKHdMkId++h33hWbLTljO2PIJX0RU3EfFdPm/3GddY8cOPq77wrys+d/DWIugT6o6rnHaa/HIX0bXZsu/unmanz5RIbZfw3sWzC4dgW0Q2mp4oKLyFWs7s74Zwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FffKmW5SRaC4uJrXqiMOhKSUuOB2VfWjD7NgNIoZjBI=; b=ixIHJzQ7Ec0a1clBBvZasoVoVRGqEBzbCxwVuAXL7vMuzlXs22pWfDAv98zpuShOo1krf8jTng+eE4tN69du7Ip+FOUprL6V7AU/XqOd1XS0rUC7l1M/Y6gUWzOoRRPHhKKmNNxgNlUzNw3u/fNgwih6FLj+8IixMMkEJ9JrE+Opsl4maFHaq88eWYoY4Up4HB40iXM3S8oierfjDRzwh7S0hav5wQtSnilggu/q29advpS5ZUTOTorDgQCeTyH8FnSJfgb1uPT+fKN/FbWRFlEJou7ez3ioJxr8Sp50ZNToyG9HYxkaPYypbUoib/DQHQngzVrjEWoKffl0njdimg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by DM4PR10MB6087.namprd10.prod.outlook.com (2603:10b6:8:bf::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28; Tue, 7 Mar 2023 18:57:35 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::480f:b0b1:2e28:546e]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::480f:b0b1:2e28:546e%7]) with mapi id 15.20.6156.028; Tue, 7 Mar 2023 18:57:35 +0000 To: libabigail@sourceware.org Cc: "Guillermo E. Martinez" Subject: [PATCH v2] abipkgdiff: Remove useless code to process kernel RPM packages Date: Tue, 7 Mar 2023 12:57:28 -0600 Message-Id: <20230307185728.107659-1-guillermo.e.martinez@oracle.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306155038.3316079-1-guillermo.e.martinez@oracle.com> References: <20230306155038.3316079-1-guillermo.e.martinez@oracle.com> X-ClientProxiedBy: SA1PR05CA0014.namprd05.prod.outlook.com (2603:10b6:806:2d2::23) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR10MB1407:EE_|DM4PR10MB6087:EE_ X-MS-Office365-Filtering-Correlation-Id: bad4cfdd-a5ca-4c93-74c9-08db1f3dcffc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b+itWR+kfi0ATGsb8V00dxZ7ihqQqPF8A24oLCCwKhI7l4rK1XU/3UUxTkiVZbuonBIniBpODHCGBgVY/UkTwA+5hvcClJzk1YujBMTMS9UDVSzfNHSY8yorfZEu/xSVJCtyJxVvIiJ9VAT20z15N5DGcObAuPF/FkNIM/LjINHwW5/MPlEckDO+rMrelzlRidH7eryZCDVsw9YZT0jR4GgoM0Otcd1ArXwWx/jS7YKSTHQRi1Q/nsBYklh0xU4zmPUxVV1bxB6p4x9HQkrMHO36kwnvSh5QsAFPOGAvYR6t+hFcTAGts356zGAWmrilNU+krKXt5jwkor0XvhR1fFcCz6KvCoWO34kWXttSMxUYMniMXl7S2U9dZweiZgpYBiJXbUP9HSgG7qTFHMZxTurRKgPOXn8Jg6eazRkdQQD5XRg/9t5mJOynfxlFITEhuBhqYG8i7cvVBt7nnW4x8mBVDDioafoUGhPv2mi7BhugIKPFmAjaYZ+H5tmk8uor6dRT91YSNkukeIKpToxSmvGJm8Zr7T2Upl0tHSOCkDZ558l2UMxmrrSoJkGkMCUsZ7d9R972ase0OjveogqSb8wSB+gTUTKnPn7bbxFqdXO3HVinqV3suXsgG6WLzzpIZpn1lXW4jZyIRLqNxBXOpA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR10MB1407.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(39860400002)(396003)(376002)(346002)(366004)(451199018)(103116003)(83380400001)(107886003)(36756003)(478600001)(316002)(38100700002)(5660300002)(6512007)(6486002)(6666004)(2616005)(41300700001)(1076003)(186003)(6506007)(66476007)(4326008)(6916009)(66556008)(8936002)(66946007)(2906002)(86362001)(8676002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jEcDXPg4K+VhV2/Lx3PD2YcZ94ebu1XVqxUQCrNKPWNj7uA2LcPCG5lRjoJQ/uq4sxlW77ahDlBfQ4srNl0kEpstk7uKnNAka1hyRx7BVhDdjudk6y1rI5E89NFJodct9j18B6VJHU2rkQHeN+yq/Kg3EH2vpxVYvj1mhcpR40c04yRNI/Ko+Xs/VcHU+/uq49+aSKBx+VFarklj7icPcL/ndZXc69U4LLgneJBwLGs7zb/5kOI+5BtRu6LGzS4au9xPXw0w+ADplPb9FRoByTlM6QG9K8TCmZjNGgoYaQmby5jKBqSfY/c0vtYz3HFQawFIFfeGMttHr3UBo4iyjM+A7dtS2Lh/Qal4jUyktVnBq/U0NYeVBuMX4aFs1D8kLvn9N+b6iuEqD09tySzrs5vitYZZ0xQWrXSQTSyXWlGYYC8/5LD4tQ9+p46NijXR7OO9yVcAQn9j21pg6SaeUIMFe6a3Y4ENT0d7FiNSfr6RLBat95PlGg3w4uRPGFez36iIGQZ8A/XOQdOPvtRXFBcGuiFSypMqQV7iJDaBpKnQUJyJSnh7ppwP/qbEzAXlQD/VGi49EPvOGZVBfNvIjNSGpEewxQzA1sb8wMUyqChKZZRuJVQ5Ljv2K40BCBwtaklcCUHjBbyurHaEQSZVxnqWcatJha9VYTrzQrCKb/0Gw/bBcg1LjCbkCg51qvvn9tWs5EykcnGGmoiYzEzPySLQMv6ASmXe/ZEdwRd0bEDN0Ar5qFmc1LYTp+jSV6AtwcBvlW8UNmwwaYz44V7HBRyZTTJ/Y0G5EP1hOUVcyMeQsiFxf7CXr3w06W2CjTKrYvzU0IV299or8C35Ghjex/LYKtpyJ1lZeWbqNThEGiMVOqs3BnYpZQr66UkkCDZ6+WgEveg8z93oBUccK9FDZcFQA95+GdTUoWp71KyovPQ0cuXb3wOBVZ6w/fxZEIntXIS672bnMdAJYqUEtYtJMI3Qy7Lg5t9YMl+KtdWqfXr3C++rG8a+XFUNYqnUVm3TlyuYEpJuuqjMvutKTQVNtT5IyVLO9EJrx4U9595gp1Gs715jCLOFQYJpiixJfexNjbTl3+Q/v3FlZ7Xv20JCWm0Et5gUjtKfz+dt6fNUx41k/dcVnWPQwho7CnNhmrPVjGqTRQtFuYUiwPozoeiU7XF0KfzuTBBm+bLg6oyXFsyvYgRpEjOG/tD/g3W3s7KeVv+xUZat+CIUQTJwZ1xTe0mbHByOaDd3ABLk4AGvZyS3fcvb3b7BsYZBcBzYP5N5yVOQbdV1BKIQYq9A8y/MN7+9d1nBt1Knqr/o9a02uFpW07aZ+ey7VUJ0j+6su1ZnZ2uDYKAMgp9WdCVPhm+h5W6EeZwkjSpkN8A2ZpIlq177dS9J4052GXeb+fjH8um6mgXZPVht4BGG07xoUt0IqaV2SQCnnDlQtmvUVFNypruy9N19kfraK9jIJs3OAUZP3h4Ev771qwkZ2n3ZXOocItqQeZvNAWx1H2Rblu1vKbjpMYr9/u28ypHiGj1QK94HDSU2DpPpD8l7YOL1iWYgPDzlNz690lbYSU4Slh5AoWUP1seFrhi0EF7MipC2OssjnZOAJEZ6c9cfpu+FKePmJHVGlJdGXsOcywKs3l06HdCjmS0OrLh2ijGleLjYizben2MsZ8aETUY8nTd/AzdsxtUq3QEHMD9cc9O5ro+ERRA= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HhS87UG9Mv+WFRI9nCk8QwYuo9JIx9198iJfc/N77wt65Kp3HxFJ7Jb33siI5r4cCHCEIel0H/BAkivvPLZPy6/yQQNNy6CqKOoVOfffzFgz0vabcBuBYKB/NF6mpJSbozqSpOuzZ/IBIrpMwajAwgVr79/O1oT4duqhJ5mr408F9LHMt4w2cZVpWxGlVaXP256i6ClmSKl+AlLFTKQ9iRN2uVU5wHeR5eSAIZQHac6fDOCn+Bl5920FsICFTYgvJ5NbKaIQntIW8xq3bPUvdPTG8oN6QCkv6uukRdziFAALMVTPGaC/EnvAF9Gn9mqgugE5DDBFZF/fnUlfztZxXoQ6yXAZTCBHdQkW6BKU+cJm4MBmG32X8VusPzypJ8xstpIxJfW7g9GslBsLfoKRmaU2qQrW0ZTQRUHBtMQS6/vne3urbNiFgCdjHUXHyX9+gqIbwvCy0g/r1GyU5GDERwtodKO/X3SP5etfiQ92KNR1mRxbctLf80ZevaGyRf2m4qZCU0DJ07WqOVBysTN83kziF47R9FOxWNu1oGR/1A3BUcfbLBoai6NPEwIC03jNlz94PGYCa0Ud6nKnDf7pr6Abel2wownr0poa2YKGltpzuqT3u4h18RR+n8CEV7V4bD163vtPvFOTiGfgh8PgPFU6KQJYy9WCCNqclbKBkzwpv1PZBuTnIK5XEr8nhUaYiAYGjEhU2RHh+OwrEodMvGnq+cxJRFCsSRQdn8oCglGASvHtZcBapcnSwkN5lscx X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bad4cfdd-a5ca-4c93-74c9-08db1f3dcffc X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 18:57:34.9389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kMZ8xL5//6XtE/tu+u8/KJzGmHPM6yuroBDgPrAN5pHeV7rHNuwQqMqTj4kUb5hNHMcOzSc7PVvGr1NZY6etFee9X00wkyhQds1/BlPivAU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6087 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-07_14,2023-03-07_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303070168 X-Proofpoint-GUID: qePa_tlRRVlPYRtlyx3IKpQhxKfLIjka X-Proofpoint-ORIG-GUID: qePa_tlRRVlPYRtlyx3IKpQhxKfLIjka X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Guillermo E. Martinez via Libabigail" From: "Guillermo E. Martinez" Reply-To: "Guillermo E. Martinez" Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" In `abipkgdiff' working with a `kernel' package, the function `get_vmlinux_path_from_kernel_dist' that looks for `vmlinux' file in never reached, due to check an useless predicate. * tools/abipkgdiff.cc (compare_prepared_linux_kernel_packages): Remove useless predicate. Signed-off-by: Guillermo E. Martinez --- tools/abipkgdiff.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc index c2fc09ca..46b920a1 100644 --- a/tools/abipkgdiff.cc +++ b/tools/abipkgdiff.cc @@ -3106,8 +3106,7 @@ compare_prepared_linux_kernel_packages(package& first_package, string vmlinux_path1, vmlinux_path2; - if (!vmlinux_path1.empty() - && !get_vmlinux_path_from_kernel_dist(debug_dir1, vmlinux_path1)) + if (!get_vmlinux_path_from_kernel_dist(debug_dir1, vmlinux_path1)) { emit_prefix("abipkgdiff", cerr) << "Could not find vmlinux in debuginfo package '" @@ -3116,8 +3115,7 @@ compare_prepared_linux_kernel_packages(package& first_package, return abigail::tools_utils::ABIDIFF_ERROR; } - if (!vmlinux_path2.empty() - && !get_vmlinux_path_from_kernel_dist(debug_dir2, vmlinux_path2)) + if (!get_vmlinux_path_from_kernel_dist(debug_dir2, vmlinux_path2)) { emit_prefix("abipkgdiff", cerr) << "Could not find vmlinux in debuginfo package '"