diff mbox series

[v5,1/4] crc_changed: eliminate copying of shared_ptr values

Message ID 20220613142533.3676501-2-gprocida@google.com
State New
Headers
Series [v5,1/4] crc_changed: eliminate copying of shared_ptr values |

Commit Message

Giuliano Procida June 13, 2022, 2:25 p.m. UTC 
  As pointed out in a review of similar code, it is possible to avoid
copying a couple of shared pointers in this function, by taking
references instead.

This commit also splits declarations to one per line and removes the
unnecessary parentheses around the return expression.

	* src/abg-comp-filter.cc (crc_changed): Take references to
	avoid std::shared_ptr copying. Split declarations into one per
	line. Remove unnecessary return expression parentheses.

Reviewed-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 src/abg-comp-filter.cc | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Dodji Seketeli June 30, 2022, 4:40 p.m. UTC | #1 
Hello,

Giuliano Procida <gprocida@google.com> a écrit:

> As pointed out in a review of similar code, it is possible to avoid
> copying a couple of shared pointers in this function, by taking
> references instead.
>
> This commit also splits declarations to one per line and removes the
> unnecessary parentheses around the return expression.
>
> 	* src/abg-comp-filter.cc (crc_changed): Take references to
> 	avoid std::shared_ptr copying. Split declarations into one per
> 	line. Remove unnecessary return expression parentheses.
>
> Reviewed-by: Matthias Maennich <maennich@google.com>
> Signed-off-by: Giuliano Procida <gprocida@google.com>

Applied to master, thanks!

[...]

Cheers,
diff mbox series

Patch

diff --git a/src/abg-comp-filter.cc b/src/abg-comp-filter.cc
index 56251274..f90fdc78 100644
--- a/src/abg-comp-filter.cc
+++ b/src/abg-comp-filter.cc
@@ -230,11 +230,13 @@  static bool
 crc_changed(const function_or_var_decl_sptr& f,
 	    const function_or_var_decl_sptr& s)
 {
-  const auto symbol_f  = f->get_symbol(), symbol_s = s->get_symbol();
+  const auto& symbol_f = f->get_symbol();
+  const auto& symbol_s = s->get_symbol();
   if (!symbol_f || !symbol_s)
     return false;
-  const auto crc_f = symbol_f->get_crc(), crc_s = symbol_s->get_crc();
-  return (crc_f != 0 && crc_s != 0 && crc_f != crc_s);
+  const auto crc_f = symbol_f->get_crc();
+  const auto crc_s = symbol_s->get_crc();
+  return crc_f != 0 && crc_s != 0 && crc_f != crc_s;
 }
 
 /// Test if the current diff tree node carries a CRC change in either a