From patchwork Wed Mar 16 16:30:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giuliano Procida X-Patchwork-Id: 52012 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D4C03888821 for ; Wed, 16 Mar 2022 16:31:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D4C03888821 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1647448294; bh=ZmtlayKLLf1Ev4AkINXNqsacXFAWi4pV7HgUVAwE3yU=; h=Date:In-Reply-To:References:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=GBam0nv2MgOEmKUAMz/daFTdeHc8/PNhT/IkWpQTvsmoLgv2rUubs6JCHXJw4TD4b 4WSeWupd0EBNvM7ebHiYXkz2rzwHZUcGJ61lfNLmXVyRBCcORiLYBQKUSfVblLBCjq hng5RhiPokr520tx/sglO29Q82P2w5ly599eb3tk= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-ed1-x54a.google.com (mail-ed1-x54a.google.com [IPv6:2a00:1450:4864:20::54a]) by sourceware.org (Postfix) with ESMTPS id 20E81388883D for ; Wed, 16 Mar 2022 16:31:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20E81388883D Received: by mail-ed1-x54a.google.com with SMTP id x25-20020a50d619000000b00418e70d8528so1604890edi.21 for ; Wed, 16 Mar 2022 09:31:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=ZmtlayKLLf1Ev4AkINXNqsacXFAWi4pV7HgUVAwE3yU=; b=pPJiPxmPOXZAziJPlOZgvv37USOHC+OClwm5ulEghpVEZsklMVpM5y7N8iq+KLoaif WHUeSmqt8Adc7UOUYDenunfd0hmDA2aYnqmhkDom8OC//bzhDTU2+qcKMmzuZ9VUQt2d XpcIeLuA0rf6ALtl/DPel/0ZEjZatR9uAIwtfsk4h45aRpOxl1LjSLgQtSl7LLflGZ9G HdTiroD7t378F58XfWCMiedwraMIppomu/QT2bOE5kalNCHdC/P90qHZh40D79uZSXGr rFpy5Qufei8FBoD7QRZKMwJveVpd5Uj2apDz9MyyxRpu6aivbHIq9Hn02+RRxtwATt4u 00sw== X-Gm-Message-State: AOAM531NWQmKuUNUwhSxF5V7mZpj012LgYhMAwtihdWfj3dXdubCh5au CW33Z8YSjHAz1AscG0nh4TB/maAeXCyJMZ94Fl+ni6nSsYuHEenRaW0BEq+d06qfwMix+v7Q+R1 lVvIDy2DdwtOCn3QyY4JOYTBs/mpAe3KFJ3Xb0dRV+oGE/VON/45REJKWthlOGsVxEdivjoM= X-Google-Smtp-Source: ABdhPJxRCmRhv77u+cl5qQ4rm/1NjLscJEN6m/wjg32+M9cpeqQUzZ7knMj+bS2gRPgOsJ1khh/DC+aorQadIw== X-Received: from tef.lon.corp.google.com ([2a00:79e0:d:210:5871:c940:7381:f8f4]) (user=gprocida job=sendgmr) by 2002:aa7:ca01:0:b0:415:ece6:b0d9 with SMTP id y1-20020aa7ca01000000b00415ece6b0d9mr266197eds.303.1647448286808; Wed, 16 Mar 2022 09:31:26 -0700 (PDT) Date: Wed, 16 Mar 2022 16:30:53 +0000 In-Reply-To: <20220316163055.4127796-1-gprocida@google.com> Message-Id: <20220316163055.4127796-3-gprocida@google.com> Mime-Version: 1.0 References: <20220314181312.3436802-1-gprocida@google.com> <20220316163055.4127796-1-gprocida@google.com> X-Mailer: git-send-email 2.35.1.894.gb6a874cedc-goog Subject: [PATCH v2 2/4] crc_changed: eliminate copying of shared_ptr values To: libabigail@sourceware.org X-Spam-Status: No, score=-21.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Giuliano Procida via Libabigail From: Giuliano Procida Reply-To: Giuliano Procida Cc: maennich@google.com, kernel-team@android.com Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" As pointed out in a review of similar code, it is possible to avoid copying a couple of shared pointers in this function, by taking references instead. This commit also splits declarations to one per line and removes the unnecessary parentheses around the return expression. * src/abg-comp-filter.cc (crc_changed): Take references to avoid std::shared_ptr copying. Split declarations into one per line. Remove unnecessary return expression parentheses. Signed-off-by: Giuliano Procida Reviewed-by: Matthias Maennich --- src/abg-comp-filter.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/abg-comp-filter.cc b/src/abg-comp-filter.cc index 56251274..f90fdc78 100644 --- a/src/abg-comp-filter.cc +++ b/src/abg-comp-filter.cc @@ -230,11 +230,13 @@ static bool crc_changed(const function_or_var_decl_sptr& f, const function_or_var_decl_sptr& s) { - const auto symbol_f = f->get_symbol(), symbol_s = s->get_symbol(); + const auto& symbol_f = f->get_symbol(); + const auto& symbol_s = s->get_symbol(); if (!symbol_f || !symbol_s) return false; - const auto crc_f = symbol_f->get_crc(), crc_s = symbol_s->get_crc(); - return (crc_f != 0 && crc_s != 0 && crc_f != crc_s); + const auto crc_f = symbol_f->get_crc(); + const auto crc_s = symbol_s->get_crc(); + return crc_f != 0 && crc_s != 0 && crc_f != crc_s; } /// Test if the current diff tree node carries a CRC change in either a