From patchwork Fri Jan 21 17:30:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giuliano Procida X-Patchwork-Id: 50322 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F29EB3858C3A for ; Fri, 21 Jan 2022 17:33:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F29EB3858C3A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1642786383; bh=91kbS8Fdfa9YfFW0ee3fVly9Zdkz3w5S9ooFxM4qdsM=; h=Date:In-Reply-To:References:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=i9khMJmlL91Gjs3vuycPCYE6PlmEUq93Bd461XpwBarez4NOBmykqJ3mTtYLqNg5J NLEhKK3Ffa6HG3DqsGtfZ5OpJPmCwju+f2Zd95bKJAkjzzUXKYbHPBg4Bx0ldWqwPJ +9M/CHgbWvhok9GWYmDVbTdW1HeueBp6MfIvzg50= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-ed1-x54a.google.com (mail-ed1-x54a.google.com [IPv6:2a00:1450:4864:20::54a]) by sourceware.org (Postfix) with ESMTPS id AF72A3857829 for ; Fri, 21 Jan 2022 17:30:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AF72A3857829 Received: by mail-ed1-x54a.google.com with SMTP id el8-20020a056402360800b00403bbdcef64so9355136edb.14 for ; Fri, 21 Jan 2022 09:30:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=91kbS8Fdfa9YfFW0ee3fVly9Zdkz3w5S9ooFxM4qdsM=; b=aXPkDTf4EAyKbFJ0DbN1MJsImQYS8hBp6vIj++03EyfXDI230vehht2QrQk1neyXmf qH9Weswk6rRaidgiEbepRd9s3Dc2nTE44lUnZBB/1zHE7l6/C2HChO9hov9FIjqIMTuy jBoKiUkoVhIQVxnqq0WPbPhb1uBRSqR7H/5HObU8WLHFYACL4aUmUh0Q8ZekVluJ+9Ug QJjFlP5bSTo5M5a3/LPDItLq11TkfvRwctczPax27Xniid/svfN+Q+uZ+RxL/l5auNCk hjU27YCR4DyD/m7P2g8vQe09lR9Ud37djcwH2VIAace0EIozwmw8xwFC/XNcbKqVYeZ5 tjkA== X-Gm-Message-State: AOAM532RCge74nrtJX8Jrx9uBG8e4CieNxwxxZ6LuPl5QSCPUqtKn8V3 qllJdL2gr7/jTrjTHAx3IhG3DOOkDCDrhKNW2BAoHFis9MJZtWOzBOm1PJC/Q/i8R4vrjZqcU0Q bqKh1HQKziFwz+tQsW1t3W0B01C/DemWlgKsiOc+Uz3kSHX9HKpNcVoE0eddjZlx6fMqN1y8= X-Google-Smtp-Source: ABdhPJwVITsP/+bIASSMdubp2MxJ/gY6+2nHz6tYevxC4M7xrau7rpjj0CfM9iC1BLlhtbLBV35mZDfTjy2mTQ== X-Received: from tef.lon.corp.google.com ([2a00:79e0:d:210:5386:4792:3248:8d5d]) (user=gprocida job=sendgmr) by 2002:a17:907:92b:: with SMTP id au11mr4099139ejc.304.1642786215572; Fri, 21 Jan 2022 09:30:15 -0800 (PST) Date: Fri, 21 Jan 2022 17:30:02 +0000 In-Reply-To: <20220121173005.3196387-1-gprocida@google.com> Message-Id: <20220121173005.3196387-2-gprocida@google.com> Mime-Version: 1.0 References: <20220121173005.3196387-1-gprocida@google.com> X-Mailer: git-send-email 2.34.1.703.g22d0c6ccf7-goog Subject: [PATCH 1/4] XML writer: remove type_hasher and remaining comment To: libabigail@sourceware.org X-Spam-Status: No, score=-21.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Giuliano Procida via Libabigail From: Giuliano Procida Reply-To: Giuliano Procida Cc: maennich@google.com, kernel-team@android.com Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" The type_hasher functor is no longer used. * src/abg-writer.cc (type_hasher): Remove this unused functor. Remove a following comment referencing it. Reviewed-by: Matthias Maennich Signed-off-by: Giuliano Procida --- src/abg-writer.cc | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/abg-writer.cc b/src/abg-writer.cc index 24a1fd56..525f6682 100644 --- a/src/abg-writer.cc +++ b/src/abg-writer.cc @@ -107,18 +107,9 @@ public: } }; -/// A hashing functor that should be as fast as possible. -struct type_hasher -{ - size_t - operator()(const type_base* t) const - {return hash_type(t);} -}; // end struct type_hasher - /// A convenience typedef for a map that associates a pointer to type -/// to a string. The pointer to type is hashed as fast as possible. -typedef unordered_map type_ptr_map; +/// to a string. +typedef unordered_map type_ptr_map; // A convenience typedef for a set of type_base*. typedef std::unordered_set type_ptr_set_type;