From patchwork Fri Dec 3 11:46:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Matthias_M=C3=A4nnich?= X-Patchwork-Id: 48462 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B331C3858001 for ; Fri, 3 Dec 2021 12:09:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B331C3858001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1638533356; bh=MQgzZiea8hoG3Vxy854j46b/3JOrXpF0ygXNMV3TFTU=; h=Date:In-Reply-To:References:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=UTgux0ocUscqYs3LhoKai7B230kK8h3tvTf+QAMYv/I4fVatThR7lrb/qmyzBkVMn j2pw4YVHKH0wYB/eU2CLloghsWp7uz9WSU7TsaTxyZDPua/Fk4xJK3gFo9Res3l6iN 8+74sxx8e8q1N5jKXiexvLV4X6oZsFIWrLCZQK58= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-wm1-x34a.google.com (mail-wm1-x34a.google.com [IPv6:2a00:1450:4864:20::34a]) by sourceware.org (Postfix) with ESMTPS id 4C0003858022 for ; Fri, 3 Dec 2021 12:09:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C0003858022 Received: by mail-wm1-x34a.google.com with SMTP id z138-20020a1c7e90000000b003319c5f9164so3348760wmc.7 for ; Fri, 03 Dec 2021 04:09:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=MQgzZiea8hoG3Vxy854j46b/3JOrXpF0ygXNMV3TFTU=; b=sE+OeDt+P33qcQMyv2qTxEejN6sd7AmzZbGoMsUOJT2CswplYgBtJ87IYCFz1SP3UE OeD/CbIiEjdvG6dcHRxAY9kUCRjVx1N8NkLH8iKPuFyb0HtUpX83tMx+CP9MEjxDl8SR RLTtp37t3HxYbhtq5kClnwoxVIxrdvpWRmh2LlVnAQGIHLaJo4Ow7hYyb6h/Jnh4+V18 gBdZk5fNCQqXnUGQ5+ARhrCFEXlBj1fKxvIa3+QukraI724kwXfXr2hQAVcqy15OU7sw XEh8POXNQ75JtysX7BznX6gRsM9hNA9jjGjI77c5PE99E/RuJrBC2mIYYO2U5SHwnxVb RHVQ== X-Gm-Message-State: AOAM532oMm6sYzcPQhOQKMKOQup8O04fUBOFCQLzj+V9UAHFn+flVgSL PbB7baRxPYKXtgdjVHnjxEpKOeB5EH9iWsLdSSQQccRra4eUEp+sd4Chid2Opdb261upnunnp7E 6e7IyOU5N1vbEXrdJoudLJP5VRL7bSPlNhu5qar5oqSZHfY5ATAvT+1RMEHRSVyAM5QCm6k4= X-Google-Smtp-Source: ABdhPJzR3TsrtUPGvjvt9lzVnRm69S/0p7NZGWIWDniyaSjBZYT35qggk3iEE0mCb+HVL2ew6YkTGHTSievRKA== X-Received: from lux.lon.corp.google.com ([2a00:79e0:d:210:47e9:78df:690b:201]) (user=maennich job=sendgmr) by 2002:a7b:ce83:: with SMTP id q3mr14473491wmj.37.1638533351314; Fri, 03 Dec 2021 04:09:11 -0800 (PST) Date: Fri, 3 Dec 2021 11:46:21 +0000 In-Reply-To: <20211203114622.2944173-1-maennich@google.com> Message-Id: <20211203114622.2944173-4-maennich@google.com> Mime-Version: 1.0 References: <20211203114622.2944173-1-maennich@google.com> X-Mailer: git-send-email 2.34.1.400.ga245620fadb-goog Subject: [PATCH 3/5] XML writer: track emitted types by bare pointer To: libabigail@sourceware.org X-Spam-Status: No, score=-22.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Matthias Maennich via Libabigail From: =?utf-8?q?Matthias_M=C3=A4nnich?= Reply-To: Matthias Maennich Cc: maennich@google.com, kernel-team@android.com Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" This is a performance and safety improvement made possible by the previous changes which ensure that the same pointers are inserted and looked up. This essentially removes the now unnecessary deep comparison. * src/abg-writer.cc (type_ptr_set_type): Change typedef container type to use default equality and hashing for pointer keys. (fn_type_ptr_set_type): Likewise. Reviewed-by: Giuliano Procida Signed-off-by: Matthias Maennich --- src/abg-writer.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/abg-writer.cc b/src/abg-writer.cc index 4cf2a7fb16af..d2ef19eb7095 100644 --- a/src/abg-writer.cc +++ b/src/abg-writer.cc @@ -123,14 +123,10 @@ typedef unordered_map type_ptr_map; // A convenience typedef for a set of type_base*. -typedef unordered_set -type_ptr_set_type; +typedef std::unordered_set type_ptr_set_type; /// A convenience typedef for a set of function type*. -typedef unordered_set -fn_type_ptr_set_type; +typedef std::unordered_set fn_type_ptr_set_type; typedef unordered_map, string,