From patchwork Thu Nov 18 23:23:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Guillermo E. Martinez" X-Patchwork-Id: 47910 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A7F7C3858015 for ; Thu, 18 Nov 2021 23:24:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A7F7C3858015 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637277847; bh=0Ei0/YaYOaNoRt7x4YJ/D1ajijXRxu10L7Yz8wn1Jbo=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=gjJ7E6iMF5J7WeQ/v9acDtN6qjSVQ1ja/ugtJYPCSZZzP1y/WV9w7QKRGlgSdrsdm tXUnAwToL1Fk55Fx3dYrHeUdcdgGWIUTobCTbOzXXA9iB3V0iUWsJfgehSwxpjRusG Eh1X8ePUIKm5vuZfQ09QYUyn9xobqNaS0YYkJorQ= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 9B0DD3858422 for ; Thu, 18 Nov 2021 23:24:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B0DD3858422 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AIMB6lc009987 for ; Thu, 18 Nov 2021 23:24:00 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3cd382kw2e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Nov 2021 23:23:59 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1AINKX7k184319 for ; Thu, 18 Nov 2021 23:23:58 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam08lp2170.outbound.protection.outlook.com [104.47.73.170]) by aserp3030.oracle.com with ESMTP id 3ccccsjghg-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Nov 2021 23:23:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xe9daBjXymKmGhKADyrIAqxZUHVg73looCoGplY/UTJh26qTsJlgSaXwynxvFVw1XAPfKjzityNWAkYj+rQ7P+m1d4uP8uQTlcEUx/UBPcH8KKtQ25X98RpHYNI/2myR9hZXDSwW/yrXPr6oX1oFRNe1yKNrPJEVcOfKcLZl7JNP3VuEbghxbrn93IsYuR7Tls5pdQrHivmcgU6Y5ZwOLjlfpaYKEq2PizzM1sC6G24P7fz3LCEBLy4gblX0rLoTl91KVHmAVR7iCv7LfviM/uMXdqXetqlDD4TsXuZBO9ViWGXOMBIpqmj1YmjgeLt01z+LhFhxbMZwZZTEPWpGRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Ei0/YaYOaNoRt7x4YJ/D1ajijXRxu10L7Yz8wn1Jbo=; b=hsRFVNJy5f1lI5DyCGyeo2k+JjJjFz5b+A50Y+LaY/rXKudxjGGTeswd+cOQUtX8S2A9cRy1IFj2HqjS3EcnuOUBvelhfjfT7JRIBPaKG7KTYzmcWFrc4qFhU3ZT+bYyGBfvHVdO9tF2YEnupBJpPGsBNMdg57MSnBmLkXGsbaOIrLmbOfUD7iFGjRHCZ58HcnbHxmLEQxy6kMP4j/LLIVvWA8bs5+i5CNdefAXV+6kye64HWjBy9P8QCQEr/p0bT/nBI48AvaJBeSaVs8bjNeYQvGoQ+9mZixpL54JDuBKNppcyxNe9zhwwvM5IyG3iyvkN1R2ouh30UTeiI70PRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) by MN2PR10MB4045.namprd10.prod.outlook.com (2603:10b6:208:1b7::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Thu, 18 Nov 2021 23:23:56 +0000 Received: from BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765]) by BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765%7]) with mapi id 15.20.4713.021; Thu, 18 Nov 2021 23:23:56 +0000 To: libabigail@sourceware.org Subject: [PATCH 1/3] ctf-reader: Use argument by reference reading the context Date: Thu, 18 Nov 2021 17:23:28 -0600 Message-Id: <20211118232330.16310-2-guillermo.e.martinez@oracle.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211118232330.16310-1-guillermo.e.martinez@oracle.com> References: <20211118025606.554809-1-guillermo.e.martinez@oracle.com> <20211118232330.16310-1-guillermo.e.martinez@oracle.com> X-ClientProxiedBy: SA0PR11CA0189.namprd11.prod.outlook.com (2603:10b6:806:1bc::14) To BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) MIME-Version: 1.0 Received: from sali.us.oracle.com (2606:b400:8004:44::1a) by SA0PR11CA0189.namprd11.prod.outlook.com (2603:10b6:806:1bc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Thu, 18 Nov 2021 23:23:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: da1b9595-ea48-4504-75ff-08d9aaea7dc8 X-MS-TrafficTypeDiagnostic: MN2PR10MB4045: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1107; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: npNcqVHsWZA6fBcAvS7VmJfUbZ27isommz9CuXLPOxFrh4Ik7slvvXOkHdmqpxRmt4mQ6b593cJh1QkJiLbbK5xUpyNBoqzTHQAxqXzG2SAzLLFyj1cIp13orN042kAt6GXrmiqbavVkIfp8sBZNuyJPhVyZH7RSNuXXRc6tF01eoGGVVlHBtTf4akBpRADyiUytQoPdq6D7hEaj9rMThJjMF4SOsVYMtAWB1sVDJlchScA+H6jor1+j15oX1ZrecyO4ZQUz/qMxh44tXLGeZRKjctYSOhkzXNF0QocmspgAC51iSJEoqwAovGVVQ6YlqUFGS6zhm1T7SsruKaUKtWPyh1JsXrlhpIwc16Xi8osdLrkdS9bOU6fjFzoHbGCs8wHZo6u36+bLly2aS/PfnoGDcbCHMi2x87zZJDy7AUhrRdX8+WuvRcaxuxA08KTX13SSVqePgDWrJXL9msUcyIa3Czs1zTrP5vx+Nq1GL5jCd3pnjdBkoDngvwFFn49XE98RkBwJKUFA76XPT05eqMNVWlLdYneDv35IMBvhW9DL9SgCF2tDqC3rCwt2jhrAlU/1LRTChctED4yE5BEaJ/SGzimEr9H9AqZnsJSrcmw8ouhl0QiC4sXja2vajds14t4HymwYTMkcyCSyg0Em/w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR10MB2852.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6666004)(6486002)(36756003)(107886003)(38100700002)(83380400001)(86362001)(5660300002)(52116002)(8936002)(8676002)(7696005)(2906002)(6916009)(508600001)(103116003)(66556008)(66946007)(316002)(66476007)(4326008)(2616005)(186003)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fQnyGvb754qdgTRQtSSUbP6yBVmcPe5hu/vo/0yMfFdhaxbU4nq4SZaxyGQ2l1fR+EJRs4umsyY+mWa1McTrQ/vyKSTT35UqVOQLbombTGYNL6+Tnp3FnDo6E7wmnmrwGU9ATorNWjVo+pAfi/4mihJ+48IFANxhJ0+wUv/GTBcMCFLD8ZhUTASCWymRoENepjESn02nkfx9Pny/jyRdhfh6wnHe/T8LC7rWGDTIx1sn+T77CS9Xa4AS5bwFISmvt0swEn2yrZ7psMZX5TGhL4KnxlAoyt8ORfMFNISH9JmxQuMWHJcAfuxweqMiYA656J1Odpv3/FO04rrHpMzqrhTPc7cVFKaNsKsPVsq3/zbCFHrLyAF+YZgpV+PeE55GAdflnYeJoBP8xe/F2ArVg8C+5hvFXB7A+uUM1fm2lK1FVsM52jE5bDp4oBxVLuM8inQVCe3llHy1yX15NVwNEqv967MY7M3gpxs1yvKxwL8UCfP9edV4uDDgW1pwBv5bMSS4s6WYRh+h9BBO8jJhxfgy+tSAm55N649dR75We/YTeWvsY253oDSNShaYheLDh+tvHs+sVYsv5UuG27qGhlYRE94QQekxcapG/htMmpNwcBS9eJ9X9SaEcvKVdDPDlizMSAaOdCDg8wu5n8AP1gHPkwcOWx5LYGbuhbKlp+cWav0wUcy0lmoe4y+434JRgAzIMFcWlN7SMHFYA3Uiy7rhEooaj7oHuaEMKVsMO20yWCw0EgLW+qsyl+DckJtrzQpLF5IAfqzWktQR0bep+IX3Kk2AyiO21OAyr7DNJRrR1tjkpxzDY1SfqCKxJhJkJLQskPA9kypc4WQ6ELdNqN8BPwZf6yQRDVtVyn6qvgy2q/DUfBZe6g6ag/7imOR39af+6QlXRuO+VfKQHdmq1Tw4fawsfYXNv+FKDw8IuYc1dpVf5xtB3wcvSwj16RukW+Et6qEJOIy/jUcRk1Ol9Ob7MdiCyS3N4jV3G1099vtoDs4kr+I45UkJ4OpfMUYFP1j5muXWf8r5VN2yBMnWz74FRLFOZO5r7TrZ0V/IgNNpKv/1D5zGh/sj9VqHPRvd+oyXU9ZmD6Lz+JDt9dQfQB2tqeGzqxiYlFi2o0hYhvDfIvL3/plZI6is08W0tURrPJJWa5Pank2kwhwjl2Fly8SPYqb8arRqvFCum0pwCleyuJDJntsiX2f+1F8k3d/2PQiXBMvad79lCk1P4aW6XFHsswXF6ieqDtBcxhOATKRY2OvjurtNh3WcSlfNjsaEO4DAMmCcHiAZuXRBO0RRMYP4lOZb+koIleMmVAThN8VwCV/a8VrV2vsktgS95VjKH8zs3M3w+GKo73f4eaj0fNZFqA/pnU2mmwWofpRZPkyNo9lEXGB2yadcHSWJQm+iZbn1j/I3xhJBe0IJQQ0d8BbMeBOHrHYnOINIdXYzBSseikNHK8P+eKgjj6oiC/PDe8XT8EUq4CiYlF8AdADbXKk/02dYnzEmaWrMhctq9aRAb/YHM+W7t2jRzihZbtWP8X08hmdsRbMBW78fF5EkeXEL2sXYFPA167aUYsxd8vOV3R3rpFvwRD1cpxJf72h2po0iSfP7CKUo4vghTbDfULrtR4oCNnLLMpS99XanNfu4+ExcRhwIe9Evf7+0DbS0kBEfJODIjhfN0lhZWvQ4ASiGZcSyddgMInNcYwTEkO4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: da1b9595-ea48-4504-75ff-08d9aaea7dc8 X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB2852.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 23:23:56.1692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DCOsk0m9qPP8LrJgQxvDvWB3kWUJfvvbyzPU5k4EEdYLU1EUDO/1gv2ek3kePbZy35f+7Mm/oE+uuQgeEFdQXStfGM5uL7s4/7PoLFQZPWI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4045 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10172 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111180120 X-Proofpoint-ORIG-GUID: Qev2BteU9RJZbqcVw0kGmCjtSNVl8_Ld X-Proofpoint-GUID: Qev2BteU9RJZbqcVw0kGmCjtSNVl8_Ld X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Guillermo E. Martinez via Libabigail" From: "Guillermo E. Martinez" Reply-To: "Guillermo E. Martinez" Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" * include/abg-ctf-reader.h (create_read_context): Pass the string by reference. * src/abg-ctf-reader.cc (ctf_reader::read_context): Likewise. (create_read_context): Likewise. Signed-off-by: Guillermo E. Martinez --- include/abg-ctf-reader.h | 8 ++++---- src/abg-ctf-reader.cc | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/abg-ctf-reader.h b/include/abg-ctf-reader.h index c0d8bb2b..56b2bf91 100644 --- a/include/abg-ctf-reader.h +++ b/include/abg-ctf-reader.h @@ -25,10 +25,10 @@ namespace ctf_reader { class read_context; -read_context *create_read_context (std::string elf_path, - ir::environment *env); -corpus_sptr read_corpus (read_context *ctxt, - elf_reader::status& status); +read_context *create_read_context(const std::string& elf_path, + ir::environment *env); +corpus_sptr read_corpus(read_context *ctxt, + elf_reader::status& status); } // end namespace ctf_reader } // end namespace abigail diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc index 0370c8aa..2c2c204d 100644 --- a/src/abg-ctf-reader.cc +++ b/src/abg-ctf-reader.cc @@ -102,7 +102,7 @@ public: /// Constructor. /// /// @param elf_path the path to the ELF file. - read_context(string elf_path, ir::environment *env) + read_context(const string& elf_path, ir::environment *env) { types_map.clear(); filename = elf_path; @@ -1060,7 +1060,8 @@ slurp_elf_info(read_context *ctxt, corpus_sptr corp) /// @param env a libabigail IR environment. read_context * -create_read_context(std::string elf_path, ir::environment *env) +create_read_context(const std::string& elf_path, + ir::environment *env) { return new read_context(elf_path, env); }