From patchwork Thu Nov 18 03:01:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Guillermo E. Martinez" X-Patchwork-Id: 47865 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A0D923858404 for ; Thu, 18 Nov 2021 03:01:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0D923858404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637204507; bh=kDkS4Bl4AmAatNQ27zGOrXROMtjfDYgZL3ewBmZv1zg=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=PyovqMdnZ/ipxVZvStcTdS09Do5dxl/hHCour8GxNoYABKAxdpUCpv9YY39uLWSSV MlOL1j51wgveb6Dcb4K+GOWFEJJUzNaGrLkMAfONLOXNHfOomRRvOLJExkedzsDc7t KHWF6bQi9hI0JTsLNxa/tgHRwS2j8l5L6lD+JHSk= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 685093858C2C for ; Thu, 18 Nov 2021 03:01:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 685093858C2C Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AI1YEnW000708 for ; Thu, 18 Nov 2021 03:01:40 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3cd205cq2h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Nov 2021 03:01:39 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1AI30J0A126762 for ; Thu, 18 Nov 2021 03:01:38 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by userp3030.oracle.com with ESMTP id 3ca2fys2t0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Nov 2021 03:01:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cnOBDDgiU+x9AEM3m9AHnpQGBysbN/4j/in+NmMLW+COTsE3u4OPXl8q2INVPZkO4yMXu/j4QcDX7DEOldyldE9mDkMAaeJBGedJRh/SO2vwSu7Mq7iSwQbzXg1Q9V+WWhGrpraNhLacaHuPOt4D3KN3KJjDZ+b/ts0wlJpjPscI1UamafPVqrGQ5xRjA3qFevySVFGVPQ9AkVRzQTomwmOBpvEDIkQWqVG+eT5ZeHNPj6nKx0yTAs60aOqSQSGgBYP/w6WQGj+GuqEULm0x1dBJWbumjpYsm5prdg3Y9Ydf8SMyRrpE73TqCrj0hErpkX4R/rJjwZ7d56i2Lk99fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kDkS4Bl4AmAatNQ27zGOrXROMtjfDYgZL3ewBmZv1zg=; b=TbsHBIoryGvEGw6xNolEI8I2/UrKbvRk66vscUjuKKdnVOUxNw52lJn6EmQoR4dm2+/n7kll8iCcu5x4fpPUbA9S8SxN63sGU+ydRxm7pXoVsCbeosXAaU9D/hjZ62f5h1cH9sl9b6YGe3xXja9ceE+DTvILdTQYwgBDjlDndRpTGyoNaayKOEN9WcP/VB4dIDgv9JSATVpAfeK9+MLMFCRMu0LgdAz4gMz6cs9q3R+WnJPhgRK8iwIKnNaTtcXYUugI4OmqT+/h8uG6q4wQ7PJZ6qdU35s2yn5HtfNUQZAsvYwhZC1M8Ljeuyh0ClYEjPrhdIkrmfDUoO5Ifn6cIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) by MN2PR10MB3982.namprd10.prod.outlook.com (2603:10b6:208:1bc::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Thu, 18 Nov 2021 03:01:36 +0000 Received: from BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765]) by BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765%7]) with mapi id 15.20.4713.021; Thu, 18 Nov 2021 03:01:36 +0000 To: libabigail@sourceware.org Subject: [PATCH 1/3] ctf-reader: Use argument by reference reading the context Date: Wed, 17 Nov 2021 21:01:14 -0600 Message-Id: <20211118030116.564632-2-guillermo.e.martinez@oracle.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211118030116.564632-1-guillermo.e.martinez@oracle.com> References: <20211118030116.564632-1-guillermo.e.martinez@oracle.com> X-ClientProxiedBy: BYAPR05CA0099.namprd05.prod.outlook.com (2603:10b6:a03:e0::40) To BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) MIME-Version: 1.0 Received: from sali.us.oracle.com (2606:b400:8004:44::13) by BYAPR05CA0099.namprd05.prod.outlook.com (2603:10b6:a03:e0::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.17 via Frontend Transport; Thu, 18 Nov 2021 03:01:35 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4582086b-5dea-4477-05d6-08d9aa3fbc2e X-MS-TrafficTypeDiagnostic: MN2PR10MB3982: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PWzRlFwsWApONrUvjtI3ihI8smuvR12Cv33OSc1Lq9+Lt8a44rythVHhAR8kGZN2P/sGb61IL7qMQOTMqwSxRNge2dm+6oyrIY5AQZdPwNtFaW6nrtM9VaYj2EY62+A/KtVMJkYuPhh121Tfsk94YG8zMGQvEYfxQD4ojETqzZoEfHjYjJzVZIdezVEXnQ1y02F+HHNiSCBORB8hiLcVUKaWp7Jvaqj1rw2Rg5mzAoBciVVYmclVe6XdQAiSbeAOV3uRjkJDmh33Bcykmrb8MW34UvySCnF8bXs8KG1gJD0aLyKFYKwehjxjwm31mZyi5+EzBySg6rO/5WVUUmtH7BfzxTRAi+RHEScHh/pJZz4NBaQ3uXuQOCOjlrisxGEhLXQThM937kFT6E4WZP7RoT6YVtz/q5tFuda0dF0Jq0GxeyNfd24NXNinfUhdlMB2vXxKaDWf0Fx7Dn0Fd1FvzYlJ3F/QBzVlO6UVHZLhKH3Q8CFihkUUspenuNPx+NvTqs8KCZcBbTqetfqztRzT4PGbVz9aRUecKI0NmgnakoLdLeFe579/F1FGAJb53xHywX3QraK4rRNp0CWbcVfjvz10rAcSYwc4x+3Ec8OOxM2pMQ0EsNCQuA7pf1xDZEsWqaLvAsOyf1qsuRkiREa7jA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR10MB2852.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(5660300002)(6666004)(508600001)(7696005)(186003)(6916009)(66556008)(52116002)(316002)(2616005)(8676002)(2906002)(66946007)(66476007)(103116003)(6486002)(38100700002)(107886003)(86362001)(8936002)(4326008)(83380400001)(36756003)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DjMEG9kwrOZ1e/FetP7QT84/Zgrk2CFpF4QbuiI+30YPau+YVn/perUwurYNW/qMkiVo8AOmnbuP1LK++yeLabKvlRIIMrZfYKQF3CjXY2Z7p+XBGIXAXKzjDjh2VuJMTOn5EVrO46SqXA6XjB8lOrUq2EK/h4pyW9EmD1KgRGcYfZEVxu9Bt+G6BN8HgDV4QiAZBkxELXxRFvbwBI/p+K3UfcPvt4K2OSITyyis+xa3na90ysWHm0/pfVtuWBORGYMXTwqkGCVD+RYsxUdVYU35DeTLrH1VLX1RjZUT54r8IcTYrc1oEIY4ZAHaaYGbA6nfWbKVr/dz4OFQUGRYRTciYH7C0QhX6k3D/uiqDQQDqj/vcc9WSfAwoZjRCBskHz9WaZD4UNuPTMVyksTZJnlQFK2B7sZLjZy1jr++RVdugsnLs06z4M2S4OuZAFOVmITjVMv/gSNJI7ZOLTV5e1VtAsJshTwt9LbwEW3p7Ex3X7S82quWSDy0UcRoR1Sr2lKpXXBrpAXqhBkxy3ROHNlRdSaFygLt86FTD2bphOIZSGKIvP7YOPyLrEFwqa/t4z1Z2r71t/OjFAj+oJDbwZiBfZpqC+t2GxCSpsnfPveUEu91tPEqemWAgI5KIwJXOoWINOgFBq9QaDUHvyW02wX27OvrbZtmat4KKrM1Rmz8xMCAjkUG/FpQ634FhEwImXq7iB1PQrbCStZQCMn2x1PctBVmLvV8cgAWCoSSX2zcB5EwDKD2JV9Z3g8OH2o5yksi94xUKQv5dOgZOAkMZwpKfEyWua2FBJccEksdFiDvzryUclPN7ik6rclKCpy9rwnDreb6t6WUA18IXYD0thIjUGlBZjZEffV7Q8NSkktWeM7VnR1RZMcN/RQnRkNeN9PnGxbl60xqB0TOzd4t4z+7j70BH8RFFBiZIc73cUyKNYhJVc5iNB3TMiTrgn2xP8VrMOE3OTqI1hqFf51QP7V2hvFyQ50BeVAE1C0Ml1dQqU6QBv3jmD+L0nr+V1EznFGhm+jBBPuoSYohGkllvnDaciQRNpZjlm4YSUh+FPxlotWvwhAkPxhPn4xCwFfmL/w+LD9DosXNRcnk/9dMkhWQrepBWYWjCbixbdYI3ZAwa1AxMGhQtRBNazlqaZ1p9xAK6d6ynler8iyyBbW9AZq35bBfuopgjLqpjCHYiIGEJrE2RqufvAsVfvxW+SPkqTtsSlXcEbk1BL3pD+JXgRWBBmv7XossF50IDx0ytCjKJUsFEdVU5VdDKD6KZn6EPNMCjmJIo1x0CPZ/8xjv/4TRwgF+I/2dGHoxT0L3KzEMxYQuok11oGWm9SskFhaFwFTFAAvMva83XC6UmmJE34ZTxSlnLDQa873h6nmVNDOjTLwdNX2NlaJHJTjW3fu1B/y15iqHYRWVjUwITtdSQJ96NdCp+LmMxYhjJd+cPakG9gOKGKYp9tg4qT124a0uazbTpYGgbBbbLKWDA9lRSXQbG+DiJ0XgbY66Gpdo2RvleUgdM2roZ9EisifWukkYWRhODep35r/LPOVOgLJAbOQMrqCnb+89hG4MnzUCFgvLLUzTDvDvNAAvbrcECf63t0lB0YBMKIUlIQywJUUIC0zWgZO9xyq0mgltmVjkvTAI8XJLxBit1HfcTzazA1BNI56xLh11iDfFLsCgl1K0VsQRDJEG76VQsOZ6zHe1+KQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4582086b-5dea-4477-05d6-08d9aa3fbc2e X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB2852.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 03:01:36.8349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v+2R3SB8sxzQ3ueM4Xu9wrJpN9Vjgq+KXgjQlyBTVkILkm2Pm9xxE9u7hFjtVNguC794gDGhJ9C+BOzqAaAqd1oC62aEwSRfUbZuVcewfvU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3982 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10171 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111180016 X-Proofpoint-ORIG-GUID: Z3N1w__RrqtdY81uGCHvIejxEH0uIcaV X-Proofpoint-GUID: Z3N1w__RrqtdY81uGCHvIejxEH0uIcaV X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Guillermo E. Martinez via Libabigail" From: "Guillermo E. Martinez" Reply-To: "Guillermo E. Martinez" Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" * src/abg-ctf-reader.cc (read_context): Use const argument pass by reference. (create_read_context): Likewise. --- include/abg-ctf-reader.h | 8 ++++---- src/abg-ctf-reader.cc | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/abg-ctf-reader.h b/include/abg-ctf-reader.h index c0d8bb2b..56b2bf91 100644 --- a/include/abg-ctf-reader.h +++ b/include/abg-ctf-reader.h @@ -25,10 +25,10 @@ namespace ctf_reader { class read_context; -read_context *create_read_context (std::string elf_path, - ir::environment *env); -corpus_sptr read_corpus (read_context *ctxt, - elf_reader::status& status); +read_context *create_read_context(const std::string& elf_path, + ir::environment *env); +corpus_sptr read_corpus(read_context *ctxt, + elf_reader::status& status); } // end namespace ctf_reader } // end namespace abigail diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc index 0370c8aa..2c2c204d 100644 --- a/src/abg-ctf-reader.cc +++ b/src/abg-ctf-reader.cc @@ -102,7 +102,7 @@ public: /// Constructor. /// /// @param elf_path the path to the ELF file. - read_context(string elf_path, ir::environment *env) + read_context(const string& elf_path, ir::environment *env) { types_map.clear(); filename = elf_path; @@ -1060,7 +1060,8 @@ slurp_elf_info(read_context *ctxt, corpus_sptr corp) /// @param env a libabigail IR environment. read_context * -create_read_context(std::string elf_path, ir::environment *env) +create_read_context(const std::string& elf_path, + ir::environment *env) { return new read_context(elf_path, env); }