diff mbox series

abg-ir.h: add declaration of operator<< for elf_symbol::visibility

Message ID 20210707102222.725766-1-gprocida@google.com
State New
Headers
Series abg-ir.h: add declaration of operator<< for elf_symbol::visibility |

Commit Message

Giuliano Procida July 7, 2021, 10:22 a.m. UTC 
  There is a formatted output operator for elf_symbol::visibility in
abg-ir.cc. However, it had no visibile declaration and was not usable
by library users. This commit adds the declaration.

	* include/abg-ir.h (operator<<(elf_symbol::visibility): Add
	declaration.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 include/abg-ir.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Matthias Männich July 7, 2021, 12:47 p.m. UTC | #1 
On Wed, Jul 07, 2021 at 11:22:22AM +0100, Giuliano Procida wrote:
>There is a formatted output operator for elf_symbol::visibility in
>abg-ir.cc. However, it had no visibile declaration and was not usable
>by library users. This commit adds the declaration.
>
>	* include/abg-ir.h (operator<<(elf_symbol::visibility): Add
>	declaration.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>

Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias

>---
> include/abg-ir.h | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/include/abg-ir.h b/include/abg-ir.h
>index da43727f..641ce514 100644
>--- a/include/abg-ir.h
>+++ b/include/abg-ir.h
>@@ -1107,6 +1107,9 @@ operator<<(std::ostream& o, elf_symbol::type t);
> std::ostream&
> operator<<(std::ostream& o, elf_symbol::binding t);
>
>+std::ostream&
>+operator<<(std::ostream& o, elf_symbol::visibility t);
>+
> bool
> string_to_elf_symbol_type(const string&, elf_symbol::type&);
>
>-- 
>2.32.0.93.g670b81a890-goog
>
Dodji Seketeli July 16, 2021, 3:45 p.m. UTC | #2 
Matthias Maennich <maennich@google.com> a écrit:

> On Wed, Jul 07, 2021 at 11:22:22AM +0100, Giuliano Procida wrote:
>>There is a formatted output operator for elf_symbol::visibility in
>>abg-ir.cc. However, it had no visibile declaration and was not usable
>>by library users. This commit adds the declaration.
>>
>>	* include/abg-ir.h (operator<<(elf_symbol::visibility): Add
>>	declaration.
>>
>>Signed-off-by: Giuliano Procida <gprocida@google.com>
>
> Reviewed-by: Matthias Maennich <maennich@google.com>

Applied to master, thanks!

[...]

Cheers,
diff mbox series

Patch

diff --git a/include/abg-ir.h b/include/abg-ir.h
index da43727f..641ce514 100644
--- a/include/abg-ir.h
+++ b/include/abg-ir.h
@@ -1107,6 +1107,9 @@  operator<<(std::ostream& o, elf_symbol::type t);
 std::ostream&
 operator<<(std::ostream& o, elf_symbol::binding t);
 
+std::ostream&
+operator<<(std::ostream& o, elf_symbol::visibility t);
+
 bool
 string_to_elf_symbol_type(const string&, elf_symbol::type&);