From patchwork Thu Sep 3 13:22:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giuliano Procida X-Patchwork-Id: 40357 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C1D8E386102B; Thu, 3 Sep 2020 13:22:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1D8E386102B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1599139337; bh=eZOPDiVHnks+xR0jBhw8ppXTOZkGcgruU855lnxl1AU=; h=Date:In-Reply-To:References:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=iDmh10k5HrThX4nFmgRarz5OIuRTHRhxxFsTz+9JCtiXkjBU9tIlnUBZbLcC8OZqv QLN3ZIHct8y6zSK4+VtekIuLXjyMSXtljeZKsjOo29I4bAVWHw2NY/LI85DOdOSE3O sflcY820xePcKkO30leqzr4Y3uzYuzjjxQQXrL84= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-wm1-x34a.google.com (mail-wm1-x34a.google.com [IPv6:2a00:1450:4864:20::34a]) by sourceware.org (Postfix) with ESMTPS id 8F6963985408 for ; Thu, 3 Sep 2020 13:22:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8F6963985408 Received: by mail-wm1-x34a.google.com with SMTP id z1so985200wmk.1 for ; Thu, 03 Sep 2020 06:22:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=eZOPDiVHnks+xR0jBhw8ppXTOZkGcgruU855lnxl1AU=; b=PiaFsFIRtil8fKShJbMLBjuBoLCWLPjnPuWvD6s1ROuRAmzAIRoJfeGBPWM7U8Rq2+ /QFLGDeRyteXEFvt1xqT/Q4yVZbe5xZfvvl7CyORdwYnkx+nQNxNJL+hlp7tZ8Lo6xNt rmfAjSa5TnuGSJQnZb9kLCH7p4wwyR1e3n3x4dvc1Yqc3o8tFGoOh8r9E15uvwdIrklY EvzM18Yr6HWgvUbsA6oVobysuXCjBQ0lEYHxo9k8unHX6MAl+JRzXcuRDrU+RkUVcFx6 w5uOoRUAqDrIPJ8vuh23JJC7rss+n6ffDCU9Ow/txJlswxHumh/q13ge3HkGFU4uRQtN Dspw== X-Gm-Message-State: AOAM531FSiLIZKz5iG0Iy9o4RV5wQ9FjcFf1zfwKsXSj1Bz45bJ7pqaL Tzt1o8wQAyJC7jsU+w7h6R4pnOEdjcISmi8wRNrPCcva0hlbOLvtdRctJ2L6+YdOT1QqbWG5gcW 3J6a+onl9IuuE/1z5tYvgIpAwl2/XwEGI6cRoDnK4lcYNw0CRoUFXJEuW+bvKOAasqU1F01s= X-Google-Smtp-Source: ABdhPJy2K0LHc87wOV5IkW+rIFqvyBwUKEtpdjpHCOIi/RVOZe8H4kUvpCoG0wV0LE2/YvdM8zItaTqeflipxw== X-Received: from tef.lon.corp.google.com ([2a00:79e0:d:110:a6ae:11ff:fe11:4f04]) (user=gprocida job=sendgmr) by 2002:adf:b602:: with SMTP id f2mr2385613wre.186.1599139334613; Thu, 03 Sep 2020 06:22:14 -0700 (PDT) Date: Thu, 3 Sep 2020 14:22:04 +0100 In-Reply-To: <20200903132205.589136-1-gprocida@google.com> Message-Id: <20200903132205.589136-3-gprocida@google.com> Mime-Version: 1.0 References: <20200903132205.589136-1-gprocida@google.com> X-Mailer: git-send-email 2.28.0.402.g5ffc5be6b7-goog Subject: [PATCH 2/3] Fix readability-redundant-smartptr-get warnings To: libabigail@sourceware.org X-Spam-Status: No, score=-23.3 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Giuliano Procida via Libabigail From: Giuliano Procida Reply-To: Giuliano Procida Cc: maennich@google.com, kernel-team@android.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" clang-tidy's readability-redundant-smartptr-get warning is triggered when it detects a redundant "get" of various smart pointer types in boolean context. This commit fixes these warnings. * tools/kmidiff.cc (main): Remove redundant .get() when testing smart pointers. Signed-off-by: Giuliano Procida --- tools/kmidiff.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/kmidiff.cc b/tools/kmidiff.cc index 2840eb086..41584d3ae 100644 --- a/tools/kmidiff.cc +++ b/tools/kmidiff.cc @@ -416,7 +416,7 @@ main(int argc, char* argv[]) file_type ftype = guess_file_type(opts.kernel_dist_root1); if (ftype == FILE_TYPE_DIR) { - debug_info_root_dir = opts.di_root_path1.get() + debug_info_root_dir = opts.di_root_path1 ? opts.di_root_path1.get() : ""; @@ -443,7 +443,7 @@ main(int argc, char* argv[]) file_type ftype = guess_file_type(opts.kernel_dist_root2); if (ftype == FILE_TYPE_DIR) { - debug_info_root_dir = opts.di_root_path2.get() + debug_info_root_dir = opts.di_root_path2 ? opts.di_root_path2.get() : ""; group2 =