From patchwork Mon Aug 17 09:38:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giuliano Procida X-Patchwork-Id: 40273 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 341F73858D37; Mon, 17 Aug 2020 09:38:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 341F73858D37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1597657115; bh=yYBZ0dSP0lMeYngZtFK2kdKn8Jwy0lNFRbEbhLFb0rg=; h=Date:In-Reply-To:References:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=jdEVdBPgoSKNBCr42csjH2IfAw9uZYPRAfWvQO0ZMJjRr1xI5AQ7HNVNGEnmtLUR2 wAZ3V8qS2iutOac2rt/pcZ0DnCExrmfVnF7J0XsIsBNLH/6TBh14nKHjT9rHc68eav IZ/Rpy4F4aODnYZYDSoiW+gGkY927OD2lsadymGs= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-wr1-x44a.google.com (mail-wr1-x44a.google.com [IPv6:2a00:1450:4864:20::44a]) by sourceware.org (Postfix) with ESMTPS id EE5513857023 for ; Mon, 17 Aug 2020 09:38:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EE5513857023 Received: by mail-wr1-x44a.google.com with SMTP id d6so6782080wrv.23 for ; Mon, 17 Aug 2020 02:38:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=yYBZ0dSP0lMeYngZtFK2kdKn8Jwy0lNFRbEbhLFb0rg=; b=I0WNL9FDoeDGJW6A2chuKhDlRCDREFNe3Sck/Jehnpq8m2vGdrW2O7qFhCXXu7awe3 zN872CwiCYcroaZKeplI95fWFrJlj4/HBktZCZzM9Hx+po19rhpaPRWulcj7qguL/9H2 fNu1CxwNymcPJgJN0gON9cltY8ttOFrcGew6Kr4/rBd0pR3qhmTdrp0pW2mO4hNKvODD 5D7PE3c2wssnEyVUqDbP1AvmnNrSP+Bt2If24uB1BxwxBnNPQnffl7QkBjWrvALmqcrJ V/wIU6R/M9l0ScVfE0OayrLCFnQNxLPix8LYLU4+Ww8cHYMbQalbFWql3a7fR4OK6cNR IHcQ== X-Gm-Message-State: AOAM5307xbLSerIQLvvUT7NcaHg49SbHFeYpAmiC/xZltLqKoSKH8Cp1 ++1hMZHbMSN87x9vp7E+ZZJxcBEYq2JXL++b+PdLeFp3IeGaMY9WW5j8nD+FyCp8SA3isHLxlU6 fL65OhsQKwa53J+jzZvgEy6nY+VIwp9BkYS6u8kz68S88G7wZgjdd2MZJbasNud0cptLaFg8= X-Google-Smtp-Source: ABdhPJyHzGoLxsz5CwZmZUAmvMHXs9VowvDn3AIQuLNN9FuTzYy03zaiftsKlhcwVZ7tQIHHRqOY14wE77Xj3w== X-Received: by 2002:a05:6000:150:: with SMTP id r16mr14157388wrx.63.1597657111846; Mon, 17 Aug 2020 02:38:31 -0700 (PDT) Date: Mon, 17 Aug 2020 10:38:14 +0100 In-Reply-To: <20200817093819.172380-1-gprocida@google.com> Message-Id: <20200817093819.172380-3-gprocida@google.com> Mime-Version: 1.0 References: <20200817093819.172380-1-gprocida@google.com> X-Mailer: git-send-email 2.28.0.220.ged08abb693-goog Subject: [PATCH 2/7] Fix two wrongs in test suppression regex To: libabigail@sourceware.org X-Spam-Status: No, score=-22.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Giuliano Procida via Libabigail From: Giuliano Procida Reply-To: Giuliano Procida Cc: kernel-team@android.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" The suppression specification in test38-char-class-in-ini.abignore was introduced in commit 1478d9cc1c74ca3a2be89cd09aac5afcbdf818c7. Unfortunately it contains two errors. One causes the file name not to match as the string is the full path, not the base name. The other is a typo that causes the file name match not to even be attempted. The two mistakes cancel in the test, but result in a suppression specification that is broader than intended. * tests/data/test-diff-suppr/test38-char-class-in-ini.abignore: Don't anchor regex match to beginning of file name. Change "filename_regexp" to "file_name_regexp". Signed-off-by: Giuliano Procida --- tests/data/test-diff-suppr/test38-char-class-in-ini.abignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/data/test-diff-suppr/test38-char-class-in-ini.abignore b/tests/data/test-diff-suppr/test38-char-class-in-ini.abignore index 07f3f91f8..e96240cd4 100644 --- a/tests/data/test-diff-suppr/test38-char-class-in-ini.abignore +++ b/tests/data/test-diff-suppr/test38-char-class-in-ini.abignore @@ -1,4 +1,4 @@ [suppress_function] - filename_regexp = ^test38-char-class-in-ini-v[[:digit:]].* + file_name_regexp = test38-char-class-in-ini-v[[:digit:]].* symbol_name_regexp = bar change_kind = added-function