[RFC,0/1] Fix decl_base comparison

Message ID 20200722110736.2550361-1-gprocida@google.com


Giuliano Procida July 22, 2020, 11:07 a.m. UTC
  Hi reviewers.

This commit fixes the slow path decl_base comparison, with the
assumption that decl_names_equal has been fixed as per another commit,
"Make decl_names_equal more accurate".

This is an RFC patch because there may be more to address here. I've
added some TODOs and referred to them in the commit message for the
patch. I'm hoping for review comments particularly directed at those

To be clear, disabling the fast path in the decl_base comparison
changes behaviour, suggesting that the fast path is buggy as well.


Giuliano Procida (1):
  Fix decl_base comparison function

 src/abg-ir.cc                                 |  25 +-
 .../PR25058-liblttng-ctl-report-1.txt         |   4 -
 .../data/test-diff-filter/test33-report-0.txt |   3 -
 ....el7.x86_64-multiple-sym-vers-report-0.txt |   2 +-
 ...l7.x86_64-0.12.8-1.el7.x86_64-report-2.txt |   2 +-
 .../test9-pr18818-clang.so.abi                | 236 ++++++++----------
 6 files changed, 127 insertions(+), 145 deletions(-)