diff mbox series

abg-ir.cc: Fix incorrect pop of compared types.

Message ID 20200715081746.2079442-1-gprocida@google.com
State Committed, archived
Headers
Series abg-ir.cc: Fix incorrect pop of compared types. |

Commit Message

Giuliano Procida July 15, 2020, 8:17 a.m. UTC 
  In one case there is an attempt to "pop" an in-progress type
comparison which hasn't actually happened.

This commit fixes this.

	* src/abg-ir.cc (equals): In the class_or_union overload,
	replace one instance of RETURN(false) with return false.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 src/abg-ir.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dodji Seketeli July 28, 2020, 1:32 p.m. UTC | #1 
Giuliano Procida <gprocida@google.com> a écrit:

> In one case there is an attempt to "pop" an in-progress type
> comparison which hasn't actually happened.
>
> This commit fixes this.
>
> 	* src/abg-ir.cc (equals): In the class_or_union overload,
> 	replace one instance of RETURN(false) with return false.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>

Good catch!

Applied to master, thanks!

Cheers,
diff mbox series

Patch

diff --git a/src/abg-ir.cc b/src/abg-ir.cc
index 757605f8..6040e1d7 100644
--- a/src/abg-ir.cc
+++ b/src/abg-ir.cc
@@ -19380,7 +19380,7 @@  equals(const class_or_union& l, const class_or_union& r, change_kind* k)
     {
       if (k)
 	*k |= LOCAL_TYPE_CHANGE_KIND;
-      RETURN(false);
+      return false;
     }
 
   if (types_defined_same_linux_kernel_corpus_public(l, r))