From patchwork Thu Jul 9 18:51:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giuliano Procida X-Patchwork-Id: 40010 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C1FFF3844047; Thu, 9 Jul 2020 18:51:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1FFF3844047 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1594320705; bh=Wj+C7DIuoNM+HEFfOJSbkB5AI3GVWwG+FPT3OHkJ8V0=; h=Date:In-Reply-To:References:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=Za1YtoZvnwvwkv/7EjF0XglSyaEQZ8sHKmJM1UuLKw2ed7DfUq13A9/Njqw3Avj/x WiZFyG5B/ZFORR4mtwQXrLCpfzikYEAQ8GiSGzkwN+0JO7b6Fca66evAmgm1tPiyci PBCR+N8GNwGK6jsxuyHO2pkUoFMPB+UM2wq5UjQQ= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-wm1-x349.google.com (mail-wm1-x349.google.com [IPv6:2a00:1450:4864:20::349]) by sourceware.org (Postfix) with ESMTPS id E84D13844047 for ; Thu, 9 Jul 2020 18:51:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E84D13844047 Received: by mail-wm1-x349.google.com with SMTP id 65so3077085wmd.8 for ; Thu, 09 Jul 2020 11:51:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=Wj+C7DIuoNM+HEFfOJSbkB5AI3GVWwG+FPT3OHkJ8V0=; b=cytSOA5NVzOSWZ4OEtbNUzS8/x2yJR/bcOELysw6IYuXX8Lnd/+aXJuRaTSje9YgOe zREaDgubCEmsBY8i4fVYoCDZDlfjGS3ipk3/RfCRQoXtUjDO7KV2nWp//3tHq1mQf8T8 uOYGkdstPQKh//qsQlS+y7fDsB4yr1HNDLPNI7mP2khfWYDS4vevN1StUIQ1Wjj/ZdbQ wGhWXcFrDWWTObRJzwlLXCG/ZRkCc16X18Fkif48jY74+1mNfJpCYEJKUzn2p/5r0RhF pVsy2Kx/tTPMtCnW9WfHpd2jbwJeAy1f+htLMmxoscLnqvHPQYA/7GzlPSYj7wmLIF2c 4q0A== X-Gm-Message-State: AOAM5315akMI43zYcdEUYzWrRJPjDBuUAE0yh7fGTacqxjnKqq7uaWKP apo4QsOGRDjqyqFfIKFSR+H7EBdHlUkaAFhuejcOsHWwP1raBye1HOi/HqE+c/q7RlIfndhgE3O gjsgySULNMDM4QbAt6XEOQ3q5IWXZMsenAG5GZsr7T5ZAxfqIAQ0ITwEwUXeaJSJQ/ZKBD5A= X-Google-Smtp-Source: ABdhPJztJKdB/6tW0Ilu6i2a9kAVgFzRPM94lxauLsJQhwwcPd1A6MoOePMgnOisnzyBPDDpzoEcSwL8f9w+Sw== X-Received: by 2002:a5d:6a01:: with SMTP id m1mr68793946wru.115.1594320699884; Thu, 09 Jul 2020 11:51:39 -0700 (PDT) Date: Thu, 9 Jul 2020 19:51:34 +0100 In-Reply-To: <20200709182250.1677238-4-gprocida@google.com> Message-Id: <20200709185134.1686136-1-gprocida@google.com> Mime-Version: 1.0 References: <20200709182250.1677238-4-gprocida@google.com> X-Mailer: git-send-email 2.27.0.383.g050319c2ae-goog Subject: [PATCH v2 3/3] Enable Clang's -Werror-overloaded-virtual. To: libabigail@sourceware.org X-Spam-Status: No, score=-23.5 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Giuliano Procida via Libabigail From: Giuliano Procida Reply-To: Giuliano Procida Cc: maennich@google.com, kernel-team@android.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" Ths warning is no longer triggered and can be reenabled. * configure.ac: Remove the special clause that disabled -Werror-overloaded-virtual for Clang builds. Signed-off-by: Giuliano Procida Reviewed-by: Matthias Maennich --- configure.ac | 6 ------ 1 file changed, 6 deletions(-) diff --git a/configure.ac b/configure.ac index 225ac38f..904a726e 100644 --- a/configure.ac +++ b/configure.ac @@ -646,12 +646,6 @@ if test x$ENABLE_UBSAN = xyes; then CXXFLAGS="$CXXFLAGS -fsanitize=undefined" fi -dnl Check if we compile with clang and set flags accordingly -dnl TODO: fix that warning (spoiler: not trivial) -if `$CXX -v 2>&1 | grep 'clang version' > /dev/null 2>&1`; then - CXXFLAGS="$CXXFLAGS -Wno-error-overloaded-virtual" -fi - dnl Check if several decls and constant are defined in dependant dnl libraries HAS_EM_AARCH64=no