[v2,3/3] Enable Clang's -Werror-overloaded-virtual.
Commit Message
Ths warning is no longer triggered and can be reenabled.
* configure.ac: Remove the special clause that disabled
-Werror-overloaded-virtual for Clang builds.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
configure.ac | 6 ------
1 file changed, 6 deletions(-)
Comments
On Thu, Jul 09, 2020 at 07:51:34PM +0100, Giuliano Procida wrote:
>Ths warning is no longer triggered and can be reenabled.
>
> * configure.ac: Remove the special clause that disabled
> -Werror-overloaded-virtual for Clang builds.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>
Reviewed-by: Matthias Maennich <maennich@google.com>
Cheers,
Matthias
>---
> configure.ac | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/configure.ac b/configure.ac
>index 225ac38f..904a726e 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -646,12 +646,6 @@ if test x$ENABLE_UBSAN = xyes; then
> CXXFLAGS="$CXXFLAGS -fsanitize=undefined"
> fi
>
>-dnl Check if we compile with clang and set flags accordingly
>-dnl TODO: fix that warning (spoiler: not trivial)
>-if `$CXX -v 2>&1 | grep 'clang version' > /dev/null 2>&1`; then
>- CXXFLAGS="$CXXFLAGS -Wno-error-overloaded-virtual"
>-fi
>-
> dnl Check if several decls and constant are defined in dependant
> dnl libraries
> HAS_EM_AARCH64=no
>--
>2.27.0.383.g050319c2ae-goog
>
Giuliano Procida <gprocida@google.com> a écrit:
> Ths warning is no longer triggered and can be reenabled.
>
> * configure.ac: Remove the special clause that disabled
> -Werror-overloaded-virtual for Clang builds.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
Cheers,
@@ -646,12 +646,6 @@ if test x$ENABLE_UBSAN = xyes; then
CXXFLAGS="$CXXFLAGS -fsanitize=undefined"
fi
-dnl Check if we compile with clang and set flags accordingly
-dnl TODO: fix that warning (spoiler: not trivial)
-if `$CXX -v 2>&1 | grep 'clang version' > /dev/null 2>&1`; then
- CXXFLAGS="$CXXFLAGS -Wno-error-overloaded-virtual"
-fi
-
dnl Check if several decls and constant are defined in dependant
dnl libraries
HAS_EM_AARCH64=no