From patchwork Thu Jul 9 13:14:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giuliano Procida X-Patchwork-Id: 39994 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1EFB33846417; Thu, 9 Jul 2020 13:14:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1EFB33846417 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1594300482; bh=nRl53m2BqrKBD4T4BSIupl8xojK8qZgECGw34WhruOo=; h=Date:In-Reply-To:References:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=GDc9gBUPv18akgJT9tRrYepLwRuMTQCXni9Tn2mL/7AlNlpC+iNt6lKvwX5BrZ2Pi Wd1CC2PzR31or253ApFcPezDwtEsmD3CcXzG/O2qppgFjiGh7QCNR9w1M3lFLddOQh dKtvaIvruL8XRPbfHKDpC8rclfUGh+96WGkXdqvY= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-qv1-xf4a.google.com (mail-qv1-xf4a.google.com [IPv6:2607:f8b0:4864:20::f4a]) by sourceware.org (Postfix) with ESMTPS id 306F93846417 for ; Thu, 9 Jul 2020 13:14:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 306F93846417 Received: by mail-qv1-xf4a.google.com with SMTP id 59so1342574qvb.4 for ; Thu, 09 Jul 2020 06:14:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=nRl53m2BqrKBD4T4BSIupl8xojK8qZgECGw34WhruOo=; b=cq1eBTQpTvnFDRYPx6zUK7/GfrXRgkND6jjb5pjOoLSKLEP2gTeSzHDmjJ8xM8tDnH 6lTaESpDK8JJYqkRr04FHZFd41z1R0gEQ5vqjamLf9wX9U+6p1bgPsoT6BrgOUiek83l QitdVjCm0PUUHg+WU50YXPJd8PBzrk6t9X7WY+JaBaSjxBM+oIkyXIMqZqh9gZR9m6Ir NwVXYvquKV/a8ixkL1RExgWQHgCIzvxyz9My+vLHmYd1J9PmuQ/lptiWhEXtGmvS5zHH LaD3MU9367IIb+yKeHsoktb0us3PIrl1gv+/le41x6xmxhSCe7zZ/ffraeT3AN85JpVt XKhg== X-Gm-Message-State: AOAM532zLdt4e74SKoWNFIrScLP2gwBNLgUXUSbfbYowp0/E9tWcCw91 EPw4r6zpSH7vQ0v+0nROL0CRFuI7WRnM8VaQ9423DrXNtgxdn10MVDvD61Ix65I9cr/nVmm7VC5 A9+DyXAGv69kZS6uVozZVFvKFEnXCq8tlbXwhXqnM600x1TJytHjfNUwkX0AuEGtbUQykQow= X-Google-Smtp-Source: ABdhPJz0XIB8/xzqKiotlzpILVdkWMuCQDRWiiXzCNYXxuxsCiTQmIBI8SH2PFzHY12QDBkg+5CGYKsk6xFkbA== X-Received: by 2002:ad4:4903:: with SMTP id bh3mr62858587qvb.17.1594300479644; Thu, 09 Jul 2020 06:14:39 -0700 (PDT) Date: Thu, 9 Jul 2020 14:14:28 +0100 In-Reply-To: <20200709131429.1366074-1-gprocida@google.com> Message-Id: <20200709131429.1366074-3-gprocida@google.com> Mime-Version: 1.0 References: <20200709131429.1366074-1-gprocida@google.com> X-Mailer: git-send-email 2.27.0.383.g050319c2ae-goog Subject: [PATCH 2/3] Remove unused is_reference_or_pointer_diff. To: libabigail@sourceware.org X-Spam-Status: No, score=-22.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Giuliano Procida via Libabigail From: Giuliano Procida Reply-To: Giuliano Procida Cc: maennich@google.com, kernel-team@android.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" The function is_reference_or_pointer_diff was added in commit 85929105 Fix redundancy marking for change of types used directly and was updated to peel typedefs as a first step in ef9d20c9 Fix redundancy detection through fn ptr and typedef paths which, however, also made it obsolete. This commit removes the function's declaration and definition. There are no functional changes. * include/abg-comparison.h (is_reference_or_pointer_diff): Drop function declaration. * src/abg-comparison.cc (is_reference_or_pointer_diff): Drop function definition. Signed-off-by: Giuliano Procida Reviewed-by: Matthias Maennich --- include/abg-comparison.h | 2 -- src/abg-comparison.cc | 15 --------------- 2 files changed, 17 deletions(-) diff --git a/include/abg-comparison.h b/include/abg-comparison.h index 84258209..c4eb5925 100644 --- a/include/abg-comparison.h +++ b/include/abg-comparison.h @@ -2852,8 +2852,6 @@ is_reference_diff(const diff* diff); const qualified_type_diff* is_qualified_type_diff(const diff* diff); -bool -is_reference_or_pointer_diff(const diff* diff); const fn_parm_diff* is_fn_parm_diff(const diff* diff); diff --git a/src/abg-comparison.cc b/src/abg-comparison.cc index d0f1d21b..0dbe2635 100644 --- a/src/abg-comparison.cc +++ b/src/abg-comparison.cc @@ -788,21 +788,6 @@ const qualified_type_diff* is_qualified_type_diff(const diff* diff) {return dynamic_cast(diff);} -/// Test if a diff node is either a reference diff node or a pointer -/// diff node. Note that this function also works on diffs of -/// typedefs of reference or pointer. -/// -/// @param diff the diff node to test. -/// -/// @return true iff @p diff is either reference diff node or a -/// pointer diff node. -bool -is_reference_or_pointer_diff(const diff* diff) -{ - diff = peel_typedef_diff(diff); - return is_reference_diff(diff) || is_pointer_diff(diff); -} - /// Test if a diff node is a reference or pointer diff node to a /// change that is neither basic type change nor distinct type change. ///