diff mbox series

[1/3] abg-comparison.h: Remove stray declaration

Message ID 20200709131429.1366074-2-gprocida@google.com
State Committed, archived
Headers
Series Tidy some peeling code |

Commit Message

Giuliano Procida July 9, 2020, 1:14 p.m. UTC 
  The functon is_reference_or_pointer_diff_to_non_basic_distinct_types
was declared in

ef9d20c9 Fix redundancy detection through fn ptr and typedef paths

but never defined. This commit removes it. There are no functional
changes.

	* include/abg-comparison
	(is_reference_or_pointer_diff_to_non_basic_distinct_types):
	Remove stray declaration.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 include/abg-comparison.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Matthias Männich July 10, 2020, 4:16 p.m. UTC | #1 
On Thu, Jul 09, 2020 at 02:14:27PM +0100, Giuliano Procida wrote:
>The functon is_reference_or_pointer_diff_to_non_basic_distinct_types
>was declared in
>
>ef9d20c9 Fix redundancy detection through fn ptr and typedef paths
>
>but never defined. This commit removes it. There are no functional
>changes.
>
>	* include/abg-comparison
>	(is_reference_or_pointer_diff_to_non_basic_distinct_types):
>	Remove stray declaration.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>

Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias

>---
> include/abg-comparison.h | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/include/abg-comparison.h b/include/abg-comparison.h
>index d107bf9f..84258209 100644
>--- a/include/abg-comparison.h
>+++ b/include/abg-comparison.h
>@@ -2855,9 +2855,6 @@ is_qualified_type_diff(const diff* diff);
> bool
> is_reference_or_pointer_diff(const diff* diff);
>
>-bool
>-is_reference_or_pointer_diff_to_non_basic_distinct_types(const diff* diff);
>-
> const fn_parm_diff*
> is_fn_parm_diff(const diff* diff);
>
>-- 
>2.27.0.383.g050319c2ae-goog
>
Dodji Seketeli July 27, 2020, 1:27 p.m. UTC | #2 
Giuliano Procida <gprocida@google.com> a écrit:

> The functon is_reference_or_pointer_diff_to_non_basic_distinct_types
> was declared in
>
> ef9d20c9 Fix redundancy detection through fn ptr and typedef paths
>
> but never defined. This commit removes it. There are no functional
> changes.
>
> 	* include/abg-comparison
> 	(is_reference_or_pointer_diff_to_non_basic_distinct_types):
> 	Remove stray declaration.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>

Applied to master, thanks!

Cheers,
diff mbox series

Patch

diff --git a/include/abg-comparison.h b/include/abg-comparison.h
index d107bf9f..84258209 100644
--- a/include/abg-comparison.h
+++ b/include/abg-comparison.h
@@ -2855,9 +2855,6 @@  is_qualified_type_diff(const diff* diff);
 bool
 is_reference_or_pointer_diff(const diff* diff);
 
-bool
-is_reference_or_pointer_diff_to_non_basic_distinct_types(const diff* diff);
-
 const fn_parm_diff*
 is_fn_parm_diff(const diff* diff);