diff mbox series

Tidy get_pretty_representation qualified_name.

Message ID 20200505181700.239417-1-gprocida@google.com
State Committed
Headers show
Series Tidy get_pretty_representation qualified_name. | expand

Commit Message

Giuliano Procida May 5, 2020, 6:17 p.m. UTC
The virtual function get_pretty_representation exists in many
classes (derived from type_or_decl_base). It takes a qualified_name
argumenta and this is defaulted to true in all but one case which
seems to be an oversight.

This commit changes this for no better reason than consistency.

	* include/abg-ir.h (type_decl::get_pretty_representation)
	Change default for qualified_name parameter to true.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 include/abg-ir.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matthias Maennich May 13, 2020, 8:04 a.m. UTC | #1
On Tue, May 05, 2020 at 07:17:00PM +0100, Android Kernel Team wrote:
>The virtual function get_pretty_representation exists in many
>classes (derived from type_or_decl_base). It takes a qualified_name
>argumenta and this is defaulted to true in all but one case which
>seems to be an oversight.
>
>This commit changes this for no better reason than consistency.
>
>	* include/abg-ir.h (type_decl::get_pretty_representation)
>	Change default for qualified_name parameter to true.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>

Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias

>---
> include/abg-ir.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/abg-ir.h b/include/abg-ir.h
>index fda10de5..edfea863 100644
>--- a/include/abg-ir.h
>+++ b/include/abg-ir.h
>@@ -1920,7 +1920,7 @@ public:
>
>   virtual string
>   get_pretty_representation(bool internal = false,
>-			    bool qualified_name = false) const;
>+			    bool qualified_name = true) const;
>
>   virtual bool
>   traverse(ir_node_visitor&);
>-- 
>2.26.2.526.g744177e7f7-goog
>
>
Dodji Seketeli May 14, 2020, 2:34 p.m. UTC | #2
Giuliano Procida <gprocida@google.com> a écrit:

> The virtual function get_pretty_representation exists in many
> classes (derived from type_or_decl_base). It takes a qualified_name
> argumenta and this is defaulted to true in all but one case which
> seems to be an oversight.
>
> This commit changes this for no better reason than consistency.
>
> 	* include/abg-ir.h (type_decl::get_pretty_representation)
> 	Change default for qualified_name parameter to true.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Acked-by: Dodji Seketeli <dodji@seketeli.org>

Applied to master, thanks!

Cheers,
diff mbox series

Patch

diff --git a/include/abg-ir.h b/include/abg-ir.h
index fda10de5..edfea863 100644
--- a/include/abg-ir.h
+++ b/include/abg-ir.h
@@ -1920,7 +1920,7 @@  public:
 
   virtual string
   get_pretty_representation(bool internal = false,
-			    bool qualified_name = false) const;
+			    bool qualified_name = true) const;
 
   virtual bool
   traverse(ir_node_visitor&);