abg-reader.cc: Remove key_replacement_type_map.
Commit Message
This patch removes this unused function.
* src/abg-reader.cc (key_replacement_type_map): Drop unused
function.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
src/abg-reader.cc | 24 ------------------------
1 file changed, 24 deletions(-)
Comments
On Tue, May 05, 2020 at 07:14:35PM +0100, Android Kernel Team wrote:
>This patch removes this unused function.
>
> * src/abg-reader.cc (key_replacement_type_map): Drop unused
> function.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>
Reviewed-by: Matthias Maennich <maennich@google.com>
Cheers,
Matthias
>---
> src/abg-reader.cc | 24 ------------------------
> 1 file changed, 24 deletions(-)
>
>diff --git a/src/abg-reader.cc b/src/abg-reader.cc
>index d7c48919..5583a31c 100644
>--- a/src/abg-reader.cc
>+++ b/src/abg-reader.cc
>@@ -571,30 +571,6 @@ public:
> return true;
> }
>
>- /// Associate an ID with a type.
>- ///
>- /// If ID is an id for an existing type, this function replaces the
>- /// exising type with the new DEFINITION type passe in argument.
>- ///
>- /// @param definition the type to associate witht he ID.
>- ///
>- /// @param id the ID to associate to the type.
>- ///
>- /// @return true upon successful completion, false otherwise. Note
>- /// that this returns false if the was already associate to an ID
>- /// before.
>- bool
>- key_replacement_of_type_decl(shared_ptr<type_base> definition,
>- const string& id)
>- {
>- const_types_map_it i = m_types_map.find(id);
>- if (i != m_types_map.end())
>- m_types_map.erase(i);
>- key_type_decl(definition, id);
>-
>- return true;
>- }
>-
> /// Associate an ID to a function template.
> ///
> /// @param fn_tmpl_decl the function template to consider.
>--
>2.26.2.526.g744177e7f7-goog
>
>
Giuliano Procida <gprocida@google.com> a écrit:
> This patch removes this unused function.
>
> * src/abg-reader.cc (key_replacement_type_map): Drop unused
> function.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Acked-by: Dodji Seketeli <dodji@seketeli.org>
Applied to master, thanks!
@@ -571,30 +571,6 @@ public:
return true;
}
- /// Associate an ID with a type.
- ///
- /// If ID is an id for an existing type, this function replaces the
- /// exising type with the new DEFINITION type passe in argument.
- ///
- /// @param definition the type to associate witht he ID.
- ///
- /// @param id the ID to associate to the type.
- ///
- /// @return true upon successful completion, false otherwise. Note
- /// that this returns false if the was already associate to an ID
- /// before.
- bool
- key_replacement_of_type_decl(shared_ptr<type_base> definition,
- const string& id)
- {
- const_types_map_it i = m_types_map.find(id);
- if (i != m_types_map.end())
- m_types_map.erase(i);
- key_type_decl(definition, id);
-
- return true;
- }
-
/// Associate an ID to a function template.
///
/// @param fn_tmpl_decl the function template to consider.