[v3,06/21] diff suppression: Fix handling of change kinds.

  When parsing suppression specifications, libabigail attempts to detect
and ignore suppressions that are empty and so would match everything
in their category by default.

Unfortunately, with the way the parser currently works, these checks
have to be against an exhaustive list of fields that matter, rather
than by listing the fields that don't (like label). They are fragile
in the face of changes that add new fields.

Two of the short-cut checks are in fact buggy, missing out the
change_kind field. One of the checks also risks a null pointer
dereference as it doesn't actually trigger a return from the function.

This patch eliminates (rather than fixes up) this short-cutting on the
grounds that it is a maintenance burden and inconsistent behaviour.
Users should be able to do this:

[suppress_variable]
  label = Suppress all changes to variables

We could reinstate the logic when the code has global knowledge of
which fields are present and which have no suppression (restriction)
semantics, or perhaps just emit a warning message to the user if they
have supplied a completely empty (no label even) specification.

The patch also corrects 4 affected test cases to reflect that
suppression is actually happening (according to change_kind).

	* src/abg-suppression.cc (read_type_suppression): Remove
	short-circuiting of useless suppressions.
	(read_function_suppression): Ditto.
	(read_variable_suppression: Ditto.
	(read_file_suppression): Ditto.
	tests/data/test-diff-suppr/test15-suppr-added-fn-report-5.txt:
	Fix test - something is actually suppressed.
	* tests/data/test-diff-suppr/test16-suppr-removed-fn-report-5.txt:
	Ditto.
	* tests/data/test-diff-suppr/test17-suppr-added-var-report-5.txt:
	Ditto.
	* tests/data/test-diff-suppr/test18-suppr-removed-var-report-5.txt:
	Ditto.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 src/abg-suppression.cc                        | 91 +++++--------------
 .../test15-suppr-added-fn-report-5.txt        |  6 +-
 .../test16-suppr-removed-fn-report-5.txt      | 15 +--
 .../test17-suppr-added-var-report-5.txt       | 15 +--
 .../test18-suppr-removed-var-report-5.txt     | 15 +--
 5 files changed, 26 insertions(+), 116 deletions(-)

Message ID	20200424092132.150547-7-gprocida@google.com
State	Superseded
Headers	From: gprocida@google.com (Giuliano Procida) Date: Fri, 24 Apr 2020 10:21:17 +0100 Subject: [PATCH v3 06/21] diff suppression: Fix handling of change kinds. In-Reply-To: <20200424092132.150547-1-gprocida@google.com> References: <20200423154441.170531-1-gprocida@google.com> <20200424092132.150547-1-gprocida@google.com> Message-ID: <20200424092132.150547-7-gprocida@google.com>
Series	Simplify regex and suppression parsing. \| [v3,00/21] Simplify regex and suppression parsing. [v3,01/21] Move regex definitions to own files. [v3,02/21] Move libxml bits out of abg-sptr-utils.h. [v3,03/21] Simplify generation of symbol whitelist regex. [v3,04/21] Escape names used in symbol whitelisting regex. [v3,05/21] abg-suppression.cc: More uniform variable naming. [v3,06/21] diff suppression: Fix handling of change kinds. [v3,07/21] Add POSIX regex wrapper functions. [v3,08/21] Use regex::compile wrapper instead of regcomp. [v3,09/21] Use regex::match wrapper instead of regexec. [v3,10/21] Refactor read_parameter_spec_from_string logic. [v3,11/21] Compile suppression regexes earlier. [v3,12/21] Reduce direct access to suppression priv_ members. [v3,13/21] Move match methods from priv to suppression_base. [v3,14/21] Remove suppression types' priv class methods. [v3,15/21] abg-suppression.cc: More consistent regex matching. [v3,16/21] abg-tools-utils.cc: Assert generated regexes OK. [v3,17/21] Refactor suppression property string parsing. [v3,18/21] Refactor suppression property regex parsing. [v3,19/21] Warn if user-supplied regexes fail to compile. [v3,20/21] Default construct suppression types. [v3,21/21] Remove unused suppression type priv constructors.

[v3,06/21] diff suppression: Fix handling of change kinds.

Commit Message

Patch