diff mbox series

[v3,21/21] Remove unused suppression type priv constructors.

Message ID 20200424092132.150547-22-gprocida@google.com
State Superseded
Headers show
Series Simplify regex and suppression parsing. | expand

Commit Message

Giuliano Procida April 24, 2020, 9:21 a.m. UTC
Following on from the previous commit, many constructors for the
various priv types are now unused. This patch drops them.

There are no behavioural changes.

	* src/abg-suppression-priv.h (suppression_base::priv) Drop all
	but default constructor.
	(function_suppression::parameter_spec::priv): Drop all but
	3-argument constructor. (function_suppression::priv): Drop all
	but default constructor. (type_suppression::priv): Drop all
	but default constructor.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 src/abg-suppression-priv.h | 60 --------------------------------------
 1 file changed, 60 deletions(-)

Comments

Matthias Maennich April 27, 2020, 3:41 p.m. UTC | #1
On Fri, Apr 24, 2020 at 10:21:32AM +0100, Giuliano Procida wrote:
>Following on from the previous commit, many constructors for the
>various priv types are now unused. This patch drops them.
>
>There are no behavioural changes.
>
>	* src/abg-suppression-priv.h (suppression_base::priv) Drop all
>	but default constructor.
>	(function_suppression::parameter_spec::priv): Drop all but
>	3-argument constructor. (function_suppression::priv): Drop all
>	but default constructor. (type_suppression::priv): Drop all
>	but default constructor.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>

Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias

>---
> src/abg-suppression-priv.h | 60 --------------------------------------
> 1 file changed, 60 deletions(-)
>
>diff --git a/src/abg-suppression-priv.h b/src/abg-suppression-priv.h
>index 7f98fb08..97c163fe 100644
>--- a/src/abg-suppression-priv.h
>+++ b/src/abg-suppression-priv.h
>@@ -58,22 +58,6 @@ public:
>       drops_artifact_()
>   {}
>
>-  priv(const string& label)
>-    : is_artificial_(),
>-      drops_artifact_(),
>-      label_(label)
>-  {}
>-
>-  priv(const string& label,
>-       const regex::regex_t_sptr& file_name_regex,
>-       const regex::regex_t_sptr& file_name_not_regex)
>-    : is_artificial_(),
>-      drops_artifact_(),
>-      label_(label),
>-      file_name_regex_(file_name_regex),
>-      file_name_not_regex_(file_name_not_regex)
>-  {}
>-
>   friend class suppression_base;
> }; // end class suppression_base::priv
>
>@@ -90,14 +74,6 @@ class function_suppression::parameter_spec::priv
>   string				type_name_;
>   regex::regex_t_sptr			type_name_regex_;
>
>-  priv()
>-    : index_()
>-  {}
>-
>-  priv(size_t i, const string& tn)
>-    : index_(i), type_name_(tn)
>-  {}
>-
>   priv(size_t i, const string& tn, const regex::regex_t_sptr& tn_regex)
>     : index_(i), type_name_(tn), type_name_regex_(tn_regex)
>   {}
>@@ -128,28 +104,6 @@ struct function_suppression::priv
>     change_kind_(ALL_CHANGE_KIND),
>     allow_other_aliases_(true)
>   {}
>-
>-  priv(const string&			name,
>-       const regex::regex_t_sptr&	name_regex,
>-       const string&			return_type_name,
>-       const regex::regex_t_sptr&	return_type_regex,
>-       const parameter_specs_type&	parm_specs,
>-       const string&			symbol_name,
>-       const regex::regex_t_sptr&	symbol_name_regex,
>-       const string&			symbol_version,
>-       const regex::regex_t_sptr&	symbol_version_regex)
>-    : change_kind_(ALL_CHANGE_KIND),
>-      name_(name),
>-      name_regex_(name_regex),
>-      return_type_name_(return_type_name),
>-      return_type_regex_(return_type_regex),
>-      parm_specs_(parm_specs),
>-      symbol_name_(symbol_name),
>-      symbol_name_regex_(symbol_name_regex),
>-      symbol_version_(symbol_version),
>-      symbol_version_regex_(symbol_version_regex),
>-      allow_other_aliases_(true)
>-  {}
> }; // end class function_suppression::priv
>
> bool
>@@ -293,20 +247,6 @@ public:
>       reach_kind_(DIRECT_REACH_KIND)
>   {}
>
>-  priv(const regex::regex_t_sptr&	type_name_regexp,
>-       const string&			type_name,
>-       bool				consider_type_kind,
>-       type_suppression::type_kind	type_kind,
>-       bool				consider_reach_kind,
>-       type_suppression::reach_kind	reach_kind)
>-    : type_name_regex_(type_name_regexp),
>-      type_name_(type_name),
>-      consider_type_kind_(consider_type_kind),
>-      type_kind_(type_kind),
>-      consider_reach_kind_(consider_reach_kind),
>-      reach_kind_(reach_kind)
>-  {}
>-
>   friend class type_suppression;
> }; // class type_suppression::priv
>
>-- 
>2.26.2.303.gf8c07b1a785-goog
>
diff mbox series

Patch

diff --git a/src/abg-suppression-priv.h b/src/abg-suppression-priv.h
index 7f98fb08..97c163fe 100644
--- a/src/abg-suppression-priv.h
+++ b/src/abg-suppression-priv.h
@@ -58,22 +58,6 @@  public:
       drops_artifact_()
   {}
 
-  priv(const string& label)
-    : is_artificial_(),
-      drops_artifact_(),
-      label_(label)
-  {}
-
-  priv(const string& label,
-       const regex::regex_t_sptr& file_name_regex,
-       const regex::regex_t_sptr& file_name_not_regex)
-    : is_artificial_(),
-      drops_artifact_(),
-      label_(label),
-      file_name_regex_(file_name_regex),
-      file_name_not_regex_(file_name_not_regex)
-  {}
-
   friend class suppression_base;
 }; // end class suppression_base::priv
 
@@ -90,14 +74,6 @@  class function_suppression::parameter_spec::priv
   string				type_name_;
   regex::regex_t_sptr			type_name_regex_;
 
-  priv()
-    : index_()
-  {}
-
-  priv(size_t i, const string& tn)
-    : index_(i), type_name_(tn)
-  {}
-
   priv(size_t i, const string& tn, const regex::regex_t_sptr& tn_regex)
     : index_(i), type_name_(tn), type_name_regex_(tn_regex)
   {}
@@ -128,28 +104,6 @@  struct function_suppression::priv
     change_kind_(ALL_CHANGE_KIND),
     allow_other_aliases_(true)
   {}
-
-  priv(const string&			name,
-       const regex::regex_t_sptr&	name_regex,
-       const string&			return_type_name,
-       const regex::regex_t_sptr&	return_type_regex,
-       const parameter_specs_type&	parm_specs,
-       const string&			symbol_name,
-       const regex::regex_t_sptr&	symbol_name_regex,
-       const string&			symbol_version,
-       const regex::regex_t_sptr&	symbol_version_regex)
-    : change_kind_(ALL_CHANGE_KIND),
-      name_(name),
-      name_regex_(name_regex),
-      return_type_name_(return_type_name),
-      return_type_regex_(return_type_regex),
-      parm_specs_(parm_specs),
-      symbol_name_(symbol_name),
-      symbol_name_regex_(symbol_name_regex),
-      symbol_version_(symbol_version),
-      symbol_version_regex_(symbol_version_regex),
-      allow_other_aliases_(true)
-  {}
 }; // end class function_suppression::priv
 
 bool
@@ -293,20 +247,6 @@  public:
       reach_kind_(DIRECT_REACH_KIND)
   {}
 
-  priv(const regex::regex_t_sptr&	type_name_regexp,
-       const string&			type_name,
-       bool				consider_type_kind,
-       type_suppression::type_kind	type_kind,
-       bool				consider_reach_kind,
-       type_suppression::reach_kind	reach_kind)
-    : type_name_regex_(type_name_regexp),
-      type_name_(type_name),
-      consider_type_kind_(consider_type_kind),
-      type_kind_(type_kind),
-      consider_reach_kind_(consider_reach_kind),
-      reach_kind_(reach_kind)
-  {}
-
   friend class type_suppression;
 }; // class type_suppression::priv