diff mbox series

[3/3,v2] test24-soname-suppr*txt: Fix suppression syntax.

Message ID 20200420172338.68047-1-gprocida@google.com
State Committed
Headers show
Series None | expand

Commit Message

Giuliano Procida April 20, 2020, 5:23 p.m. UTC
The property name "reached_through" should have been
"accessed_through" and the property value "reference_or_pointer"
should have been "reference-or-pointer".

This patch fixes these issues.

	* tests/data/test-diff-suppr/test24-soname-suppr-0.txt: Fix
        typo, change "reached_through" to "accessed_through".
	* tests/data/test-diff-suppr/test24-soname-suppr-1.txt: Ditto.
	* tests/data/test-diff-suppr/test24-soname-suppr-2.txt: Ditto.
	* tests/data/test-diff-suppr/test24-soname-suppr-3.txt: Ditto.
	* tests/data/test-diff-suppr/test24-soname-suppr-4.txt: Ditto.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 tests/data/test-diff-suppr/test24-soname-suppr-0.txt | 2 +-
 tests/data/test-diff-suppr/test24-soname-suppr-1.txt | 2 +-
 tests/data/test-diff-suppr/test24-soname-suppr-2.txt | 2 +-
 tests/data/test-diff-suppr/test24-soname-suppr-3.txt | 2 +-
 tests/data/test-diff-suppr/test24-soname-suppr-4.txt | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

Comments

Matthias Maennich April 21, 2020, 10:24 a.m. UTC | #1
On Mon, Apr 20, 2020 at 06:23:38PM +0100, Giuliano Procida wrote:
>The property name "reached_through" should have been
>"accessed_through" and the property value "reference_or_pointer"
>should have been "reference-or-pointer".
>
>This patch fixes these issues.
>
>	* tests/data/test-diff-suppr/test24-soname-suppr-0.txt: Fix
>        typo, change "reached_through" to "accessed_through".
>	* tests/data/test-diff-suppr/test24-soname-suppr-1.txt: Ditto.
>	* tests/data/test-diff-suppr/test24-soname-suppr-2.txt: Ditto.
>	* tests/data/test-diff-suppr/test24-soname-suppr-3.txt: Ditto.
>	* tests/data/test-diff-suppr/test24-soname-suppr-4.txt: Ditto.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>

Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias

>---
> tests/data/test-diff-suppr/test24-soname-suppr-0.txt | 2 +-
> tests/data/test-diff-suppr/test24-soname-suppr-1.txt | 2 +-
> tests/data/test-diff-suppr/test24-soname-suppr-2.txt | 2 +-
> tests/data/test-diff-suppr/test24-soname-suppr-3.txt | 2 +-
> tests/data/test-diff-suppr/test24-soname-suppr-4.txt | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-0.txt b/tests/data/test-diff-suppr/test24-soname-suppr-0.txt
>index 2fb72ef3..4229dddb 100644
>--- a/tests/data/test-diff-suppr/test24-soname-suppr-0.txt
>+++ b/tests/data/test-diff-suppr/test24-soname-suppr-0.txt
>@@ -2,4 +2,4 @@
>   soname_regexp = ^libtest24-soname$
>   name = S
>   type_kind = struct
>-  reached_through = reference_or_pointer
>+  accessed_through = reference-or-pointer
>diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-1.txt b/tests/data/test-diff-suppr/test24-soname-suppr-1.txt
>index 34ec72c0..7e6a8b2d 100644
>--- a/tests/data/test-diff-suppr/test24-soname-suppr-1.txt
>+++ b/tests/data/test-diff-suppr/test24-soname-suppr-1.txt
>@@ -1,4 +1,4 @@
> [suppress_type]
>   soname_regexp = ^libtest24-soname-<wrong-soname>$
>   name = S
>-  reached_through = reference_or_pointer
>+  accessed_through = reference-or-pointer
>diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-2.txt b/tests/data/test-diff-suppr/test24-soname-suppr-2.txt
>index 65b50fbb..f21dea13 100644
>--- a/tests/data/test-diff-suppr/test24-soname-suppr-2.txt
>+++ b/tests/data/test-diff-suppr/test24-soname-suppr-2.txt
>@@ -1,4 +1,4 @@
> [suppress_type]
>   file_name_regexp = (^|/)libtest24-soname-v0\\.so$
>   name = S
>-  reached_through = reference_or_pointer
>+  accessed_through = reference-or-pointer
>diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-3.txt b/tests/data/test-diff-suppr/test24-soname-suppr-3.txt
>index f72fd141..e17c4e3f 100644
>--- a/tests/data/test-diff-suppr/test24-soname-suppr-3.txt
>+++ b/tests/data/test-diff-suppr/test24-soname-suppr-3.txt
>@@ -1,4 +1,4 @@
> [suppress_type]
>   file_name_regexp = (^|/)libtest24-soname-v1\\.so$
>   name = S
>-  reached_through = reference_or_pointer
>+  accessed_through = reference-or-pointer
>diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-4.txt b/tests/data/test-diff-suppr/test24-soname-suppr-4.txt
>index 29a0b6ec..4f970490 100644
>--- a/tests/data/test-diff-suppr/test24-soname-suppr-4.txt
>+++ b/tests/data/test-diff-suppr/test24-soname-suppr-4.txt
>@@ -1,4 +1,4 @@
> [suppress_type]
>   file_name_regexp = (^|/)libtest24-soname-<wrong-file-name>\\.so$
>   name = S
>-  reached_through = reference_or_pointer
>+  accessed_through = reference-or-pointer
>-- 
>2.26.1.301.g55bc3eb7cb9-goog
>
Dodji Seketeli April 22, 2020, 3:05 p.m. UTC | #2
Giuliano Procida <gprocida@google.com> a ?crit:

> The property name "reached_through" should have been
> "accessed_through" and the property value "reference_or_pointer"
> should have been "reference-or-pointer".
>
> This patch fixes these issues.
>
> 	* tests/data/test-diff-suppr/test24-soname-suppr-0.txt: Fix
>         typo, change "reached_through" to "accessed_through".
> 	* tests/data/test-diff-suppr/test24-soname-suppr-1.txt: Ditto.
> 	* tests/data/test-diff-suppr/test24-soname-suppr-2.txt: Ditto.
> 	* tests/data/test-diff-suppr/test24-soname-suppr-3.txt: Ditto.
> 	* tests/data/test-diff-suppr/test24-soname-suppr-4.txt: Ditto.

Applied to master, thanks!

Cheers,
diff mbox series

Patch

diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-0.txt b/tests/data/test-diff-suppr/test24-soname-suppr-0.txt
index 2fb72ef3..4229dddb 100644
--- a/tests/data/test-diff-suppr/test24-soname-suppr-0.txt
+++ b/tests/data/test-diff-suppr/test24-soname-suppr-0.txt
@@ -2,4 +2,4 @@ 
   soname_regexp = ^libtest24-soname$
   name = S
   type_kind = struct
-  reached_through = reference_or_pointer
+  accessed_through = reference-or-pointer
diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-1.txt b/tests/data/test-diff-suppr/test24-soname-suppr-1.txt
index 34ec72c0..7e6a8b2d 100644
--- a/tests/data/test-diff-suppr/test24-soname-suppr-1.txt
+++ b/tests/data/test-diff-suppr/test24-soname-suppr-1.txt
@@ -1,4 +1,4 @@ 
 [suppress_type]
   soname_regexp = ^libtest24-soname-<wrong-soname>$
   name = S
-  reached_through = reference_or_pointer
+  accessed_through = reference-or-pointer
diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-2.txt b/tests/data/test-diff-suppr/test24-soname-suppr-2.txt
index 65b50fbb..f21dea13 100644
--- a/tests/data/test-diff-suppr/test24-soname-suppr-2.txt
+++ b/tests/data/test-diff-suppr/test24-soname-suppr-2.txt
@@ -1,4 +1,4 @@ 
 [suppress_type]
   file_name_regexp = (^|/)libtest24-soname-v0\\.so$
   name = S
-  reached_through = reference_or_pointer
+  accessed_through = reference-or-pointer
diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-3.txt b/tests/data/test-diff-suppr/test24-soname-suppr-3.txt
index f72fd141..e17c4e3f 100644
--- a/tests/data/test-diff-suppr/test24-soname-suppr-3.txt
+++ b/tests/data/test-diff-suppr/test24-soname-suppr-3.txt
@@ -1,4 +1,4 @@ 
 [suppress_type]
   file_name_regexp = (^|/)libtest24-soname-v1\\.so$
   name = S
-  reached_through = reference_or_pointer
+  accessed_through = reference-or-pointer
diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-4.txt b/tests/data/test-diff-suppr/test24-soname-suppr-4.txt
index 29a0b6ec..4f970490 100644
--- a/tests/data/test-diff-suppr/test24-soname-suppr-4.txt
+++ b/tests/data/test-diff-suppr/test24-soname-suppr-4.txt
@@ -1,4 +1,4 @@ 
 [suppress_type]
   file_name_regexp = (^|/)libtest24-soname-<wrong-file-name>\\.so$
   name = S
-  reached_through = reference_or_pointer
+  accessed_through = reference-or-pointer