diff mbox series

[2/3] test35-leaf.suppr: fix regex typo.

Message ID 20200420164153.5213-2-gprocida@google.com
State Committed
Headers show
Series [1/3] test-diff-suppr: Improve regexes in tests. | expand

Commit Message

Giuliano Procida April 20, 2020, 4:41 p.m. UTC
Bad regexes are silently ignored. This will be fixed in a later
commit.

	* tests/data/test-diff-suppr/test35-leaf.suppr: Fix typo in
	regex, "*." -> ".*".

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 tests/data/test-diff-suppr/test35-leaf.suppr | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matthias Maennich April 21, 2020, 10:20 a.m. UTC | #1
On Mon, Apr 20, 2020 at 05:41:51PM +0100, Giuliano Procida wrote:
>Bad regexes are silently ignored. This will be fixed in a later
>commit.
>
>	* tests/data/test-diff-suppr/test35-leaf.suppr: Fix typo in
>	regex, "*." -> ".*".
>

Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias
>Signed-off-by: Giuliano Procida <gprocida@google.com>
>---
> tests/data/test-diff-suppr/test35-leaf.suppr | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tests/data/test-diff-suppr/test35-leaf.suppr b/tests/data/test-diff-suppr/test35-leaf.suppr
>index b4ec73c8..b49293ec 100644
>--- a/tests/data/test-diff-suppr/test35-leaf.suppr
>+++ b/tests/data/test-diff-suppr/test35-leaf.suppr
>@@ -4,5 +4,5 @@
>   # member named 'member0'.  That would be the type named
>   # leaf_to_filter.
>
>-  name_regexp = *.
>+  name_regexp = .*
>   has_data_member_inserted_between = {offset_after(member0), end}
>-- 
>2.26.1.301.g55bc3eb7cb9-goog
>
Dodji Seketeli April 22, 2020, 1:56 p.m. UTC | #2
Giuliano Procida <gprocida@google.com> a ?crit:

> Bad regexes are silently ignored. This will be fixed in a later
> commit.
>
> 	* tests/data/test-diff-suppr/test35-leaf.suppr: Fix typo in
> 	regex, "*." -> ".*".

Applied to master, thanks!

Cheers,
diff mbox series

Patch

diff --git a/tests/data/test-diff-suppr/test35-leaf.suppr b/tests/data/test-diff-suppr/test35-leaf.suppr
index b4ec73c8..b49293ec 100644
--- a/tests/data/test-diff-suppr/test35-leaf.suppr
+++ b/tests/data/test-diff-suppr/test35-leaf.suppr
@@ -4,5 +4,5 @@ 
   # member named 'member0'.  That would be the type named
   # leaf_to_filter.
 
-  name_regexp = *.
+  name_regexp = .*
   has_data_member_inserted_between = {offset_after(member0), end}