diff mbox series

make: add distcheck-fast target

Message ID 20200420074605.109076-1-maennich@google.com
State Committed
Headers show
Series make: add distcheck-fast target | expand

Commit Message

Matthias Maennich April 20, 2020, 7:46 a.m. UTC
The default compression flag defined by automake via GZIP_ENV is --best.
That is pretty expensive for when you just want to make sure your change
is done properly to pass 'make distcheck'.

Hence add a convenience target 'make distcheck-fast' that sets GZIP_ENV
to --fast and runs distcheck with that.

On my machine, this almost cuts the 'make distcheck' time in half:

 distcheck       4min 40s
 distcheck-fast  2min 32s

This is not invasive as it does not change the existing distcheck
target.

	* Makefile.am: add distcheck-fast make target

Signed-off-by: Matthias Maennich <maennich@google.com>
---
 Makefile.am | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Dodji Seketeli April 20, 2020, 12:38 p.m. UTC | #1
Matthias Maennich <maennich@google.com> a ?crit:

> The default compression flag defined by automake via GZIP_ENV is --best.
> That is pretty expensive for when you just want to make sure your change
> is done properly to pass 'make distcheck'.
>
> Hence add a convenience target 'make distcheck-fast' that sets GZIP_ENV
> to --fast and runs distcheck with that.
>
> On my machine, this almost cuts the 'make distcheck' time in half:
>
>  distcheck       4min 40s
>  distcheck-fast  2min 32s
>
> This is not invasive as it does not change the existing distcheck
> target.
>
> 	* Makefile.am: add distcheck-fast make target

Applied to master.  Thanks!

Cheers,
Mark Wielaard April 22, 2020, 11:19 a.m. UTC | #2
On Mon, 2020-04-20 at 14:38 +0200, Dodji Seketeli wrote:
> Matthias Maennich <maennich@google.com> a ?crit:
> 
> > The default compression flag defined by automake via GZIP_ENV is --best.
> > That is pretty expensive for when you just want to make sure your change
> > is done properly to pass 'make distcheck'.
> > 
> > Hence add a convenience target 'make distcheck-fast' that sets GZIP_ENV
> > to --fast and runs distcheck with that.
> > 
> > On my machine, this almost cuts the 'make distcheck' time in half:
> > 
> >  distcheck       4min 40s
> >  distcheck-fast  2min 32s
> > 
> > This is not invasive as it does not change the existing distcheck
> > target.
> > 
> > 	* Makefile.am: add distcheck-fast make target
> 
> Applied to master.  Thanks!

It also saves minutes on my machine. So I am using make distcheck-fast
on the buildbot workers too now. Hopefully that will speed up things
there too.

Thanks,

Mark

P.S. The ppc64 and ppc64le workers are down at the moment. They should
hopefully get back online soon (and go through the backlog).
https://builder.wildebeest.org/buildbot/#/pendingbuildrequests
diff mbox series

Patch

diff --git a/Makefile.am b/Makefile.am
index 396d64238840..f4dbff250059 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -82,3 +82,9 @@  tarball-and-all: tag-and-all
 
 tag-and-all: distcheck
 	$(MAKE) tag-release-only
+
+# the default for GZIP_ENV is --best, which is pretty slow for check runs
+# distcheck-fast therefore compresses with --fast instead
+distcheck-fast:
+	$(MAKE) distcheck GZIP_ENV="--fast"
+