diff mbox series

[2/2] test-abidiff-exit.cc: Drop redundant --redundant.

Message ID 20200406084450.140975-2-gprocida@google.com
State Committed
Headers show
Series [1/2] Rename test-abidiff-exit/test-leaf[0-3] files. | expand

Commit Message

Giuliano Procida April 6, 2020, 8:44 a.m. UTC
* tests/test-abidiff-exit.cc: Drop obsolete --redundant flag
	and comment as --redundant is now implied by
	--leaf-changes-only.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 tests/test-abidiff-exit.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Matthias Maennich April 6, 2020, 11:25 a.m. UTC | #1
On Mon, Apr 06, 2020 at 09:44:50AM +0100, Android Kernel Team wrote:
>	* tests/test-abidiff-exit.cc: Drop obsolete --redundant flag
>	and comment as --redundant is now implied by
>	--leaf-changes-only.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>

Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias

>---
> tests/test-abidiff-exit.cc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/tests/test-abidiff-exit.cc b/tests/test-abidiff-exit.cc
>index af3711b2..25f58b34 100644
>--- a/tests/test-abidiff-exit.cc
>+++ b/tests/test-abidiff-exit.cc
>@@ -133,8 +133,7 @@ InOutSpec in_out_specs[] =
>     "data/test-abidiff-exit/test-leaf-more-v0.o",
>     "data/test-abidiff-exit/test-leaf-more-v1.o",
>     "",
>-    // --redundant - pending a bug fix
>-    "--no-show-locs --leaf-changes-only --redundant",
>+    "--no-show-locs --leaf-changes-only",
>     abigail::tools_utils::ABIDIFF_ABI_CHANGE
>     | abigail::tools_utils::ABIDIFF_ABI_INCOMPATIBLE_CHANGE,
>     "data/test-abidiff-exit/test-leaf-more-report.txt",
>-- 
>2.26.0.292.g33ef6b2f38-goog
>
>
Dodji Seketeli April 7, 2020, 1:22 p.m. UTC | #2
Giuliano Procida <gprocida@google.com> a ?crit:

> 	* tests/test-abidiff-exit.cc: Drop obsolete --redundant flag
> 	and comment as --redundant is now implied by
> 	--leaf-changes-only.

Applied to master.

Thanks!
diff mbox series

Patch

diff --git a/tests/test-abidiff-exit.cc b/tests/test-abidiff-exit.cc
index af3711b2..25f58b34 100644
--- a/tests/test-abidiff-exit.cc
+++ b/tests/test-abidiff-exit.cc
@@ -133,8 +133,7 @@  InOutSpec in_out_specs[] =
     "data/test-abidiff-exit/test-leaf-more-v0.o",
     "data/test-abidiff-exit/test-leaf-more-v1.o",
     "",
-    // --redundant - pending a bug fix
-    "--no-show-locs --leaf-changes-only --redundant",
+    "--no-show-locs --leaf-changes-only",
     abigail::tools_utils::ABIDIFF_ABI_CHANGE
     | abigail::tools_utils::ABIDIFF_ABI_INCOMPATIBLE_CHANGE,
     "data/test-abidiff-exit/test-leaf-more-report.txt",