diff mbox series

[3/3] abidiffpkg: Remove stray test report file.

Message ID 20200329170121.188147-3-gprocida@google.com
State Committed
Headers show
Series [1/3] abidiff: Remove blank line after typedef changes. | expand

Commit Message

Giuliano Procida March 29, 2020, 5:01 p.m. UTC
The file tests/data/test-diff-pkg/dirpkg-2-report-1.txt looks like it
was committed in error. It's not used, its contents don't match the
implied directories being compared and there are other tests that
cover the same functionality, with or without --no-abignore, anyway.

	* tests/data/Makefile.am: Removed
	tests/data/test-diff-pkg/dirpkg-2-report-1.txt.
	* tests/data/test-diff-pkg/dirpkg-2-report-1.txt: Removed.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 tests/data/Makefile.am                         |  1 -
 tests/data/test-diff-pkg/dirpkg-2-report-1.txt | 16 ----------------
 2 files changed, 17 deletions(-)
 delete mode 100644 tests/data/test-diff-pkg/dirpkg-2-report-1.txt

Comments

Matthias Maennich March 29, 2020, 5:31 p.m. UTC | #1
On Sun, Mar 29, 2020 at 06:01:21PM +0100, Giuliano Procida wrote:
>The file tests/data/test-diff-pkg/dirpkg-2-report-1.txt looks like it
>was committed in error. It's not used, its contents don't match the
>implied directories being compared and there are other tests that
>cover the same functionality, with or without --no-abignore, anyway.
>
>	* tests/data/Makefile.am: Removed
>	tests/data/test-diff-pkg/dirpkg-2-report-1.txt.
>	* tests/data/test-diff-pkg/dirpkg-2-report-1.txt: Removed.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>

Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias

>---
> tests/data/Makefile.am                         |  1 -
> tests/data/test-diff-pkg/dirpkg-2-report-1.txt | 16 ----------------
> 2 files changed, 17 deletions(-)
> delete mode 100644 tests/data/test-diff-pkg/dirpkg-2-report-1.txt
>
>diff --git a/tests/data/Makefile.am b/tests/data/Makefile.am
>index 277f5721..bb0fd83b 100644
>--- a/tests/data/Makefile.am
>+++ b/tests/data/Makefile.am
>@@ -1479,7 +1479,6 @@ test-diff-pkg/dirpkg-2-dir2/dir.abignore \
> test-diff-pkg/dirpkg-2-dir2/libobj-v0.so \
> test-diff-pkg/dirpkg-2-dir2/obj-v0.cc \
> test-diff-pkg/dirpkg-2-report-0.txt \
>-test-diff-pkg/dirpkg-2-report-1.txt \
> test-diff-pkg/dirpkg-3-dir1/libobj-v0.so \
> test-diff-pkg/dirpkg-3-dir1/obj-v0.cc \
> test-diff-pkg/dirpkg-3-dir2/.abignore \
>diff --git a/tests/data/test-diff-pkg/dirpkg-2-report-1.txt b/tests/data/test-diff-pkg/dirpkg-2-report-1.txt
>deleted file mode 100644
>index c7c34702..00000000
>--- a/tests/data/test-diff-pkg/dirpkg-2-report-1.txt
>+++ /dev/null
>@@ -1,16 +0,0 @@
>-================ changes of 'libobj-v0.so'===============
>-  Functions changes summary: 0 Removed, 1 Changed, 0 Added function
>-  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>-
>-  1 function with some indirect sub-type change:
>-
>-    [C] 'function void bar(S&)' has some indirect sub-type changes:
>-      parameter 1 of type 'S&' has sub-type changes:
>-        in referenced type 'struct S':
>-          type size changed from 32 to 64 bits
>-          1 data member insertion:
>-            'char S::mem1', at offset 32 (in bits)
>-
>-
>-================ end of changes of 'libobj-v0.so'===============
>-
>-- 
>2.26.0.rc2.310.g2932bb562d-goog
>
Dodji Seketeli April 1, 2020, 5:31 p.m. UTC | #2
Giuliano Procida <gprocida@google.com> a ?crit:

> The file tests/data/test-diff-pkg/dirpkg-2-report-1.txt looks like it
> was committed in error. It's not used, its contents don't match the
> implied directories being compared and there are other tests that
> cover the same functionality, with or without --no-abignore, anyway.

Good catch!

>
> 	* tests/data/Makefile.am: Removed
> 	tests/data/test-diff-pkg/dirpkg-2-report-1.txt.
> 	* tests/data/test-diff-pkg/dirpkg-2-report-1.txt: Removed.

Applied to master, thanks!
diff mbox series

Patch

diff --git a/tests/data/Makefile.am b/tests/data/Makefile.am
index 277f5721..bb0fd83b 100644
--- a/tests/data/Makefile.am
+++ b/tests/data/Makefile.am
@@ -1479,7 +1479,6 @@  test-diff-pkg/dirpkg-2-dir2/dir.abignore \
 test-diff-pkg/dirpkg-2-dir2/libobj-v0.so \
 test-diff-pkg/dirpkg-2-dir2/obj-v0.cc \
 test-diff-pkg/dirpkg-2-report-0.txt \
-test-diff-pkg/dirpkg-2-report-1.txt \
 test-diff-pkg/dirpkg-3-dir1/libobj-v0.so \
 test-diff-pkg/dirpkg-3-dir1/obj-v0.cc \
 test-diff-pkg/dirpkg-3-dir2/.abignore \
diff --git a/tests/data/test-diff-pkg/dirpkg-2-report-1.txt b/tests/data/test-diff-pkg/dirpkg-2-report-1.txt
deleted file mode 100644
index c7c34702..00000000
--- a/tests/data/test-diff-pkg/dirpkg-2-report-1.txt
+++ /dev/null
@@ -1,16 +0,0 @@ 
-================ changes of 'libobj-v0.so'===============
-  Functions changes summary: 0 Removed, 1 Changed, 0 Added function
-  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
-
-  1 function with some indirect sub-type change:
-
-    [C] 'function void bar(S&)' has some indirect sub-type changes:
-      parameter 1 of type 'S&' has sub-type changes:
-        in referenced type 'struct S':
-          type size changed from 32 to 64 bits
-          1 data member insertion:
-            'char S::mem1', at offset 32 (in bits)
-
-
-================ end of changes of 'libobj-v0.so'===============
-