From patchwork Fri Feb 3 10:59:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 55458 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C2CE038582B0 for ; Fri, 3 Feb 2023 10:59:43 +0000 (GMT) X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by sourceware.org (Postfix) with ESMTPS id ADFA23858D20 for ; Fri, 3 Feb 2023 10:59:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ADFA23858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 46E15240010; Fri, 3 Feb 2023 10:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1675421977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qKwnvsa0xy9TX90hlMZx47iEl5fFxbVfI2ga45zwTws=; b=oqckoqHvT7OAKdkBANxdpXqksYL3TqZK6CMXDv/f2+7Z5AU8ADZfDVEzJWOsUEJ0aiC9lD 8t07OlZ1cv978u0q9DL3Yw3NNasxVXeVmL+7wC1JBEbMPH1slIhxRRigo+dbystchIU/lL DoBdE0H81G9U5kVsEgyTq3JkkZLyr0euHuLPb5fse2mX/e6cAGlLEXUcFqok9rq1vdfvKc Ds6s7ysx/2B+lBzci/gvJnsR2au5bkyINGbRevYni1/aY7R+ilaZyMQS9M3kJGoBrvrk6Q l3XGLcFBaDkmZKzj+JXBKEwcSRuf9d/bvzpx+8MiXWTY3eLafMx6Cdz9xj1uaw== Received: by localhost (Postfix, from userid 1000) id 09B8C18F6A6; Fri, 3 Feb 2023 11:59:35 +0100 (CET) From: Dodji Seketeli To: libabigail@sourceware.org Cc: gprocida@google.com, Dodji Seketeli Subject: [PATCH 0/4] Fix duplicated corpora in corpus group Organization: Me, myself and I References: <878rhh8xwb.fsf@redhat.com> X-Operating-System: CentOS Stream release 9 X-URL: http://www.seketeli.net/~dodji Date: Fri, 03 Feb 2023 11:59:34 +0100 In-Reply-To: <878rhh8xwb.fsf@redhat.com> (Dodji Seketeli via Libabigail's message of "Wed, 01 Feb 2023 11:48:04 +0100") Message-ID: <87mt5vt3op.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, Giuliano Procida brought to my attention that the ABI representation emitted by abidw from current mainline wrongly duplicates every single corpus in a corpus group represented in the ABIXML output. The last patch of this series fixes the issue. While testing that patch however, Giuliano noted other unrelated issues with the code base. The first three patches of the series address those lateral problems. This series is applied to the mainline. Dodji Seketeli (4): fe-iface: Add missing virtual destructor dwarf-reader: Remove unused code corpus: Handle empty symbol table cases {dwarf,elf_based}-reader,writer: Avoid duplicating corpora in corpus_group include/abg-fe-iface.h | 2 +- src/abg-corpus.cc | 58 +++++++++++++++++++++++++------------ src/abg-dwarf-reader.cc | 44 ---------------------------- src/abg-elf-based-reader.cc | 4 +-- src/abg-writer.cc | 45 ++++++++++++++++++++++++++-- 5 files changed, 85 insertions(+), 68 deletions(-)