From patchwork Thu Sep 7 13:32:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 56092 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EFC873858433 for ; Thu, 7 Sep 2023 13:32:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFC873858433 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1694093578; bh=6o5IgUkwQx/02TQhmV5ItXrw5yE3eupPahwE7iMgE3s=; h=To:Subject:CC:Date:List-Id:List-Unsubscribe:List-Archive: List-Help:List-Subscribe:From:Reply-To:From; b=CYXCxyYLbx26EjBPxkOcDEgY+V9xpLEDsMtEbh1FQu4H41lfgh9IIZ0harqcgMTyD 0pysnVeSB1p6f5MI1QiLY2izVhczYCK/vOFtwh967TOqOHb6nAOiTRpke5i1ZfDTlU Hh4NcZa3u+oWmC6pOzSpyJ1Bj1oLO+YQ1d5r7VQQ= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7F9C43857026 for ; Thu, 7 Sep 2023 13:32:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F9C43857026 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-UJuTpLAzPneEXbkLuuyYgw-1; Thu, 07 Sep 2023 09:32:50 -0400 X-MC-Unique: UJuTpLAzPneEXbkLuuyYgw-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7708bf37635so106032485a.3 for ; Thu, 07 Sep 2023 06:32:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694093569; x=1694698369; h=mime-version:user-agent:message-id:date:cc:organization:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6o5IgUkwQx/02TQhmV5ItXrw5yE3eupPahwE7iMgE3s=; b=KR6f/H6xBrDMR3lNksn3Bwr6F0q7ecuqD9r/lCskU/Fvrct3qk2V3eFvOZl743h1vw lAPV1hUPkZB+8YSR+Jnkz/2VAJkxIRTNZ3G7Dt97TUGLlBcdkveCNuZ/8m4llW2haxAV wF+1paijPZoiorz935k5iLxueZGTtlmjoPu70Fm/4HQOUkzhIQUbP/jUNADYALThz3Mb /CU5yKxpEhx8AfeQz/TLfuJlV26J4MzLX6Pd/K3QjL+3xCWVYno6wdF0KYiv0R+p1MEr pyv2wvia3YTWNHIx2Ifv+hujTWVpTDcKOy6qQz9eeHL/+TT557A6/KFh1bh5l6MkKZkD YIkA== X-Gm-Message-State: AOJu0YyMWv1CfOMWEW1OIs7kxBixaquhW4dvsadQJGGEq10JqUYGygzW EPsWBGJytHpNSFHXpt53aRIUG45Zupxz/T5BmoN8G6eJukU6YnKFws9n2xTdczfEwGs08ZYKaEG 9d4sg7cAqG8k9nheKhKuT X-Received: by 2002:a05:620a:1924:b0:767:2b14:6898 with SMTP id bj36-20020a05620a192400b007672b146898mr23849984qkb.49.1694093569289; Thu, 07 Sep 2023 06:32:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGOguBG/kQzdU9m5QrjCUJ9NbAhcoC5tWgfp5/8ZSyRJeV8+2vHcEwCJMNo/77LHY0gN//6xw== X-Received: by 2002:a05:620a:1924:b0:767:2b14:6898 with SMTP id bj36-20020a05620a192400b007672b146898mr23849965qkb.49.1694093568976; Thu, 07 Sep 2023 06:32:48 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id t9-20020a05620a034900b0075ca4cd03d4sm5766981qkm.64.2023.09.07.06.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 06:32:48 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 7026AB4FD2; Thu, 7 Sep 2023 15:32:46 +0200 (CEST) To: dodji@redhat.com Subject: [PATCH 00/16] Fixing various issues found while working on PR30309 Organization: Red Hat / France CC: libabigail@sourceware.org X-Operating-System: CentOS Stream release 9 X-URL: http://www.redhat.com Date: Thu, 07 Sep 2023 15:32:46 +0200 Message-ID: <87il8mglc1.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_WEB, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, While working on the problem report 30309 at https://sourceware.org/bugzilla/show_bug.cgi?id=30309, I found several smaller related issues that could be addressed independently from the reported problem itself. As the initial issue still needs more care, I think it's worthwhile to merge the following patches into the main line the source code. Please note that the original issue is being handled in the branch "canonicalize-types-in-order" at https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/canonicalize-types-in-order. I am thus merging the patches that follows this message into the main branches, from the "canonicalize-types-in-order" branch. Dodji Seketeli (16): reader: fix indentation tools-utils: Fix indentation dwarf-reader,ir: Make logging a property of the middle end dwarf-reader: Fix some logging abipkgdiff: Initialize libxml2 to use it in a multi-thread context tools-utils: Avoid endless loop {dwarf,elf}reader: Don't consider no symbol table as an error abipkgdiff: Avoid comparing binaries that are outside of the package ir: Add missing ABG_RETURN in the comparison engine ir: Add fn types to type lookup maps ir: Fix forgetting canonicalizing some function types ir: Avoid forgetting potential seemingly duplicated member functions ir: Really avoid canonicalizing decl-only classes ir: Use non qualified typedef name for type canonicalization ir: Fix qualification as non-confirmed propagated canonical types dwarf-reader: Do not re-use typedefs in a scope include/abg-fwd.h | 8 +- include/abg-ir.h | 11 +- include/abg-tools-utils.h | 1 + src/abg-dwarf-reader.cc | 38 +- src/abg-elf-reader.cc | 8 +- src/abg-ir-priv.h | 21 +- src/abg-ir.cc | 328 +- src/abg-reader.cc | 76 +- src/abg-tools-utils.cc | 40 +- tests/data/Makefile.am | 2 + .../test-abidiff/test-PR18791-report0.txt | 13 - tests/data/test-annotate/libtest23.so.abi | 453 +- .../test-annotate/libtest24-drop-fns-2.so.abi | 598 +- .../test-annotate/libtest24-drop-fns.so.abi | 598 +- .../data/test-annotate/test15-pr18892.so.abi | 14179 ++-- .../data/test-annotate/test17-pr19027.so.abi | 2162 +- ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 8862 +-- ...19-pr19023-libtcmalloc_and_profiler.so.abi | 7403 +- ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 10938 +-- .../data/test-annotate/test21-pr19092.so.abi | 88 +- .../test42-PR21296-clanggcc-report0.txt | 14 +- .../test31-pr18535-libstdc++-report-0.txt | 31 +- .../test31-pr18535-libstdc++-report-1.txt | 31 +- .../data/test-diff-filter/test41-report-0.txt | 30 +- .../symlink-dir-test1-report1.txt | 0 .../symlink-dir-test1-report1.txt | 0 .../PR22015-libboost_iostreams.so.abi | 2291 +- .../test-read-dwarf/PR22122-libftdc.so.abi | 14659 ++-- .../data/test-read-dwarf/PR25007-sdhci.ko.abi | 8778 +-- tests/data/test-read-dwarf/libtest23.so.abi | 447 +- .../libtest24-drop-fns-2.so.abi | 586 +- .../test-read-dwarf/libtest24-drop-fns.so.abi | 586 +- .../test-read-dwarf/test-libaaudio.so.abi | 8 +- .../test-read-dwarf/test-libandroid.so.abi | 12052 ++-- tests/data/test-read-dwarf/test0.hash.abi | 4 +- tests/data/test-read-dwarf/test1.hash.abi | 10 +- .../test-read-dwarf/test10-pr18818-gcc.so.abi | 3136 +- .../test-read-dwarf/test11-pr18828.so.abi | 11668 ++-- .../test-read-dwarf/test12-pr18844.so.abi | 24630 ++++--- .../test-read-dwarf/test15-pr18892.so.abi | 13995 ++-- .../test-read-dwarf/test16-pr18904.so.abi | 16831 ++--- .../test-read-dwarf/test17-pr19027.so.abi | 2132 +- ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 8768 +-- ...19-pr19023-libtcmalloc_and_profiler.so.abi | 7127 +- ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 10671 +-- .../test-read-dwarf/test21-pr19092.so.abi | 82 +- .../test22-pr19097-libstdc++.so.6.0.17.so.abi | 57411 ++++++++-------- .../test9-pr18818-clang.so.abi | 3545 +- .../test28-without-std-fns-ref.xml | 350 +- .../test28-without-std-vars-ref.xml | 348 +- tests/test-diff-pkg.cc | 32 +- tools/abipkgdiff.cc | 27 +- 52 files changed, 121298 insertions(+), 124809 deletions(-) create mode 100644 tests/data/test-diff-pkg-ctf/symlink-dir-test1-report1.txt create mode 100644 tests/data/test-diff-pkg/symlink-dir-test1-report1.txt Signed-off-by: Dodji Seketeli Signed-off-by: Dodji Seketeli Signed-off-by: Dodji Seketeli